Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Print the queries that were executed if assert_queries fails | Tarmo Tänav | 2008-08-26 | 1 | -1/+1 | |
| | ||||||
* | Merge branch 'master' of git@github.com:rails/rails | Jeremy Kemper | 2008-08-26 | 1 | -2/+2 | |
|\ | ||||||
| * | PostgreSQL: pg driver expects nil instead of empty string for missing user/pass | Jeremy Kemper | 2008-08-26 | 1 | -2/+2 | |
| | | ||||||
* | | Back to fetching all versions in ruby instead of letting SQL do it as it's ↵ | Tarmo Tänav | 2008-08-26 | 1 | -5/+6 | |
|/ | | | | | | difficult to get all databases to convert the text value to a number with the same SQL Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | add dynamic finder bang version to raise RecordNotFound | Josh Susser | 2008-08-25 | 2 | -1/+10 | |
| | | | | | | [#905 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | refactor dynamic finder name matching into its own class | Josh Susser | 2008-08-25 | 3 | -72/+83 | |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Use DECIMAL instead of INTEGER when casting as mysql doesn't work with just ↵ | Tarmo Tänav | 2008-08-25 | 1 | -3/+8 | |
| | | | | | | | | "INTEGER" and other databases don't like "UNSIGNED" which mysql requires And don't mask exceptions. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Cache migrated versions list in Migrator and use it to fetch the latest ↵ | Tarmo Tänav | 2008-08-25 | 1 | -6/+8 | |
| | | | | | | | | | | | | migrated version name [#845 state:resolved] Also optimized Migrator#current_version class method to fetch only the latest version number and not all of them. With this change no matter how many migrations there are the schema_migrations table is only SELECTed from once. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Load the first and not the last has_one result when doing join-based eager ↵ | Tarmo Tänav | 2008-08-25 | 1 | -0/+1 | |
| | | | | | | | | | | | loading This matters when the has_one is defined with an order in which case there is an expectation that the first one will be loaded. [#904 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Implement old-skool eagerloading for has_one :through | Frederick Cheung | 2008-08-25 | 1 | -2/+2 | |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Harmonize framework require strategy. Don't add self to load path since ↵ | Jeremy Kemper | 2008-08-25 | 1 | -10/+7 | |
| | | | | Rails initializer and RubyGems handle it. | |||||
* | Fix preloading of has_one through associations | Frederick Cheung | 2008-08-25 | 1 | -6/+2 | |
| | | | | | | [#903 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Merge branch 'patches' | Michael Koziarski | 2008-08-24 | 2 | -2/+26 | |
|\ | ||||||
| * | Rollback the transaction when a before_* callback returns false. | Xavier Noria | 2008-08-24 | 2 | -2/+26 | |
| | | | | | | | | | | | | | | Previously this would have committed the transaction but not carried out save or destroy operation. [#891 state:committed] Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | | Ruby 1.9 compat: Hash is now flattenable, so explicitly exclude it | Jeremy Kemper | 2008-08-23 | 1 | -1/+1 | |
| | | ||||||
* | | Don't set "NULL" as a constraint on nullable columns [#398 state:resolved] | Tarmo Tänav | 2008-08-23 | 1 | -6/+2 | |
|/ | | | | This is already the default and adding it breaks SQL standards compatibility. | |||||
* | Always require activesupport, even if its constant already exists | Tarmo Tänav | 2008-08-23 | 1 | -10/+8 | |
| | | | | | | | | | | This is needed because the existance of the ActiveSupport constant by itself does not guarantee that the whole library has been loaded. Also load the StringInquirer in the Rails#env method as the it might be called inside the initializer block before activesupport itself has been loaded. | |||||
* | coerce blank strings to nil values for boolean and integer fields | Josh Susser | 2008-08-22 | 2 | -6/+13 | |
| | | | | [#860 state:resolved] | |||||
* | Made migrations transactional for PostgreSQL [#834 state:resolved] | Tarmo Tänav | 2008-08-22 | 3 | -4/+32 | |
| | | | | Patch originally from http://dev.rubyonrails.org/ticket/5470 | |||||
* | Merge branch 'master' into i18n | Jeremy Kemper | 2008-08-22 | 2 | -6/+7 | |
|\ | ||||||
| * | Ensure t.timestamps respects options. [#828 state:resolved] | Patrick Reagan | 2008-08-22 | 1 | -3/+4 | |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
| * | Properly quote CREATE DATABASE parameters in postgresql [#771 state:resolved] | Tarmo Tänav | 2008-08-22 | 1 | -3/+3 | |
| | | ||||||
* | | Merge commit 'sven/i18n' into i18n | Jeremy Kemper | 2008-08-22 | 5 | -84/+139 | |
|\ \ | |/ |/| | ||||||
| * | Merge branch 'master' into i18n | Sven Fuchs | 2008-08-21 | 14 | -50/+54 | |
| |\ | ||||||
| * | | Custom error messages scope improved | Iain Hecker | 2008-08-21 | 1 | -14/+14 | |
| | | | ||||||
| * | | Removed en-US ruby locale in favor of yaml | Iain Hecker | 2008-08-20 | 1 | -28/+0 | |
| | | | ||||||
| * | | Locale file changed to yaml | Iain Hecker | 2008-08-20 | 2 | -1/+34 | |
| | | | ||||||
| * | | Added :value as interpolation variable available to error messages | Iain Hecker | 2008-08-20 | 1 | -8/+10 | |
| | | | ||||||
| * | | Introduced AR::Base.human_name to validations | Iain Hecker | 2008-08-20 | 1 | -1/+1 | |
| | | | ||||||
| * | | Added Base.human_name method | Iain Hecker | 2008-08-20 | 1 | -0/+13 | |
| | | | ||||||
| * | | Cleaned up ActiveRecord i18n scoping | Iain Hecker | 2008-08-14 | 3 | -82/+116 | |
| | | | ||||||
| * | | provide more useful feedback on missing translations for validation error ↵ | Sven Fuchs | 2008-08-13 | 1 | -1/+1 | |
| | | | | | | | | | | | | messages | |||||
| * | | switch to using I18n.load_translations instead of requiring plain ruby files | Sven Fuchs | 2008-08-13 | 2 | -24/+25 | |
| | | | ||||||
| * | | update i18n usage for pluralization hashes (api change) | Sven Fuchs | 2008-08-10 | 1 | -1/+1 | |
| | | | ||||||
* | | | Revert "Performance: freeze cached rows instead of duping" | Jeremy Kemper | 2008-08-21 | 2 | -5/+14 | |
| | | | | | | | | | | | | This reverts commit cd8e653d5b18e6d3c3acc9930832f8e23945e392. | |||||
* | | | Revert "coerce blank strings to nil values for boolean and integer fields" | Jeremy Kemper | 2008-08-21 | 2 | -13/+6 | |
| | | | | | | | | | | | | | | | | | | This reverts commit aee14630d4dc0856e597794cc731fac68c2d2e34. [#860 state:incomplete] | |||||
* | | | coerce blank strings to nil values for boolean and integer fields | Josh Susser | 2008-08-21 | 2 | -6/+13 | |
| |/ |/| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | | Don't interpret decimals as table names in ↵ | Peter Wagenet | 2008-08-21 | 1 | -3/+3 | |
| | | | | | | | | | | | | ActiveRecord::Associations::ClassMethods#references_eager_loaded_tables? [#532 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Fix incorrect signature for NamedScope#respond_to? [#852 state:resolved] | Tom Lea | 2008-08-21 | 1 | -2/+2 | |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Fix postgres bug when change_column is called with invalid parameters. [#861 ↵ | Miles Georgi | 2008-08-21 | 1 | -1/+2 | |
| | | | | | | | | | | | | | | state:resolved] Signed-off-by: Tarmo Tänav <tarmo@itech.ee> Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Fix generated WHERE IN query for named scopes. [#583 state:resolved] | Philip Hallstrom | 2008-08-21 | 1 | -1/+1 | |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Fix has_many#count_records. [#865 state:resolved] | Xavier Noria | 2008-08-21 | 1 | -2/+5 | |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Fix that has_one natural assignment to already associated record. [#854 ↵ | Jakub Kuźma | 2008-08-21 | 1 | -2/+2 | |
| | | | | | | | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Support find_all on named scopes. [#730 state:resolved] | Ryan Bates | 2008-08-21 | 1 | -1/+1 | |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Performance: freeze cached rows instead of duping | Jeremy Kemper | 2008-08-18 | 2 | -14/+5 | |
| | | ||||||
* | | Updated has_and_belongs_to_many association to fix :finder_sql ↵ | Nathan Witmer | 2008-08-16 | 2 | -7/+1 | |
| | | | | | | | | | | | | interpolation. [#848 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Fixed STI type condition for eager loading of associations | Tarmo Tänav | 2008-08-16 | 2 | -7/+6 | |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Don't raise exception when comparing ActiveRecord::Reflection. [#842 ↵ | Ryan Bates | 2008-08-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Use type_condition method for hmt STI condition | Tarmo Tänav | 2008-08-15 | 1 | -1/+1 | |
| | | ||||||
* | | Fixed validates_uniqueness_of with decimal columns | Tarmo Tänav | 2008-08-15 | 1 | -5/+4 | |
| | | | | | | | | | | | | Only use special case-sensitive comparison operators for text columns in validates_uniqueness_of as mysql can fail at decimal comparisons with the BINARY operator. |