Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | Merge pull request #10767 from jmondo/master | Carlos Antonio da Silva | 2013-05-29 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | Use grep instead of select with === in QueryMethods | |||||
| * | | | use grep over select for consistency and efficiency | John Gesimondo | 2013-05-28 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | pass block directly to grep | |||||
* | | | | Merge pull request #10766 from kylerippey/minor_schema_migration_refactor | Rafael Mendonça França | 2013-05-28 | 1 | -18/+24 | |
|\ \ \ \ | | | | | | | | | | | Minor refactor of ActiveRecord::SchemaMigration | |||||
| * | | | | Minor refactor of ActiveRecord::SchemaMigration to remove references to ↵ | Kyle Rippey | 2013-05-26 | 1 | -18/+24 | |
| |/ / / | | | | | | | | | | | | | Base, override table_exists method, and switch to preferred style for class method definitions. | |||||
* | | | | `implicit_readonly` is being removed in favor of calling `readonly` explicitly | Yves Senn | 2013-05-27 | 2 | -10/+1 | |
| | | | | ||||||
* | | | | cleanup whitespace in `active_record/relation.rb`. | Yves Senn | 2013-05-27 | 1 | -4/+4 | |
|/ / / | ||||||
* | | | Merge pull request #10713 from senny/10693_fix_primary_key_option_on_has_many | Rafael Mendonça França | 2013-05-23 | 1 | -2/+1 | |
|\ \ \ | | | | | | | | | Fix the `:primary_key` option for `has_many` associations. | |||||
| * | | | Fix the `:primary_key` option for `has_many` associations. | Yves Senn | 2013-05-23 | 1 | -2/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When removing records from a `has_many` association it used the `primary_key` defined on the association. Our test suite didn't fail because on all occurences of `:primary_key`, the specified column was available in both tables. This prevented the code from raising an exception but it still behaved badly. I added a test-case to prevent regressions that failed with: ``` 1) Error: HasManyAssociationsTest#test_has_many_assignment_with_custom_primary_key: ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: essays.first_name: UPDATE "essays" SET "writer_id" = NULL WHERE "essays"."writer_id" = ? AND "essays"."first_name" IS NULL ``` | |||||
* | | | | deprecate Validator#setup (to get rid of a respond_to call). validators do ↵ | Nick Sutterer | 2013-05-23 | 1 | -6/+1 | |
|/ / / | | | | | | | | | | their setup in their constructor now. | |||||
* | | | remove code duplication | Neeraj Singh | 2013-05-22 | 1 | -2/+3 | |
| | | | ||||||
* | | | reverse comparison because of strange AS behavior | Aaron Patterson | 2013-05-21 | 1 | -1/+1 | |
| | | | | | | | | | | | | http://tenderlovemaking.com/2013/05/21/one-danger-of-freedom-patches.html | |||||
* | | | just set the default argument, a nil parent should be an error | Aaron Patterson | 2013-05-21 | 1 | -2/+1 | |
| | | | ||||||
* | | | fold the collection rather than multiple assigments | Aaron Patterson | 2013-05-21 | 1 | -3/+2 | |
| | | | ||||||
* | | | use drop rather than calculate the array length | Aaron Patterson | 2013-05-21 | 1 | -1/+1 | |
| | | | ||||||
* | | | Merge branch 'bindwhere' | Aaron Patterson | 2013-05-21 | 1 | -20/+20 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * bindwhere: avoid creating a set if no where values are removed remove bind values for where clauses that were removed push partitioning up so bind elimination can get the removed wheres push partion logic down and initialization logic up partition the where values so we can access the removed ones | |||||
| * | | | avoid creating a set if no where values are removed | Aaron Patterson | 2013-05-21 | 1 | -0/+2 | |
| | | | | ||||||
| * | | | remove bind values for where clauses that were removed | Aaron Patterson | 2013-05-21 | 1 | -9/+8 | |
| | | | | ||||||
| * | | | push partitioning up so bind elimination can get the removed wheres | Aaron Patterson | 2013-05-21 | 1 | -5/+3 | |
| | | | | ||||||
| * | | | push partion logic down and initialization logic up | Aaron Patterson | 2013-05-21 | 1 | -15/+11 | |
| | | | | ||||||
| * | | | partition the where values so we can access the removed ones | Aaron Patterson | 2013-05-20 | 1 | -1/+6 | |
| | | | | ||||||
* | | | | the rake task `db:test:prepare` needs to load the configuration | Yves Senn | 2013-05-21 | 1 | -1/+1 | |
|/ / / | | | | | | | | | | Without loading the configuration the task will not perform any work. | |||||
* | | | eliminate some conditionals | Aaron Patterson | 2013-05-20 | 1 | -3/+3 | |
| | | | ||||||
* | | | change method name to reflect what it actually does. | Aaron Patterson | 2013-05-20 | 1 | -2/+2 | |
| | | | ||||||
* | | | save the where values in variables so we don't need to look them up all | Aaron Patterson | 2013-05-20 | 1 | -4/+5 | |
| | | | | | | | | | | | | the time | |||||
* | | | pass where values to the helper function rather than rely on internal state | Aaron Patterson | 2013-05-20 | 1 | -4/+4 | |
| | | | ||||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-05-19 | 7 | -10/+42 | |
|\ \ \ | ||||||
| * | | | copy edits[ci skip] | Vijay Dev | 2013-05-19 | 2 | -12/+9 | |
| | | | | ||||||
| * | | | Added some more documentation for define_readers and define_writer of the ↵ | aditya-kapoor | 2013-05-15 | 3 | -0/+15 | |
| | | | | | | | | | | | | | | | | Association and its inherited classes | |||||
| * | | | Added some more documentation for ↵ | aditya-kapoor | 2013-05-15 | 1 | -0/+11 | |
| | | | | | | | | | | | | | | | | ActiveRecord::Associations::Builder::Association class | |||||
| * | | | Added documentation for ActiveRecord::Associations::Builder::Association class | aditya-kapoor | 2013-05-15 | 1 | -0/+4 | |
| | | | | ||||||
| * | | | improved doc for ActiveRecord#find_by_sql method (Refs #10599) [ci skip] | Anton Kalyaev | 2013-05-14 | 1 | -3/+4 | |
| | | | | ||||||
| * | | | Added documentation for model migration generation | aditya-kapoor | 2013-05-14 | 1 | -0/+4 | |
| | | | | ||||||
| * | | | emphasize that callbacks are called in destroy_all | Neeraj Singh | 2013-05-13 | 2 | -7/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cleaned up rdoc a bit emphasizing that callbacks are called. Also removed the stress on the fact that records are always removed. If callbacks return false then records will not be deleted. | |||||
* | | | | stop swallowing exceptions in assert_queries. Methods that raise an | Aaron Patterson | 2013-05-17 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | exception are unlikely to pass this assertion, but since the assertions raise an exception, the original exception is lost. | |||||
* | | | | stop doing assingments in an iterator | Aaron Patterson | 2013-05-17 | 1 | -2/+6 | |
| | | | | ||||||
* | | | | include bind values from the default scope | Aaron Patterson | 2013-05-17 | 1 | -2/+4 | |
| | | | | ||||||
* | | | | let Ruby do the is_a check for us | Aaron Patterson | 2013-05-16 | 1 | -3/+4 | |
| | | | | ||||||
* | | | | Add more data to AR::UnknownAttributeError | Bogdan Gusiev | 2013-05-16 | 2 | -1/+10 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | begin Topic.new("hello" => "world") rescue ActiveRecord::UnknownAttributeError => e e.record # => #<Topic ... > e.attribute # => "hello" end | |||||
* | | | | Merge pull request #10619 from alno/top_level_array_in_postgres_json | Aaron Patterson | 2013-05-16 | 2 | -1/+3 | |
|\ \ \ \ | | | | | | | | | | | Support array as root element in Postgresql JSON columns | |||||
| * | | | | Support array as root element in JSON | Alexey Noskov | 2013-05-14 | 2 | -1/+3 | |
| | | | | | ||||||
* | | | | | Check if APP_RAKEFILE is defined | Piotr Sarnacki | 2013-05-16 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | Fix detection of engine in rake db:load_config | Joel Cogen | 2013-05-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | Broken by d1d7c86d0c8dcb7e75a87644b330c4e9e7d6c1c1 | |||||
* | | | | | tiny types should only be integers when the length is <= 1. fixes #10620 | Aaron Patterson | 2013-05-15 | 1 | -3/+9 | |
| | | | | | ||||||
* | | | | | require things we need | Aaron Patterson | 2013-05-15 | 1 | -0/+1 | |
| | | | | | ||||||
* | | | | | Also support extensions in PostgreSQL 9.1, because this has been supported ↵ | kennyj | 2013-05-15 | 1 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | since 9.1. | |||||
* | | | | | deprecating string based terminators | Aaron Patterson | 2013-05-14 | 1 | -1/+3 | |
|/ / / / | ||||||
* | | | | Merge pull request #10556 from Empact/deprecate-schema-statements-distinct | Rafael Mendonça França | 2013-05-12 | 1 | -1/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Deprecate SchemaStatements#distinct, and make SchemaStatements#columns_for_distinct nodoc. Conflicts: activerecord/CHANGELOG.md | |||||
* | | | | Some editorial changes on the documentation. | Rafael Mendonça França | 2013-05-12 | 2 | -27/+27 | |
|/ / / | | | | | | | | | | | | | | | | | | | | | | * Remove some autolinks * Fix the rendered result * Change sql to SQL [ci skip] | |||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-05-12 | 4 | -4/+12 | |
|\ \ \ | | | | | | | | | | | | | | | | | Conflicts: activesupport/lib/active_support/callbacks.rb | |||||
| * | | | copy edits [ci skip] | Vijay Dev | 2013-05-12 | 1 | -5/+1 | |
| | | | |