| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
| |
introduced by 691aa20) [#1083]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
|
|
|
|
| |
state:resolved] [Adam Milligan, Pratik]
|
|
|
|
| |
There are several situations it doesn't cater for, and the inconsistency isn't worth blocking 2.2.
|
|
|
|
|
|
|
| |
association definition should not result in double records in the collection/double loads (#1110)
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1110 state:committed]
|
|
|
|
|
|
|
| |
readable.
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1068 status:committed]
|
| |
|
|
|
|
|
| |
Model.sum delegates typecasting to the column being summed. If that's not feasible, returns a string.
Model.avg always returns big decimal.
|
|
|
|
| |
ActiveRecord::Reflection::ThroughReflection.
|
|
|
|
| |
reflection logic
|
|
|
|
|
|
| |
state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
|
|
|
|
| |
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
methods
We have hit dramatic increase in tests time after upgrading rails.
Profiling revealed this particular place. After this fix our test times returned
back to norm.
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1173 state:committed]
|
|
|
|
|
|
|
|
| |
pool is empty
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1169 state:committed]
|
|
|
|
|
|
|
| |
After releasing monitor some connection(s) may appear in pool before monitor is re-aquired.
When this happens we'll wait for connection which is already available.
Signed-off-by: Michael Koziarski <michael@koziarski.com>
|
|
|
|
|
|
|
| |
newer versions of mysql
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1168 state:committed]
|
|
|
|
|
|
|
| |
collation [#1165 state:resolved]
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1165 state:committed]
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
::find_initial, :find_last, and ::find_all.
This is so when people override ActiveRecord::Base::find, the new ::find method will also be invoked by the dynamic finders.
Associations for instance do go through ::find, so this makes it more consistent.
Also removed the unnecessary deprecation silence blocks.
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1162 state:committed]
|
|
|
|
| |
Signed-off-by: Michael Koziarski <michael@koziarski.com>
|
|
|
|
|
|
| |
run even without a database connection
Signed-off-by: Michael Koziarski <michael@koziarski.com>
|
|
|
|
|
| |
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1084 state:committed]
|
|
|
|
|
|
|
| |
Add an additional conditions option to make it slightly easier for certain plugins.
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1087 state:committed]
|
|
|
|
|
|
|
| |
strings to avoid table aliasing problems.
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1077 state:committed]
|
|
|
|
|
|
|
|
|
|
| |
AssociationCollection now starts transactions by calling
AssociationCollection#transaction instead of @owner.transaction or
@reflection.klass.transaction.
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1081 state:committed]
|
|\ |
|
| |
| |
| |
| |
| |
| | |
previous release.
This allows people tracking non-release gems or git submodules to use the constants.
|
| |
| |
| |
| |
| |
| | |
[#1091 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
|
| |
| |
| |
| |
| |
| | |
[#1086 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
|
|/ |
|
|
|
|
| |
trac ticket
|
|
|
|
|
|
| |
Simple backend to load translations lazily. [#1048 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
|
|
|
|
|
|
| |
[#1044 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
|
|
|
|
| |
Signed-off-by: Michael Koziarski <michael@koziarski.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
groups count result.
Without this change count_records will group for the count in the query and return erroneous results.
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#937 state:committed]
|
|
|
|
|
|
| |
[#1043 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
|
|
|
|
| |
[#1030 state:resolved]
|
|
|
|
| |
class_inheritable_accessor, so that subclasses don't overwrite Base [#346 state:resolved]
|
| |
|
|
|
|
|
|
|
| |
attributes.
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#812 state:committed]
|
|
|
|
|
|
|
| |
saving and reloading the record)
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#142 state:committed]
|
| |
|
|
|
|
|
|
|
|
|
|
| |
values.
- Adds String#acts_like_string?
- Adds Chars#acts_like_string?
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1029 state:committed]
|
|
|
|
|
|
| |
newline characters
Signed-off-by: Michael Koziarski <michael@koziarski.com>
|
|
|
|
|
|
| |
[#1013 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
|
|
|
|
|
|
|
|
|
|
|
|
| |
using hash. [#474 state:resolved]"
This reverts commit e0750d6a5c7f621e4ca12205137c0b135cab444a.
Conflicts:
activerecord/CHANGELOG
activerecord/lib/active_record/associations.rb
activerecord/lib/active_record/associations/association_collection.rb
|
|
|
|
|
| |
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#892 state:committed]
|
|
|
|
|
|
| |
conversion block
Signed-off-by: Michael Koziarski <michael@koziarski.com>
|
|
|
|
| |
Signed-off-by: Michael Koziarski <michael@koziarski.com>
|
| |
|