aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* | Add test for read_attribute(:id) with non-standard PK.Jon Leighton2011-12-012-4/+18
| | | | | | | | | | | | | | | | Also make it actually work. It slows down all read_attribute accesses to map 'id' to whatever the PK actually is, inside read_attribute. So instead make sure the necessary methods are defined and that they redirect wherever they need to go.
* | Remove the need for type_cast_attribute.Jon Leighton2011-12-015-43/+52
| | | | | | | | This is good because it reduces duplication.
* | Get rid of the underscore versions of attribute methods!Jon Leighton2011-12-015-6/+35
| | | | | | | | This makes me happy!
* | Don't rely on underscore-prefixed attribute methods.Jon Leighton2011-12-013-48/+80
| | | | | | | | | | | | Define singleton methods on the attributes module instead. This reduces method pollution on the actual model classes. It also seems to make something faster, I am unsure why! O_o
* | Remove unnecessary *argsJon Leighton2011-12-011-2/+2
| |
* | Allow rescue responses to be configured through a railtie.José Valim2011-12-011-0/+7
| |
* | Add hackery to make Syck use encode_with/init_with. Fixes 1.8 after recent ↵Jon Leighton2011-12-011-0/+20
| | | | | | | | changes to attribute serialization.
* | If the table behind has no primary key, do not ask again and just return nil.Julius de Bruijn2011-11-301-1/+2
| |
* | consistencyJon Leighton2011-11-303-16/+16
| |
* | Don't check column type, you might implement a custom coder that serializes ↵Jon Leighton2011-11-301-1/+1
| | | | | | | | to a different type
* | omg computer science!Jon Leighton2011-11-303-24/+46
| | | | | | | | | | | | | | Implement a mini state machine for serialized attributes. This means we do not have to deserialize the values upon initialization, which means that if we never actually access the attribute, we never have to deserialize it.
* | Don't need second paramJon Leighton2011-11-302-4/+4
| |
* | No longer need to undef id as we are defining it ourselvesJon Leighton2011-11-301-3/+0
| |
* | Move some serialization stuff out of BaseJon Leighton2011-11-302-40/+42
| |
* | Extract attribute serialization code into a separate moduleJon Leighton2011-11-304-28/+49
| |
* | Use inheritance to avoid special-case code for the 'id' methodJon Leighton2011-11-303-8/+20
| |
* | #id is an alias for whatever the primary key isJon Leighton2011-11-301-1/+1
| |
* | fix indentJon Leighton2011-11-301-3/+3
|/
* s/is is/isVijay Dev2011-12-011-1/+1
|
* Revert "Implement ArraySerializer and move old serialization API to a new ↵José Valim2011-11-302-4/+4
| | | | | | | | | | | | | namespace." This reverts commit 8896b4fdc8a543157cdf4dfc378607ebf6c10ab0. Conflicts: activemodel/lib/active_model.rb activemodel/lib/active_model/serializable.rb activemodel/lib/active_model/serializer.rb activemodel/test/cases/serializer_test.rb
* ActiveRecord::Relation#pluck methodBogdan Gusiev2011-11-303-2/+19
|
* push synchronization in to each method. Reduces method calls and makesAaron Patterson2011-11-291-25/+29
| | | | it clear which methods are synchronized.
* Automatic closure of connections in threads is deprecated. For exampleAaron Patterson2011-11-291-1/+7
| | | | | | | | | | | | | | | | | the following code is deprecated: Thread.new { Post.find(1) }.join It should be changed to close the database connection at the end of the thread: Thread.new { Post.find(1) Post.connection.close }.join Only people who spawn threads in their application code need to worry about this change.
* AbstractAdapter#close can be called to add the connection back to theAaron Patterson2011-11-292-11/+19
| | | | pool.
* Start implementing @reserved_connections in terms of connection leases.Aaron Patterson2011-11-291-3/+3
|
* Rename `checked_out` to more descriptive `active_connections`Aaron Patterson2011-11-291-3/+3
|
* Use connection lease to determine "checked_out" connectionsAaron Patterson2011-11-291-17/+21
|
* expire will set in_use to falseAaron Patterson2011-11-291-0/+5
|
* Leased connections return false on second leaseAaron Patterson2011-11-291-2/+4
|
* Adapters keep in_use flag when leasedAaron Patterson2011-11-291-1/+14
|
* Fix ruby 1.8 compat. const_defined? only takes a second arg on 1.9.Jon Leighton2011-11-291-3/+4
|
* Deprecated `define_attr_method` in `ActiveModel::AttributeMethods`Jon Leighton2011-11-291-2/+2
| | | | | This only existed to support methods like `set_table_name` in Active Record, which are themselves being deprecated.
* Deprecate set_locking_column in favour of self.locking_column=Jon Leighton2011-11-291-8/+13
|
* Deprecate set_primary_key in favour of self.primary_key=Jon Leighton2011-11-292-21/+27
|
* Make sure the original_foo accessor still works (but deprecated) if we are ↵Jon Leighton2011-11-291-6/+31
| | | | using self.foo=
* extract methodJon Leighton2011-11-291-49/+25
|
* Deprecate set_sequence_name in favour of self.sequence_name=Jon Leighton2011-11-291-11/+28
|
* Add tests for set_sequence_name etcJon Leighton2011-11-291-1/+1
|
* Deprecate set_inheritance_column in favour of self.inheritance_column=Jon Leighton2011-11-291-17/+29
|
* Deprecate set_table_name in favour of self.table_name= or defining your own ↵Jon Leighton2011-11-291-22/+59
| | | | method.
* respond_to? information of AR is not the responsibility of the specAaron Patterson2011-11-291-7/+9
| | | | resolver.
* Merge pull request #3636 from joshsusser/masterJon Leighton2011-11-298-21/+56
|\ | | | | association methods are now generated in modules
| * avoid warningsJosh Susser2011-11-276-15/+15
| | | | | | | | | | | | | | This change uses Module.redefine_method as defined in ActiveSupport. Making Module.define_method public would be as clean in the code, and would also emit warnings when redefining an association. That is pretty messy given current tests, so I'm leaving it for someone else to decide what approach is better.
| * changelog & docs for GeneratedFeatureMethodsJosh Susser2011-11-271-0/+20
| |
| * use GeneratedFeatureMethods module for associationsJosh Susser2011-11-274-13/+27
| |
| * association methods are now generated in modulesJosh Susser2011-11-158-30/+31
| | | | | | | | | | | | | | | | | | | | Instead of generating association methods directly in the model class, they are generated in an anonymous module which is then included in the model class. There is one such module for each association. The only subtlety is that the generated_attributes_methods module (from ActiveModel) must be forced to be included before association methods are created so that attribute methods will not shadow association methods.
* | remove unused instance variableAaron Patterson2011-11-281-1/+0
| |
* | just check in all connectionsAaron Patterson2011-11-281-6/+2
| |
* | remove useless class_evalAaron Patterson2011-11-281-2/+0
| |
* | Move connection resoluion logic to it's own testable class.Aaron Patterson2011-11-281-58/+74
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 16:52:47 +0000