Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | User id instead of quoted_id to prevent double quoting. Fixes failing test ↵ | Robert Pankowecki (Gavdi) | 2011-01-04 | 1 | -1/+1 |
| | | | | for bug #6036. | ||||
* | Rename AssociationReflection#primary_key_name to foreign_key, since the ↵ | Jon Leighton | 2010-12-31 | 15 | -51/+51 |
| | | | | options key which it relates to is :foreign_key | ||||
* | Support for :counter_cache on polymorphic belongs_to | Jon Leighton | 2010-12-31 | 1 | -1/+1 |
| | |||||
* | Refactor BelongsToAssociation to allow BelongsToPolymorphicAssociation to ↵ | Jon Leighton | 2010-12-31 | 5 | -114/+91 |
| | | | | inherit from it | ||||
* | Specify the STI type condition using SQL IN rather than a whole load of ORs. ↵ | Jon Leighton | 2010-12-31 | 3 | -6/+14 |
| | | | | Required a fix to ActiveRecord::Relation#merge for properly merging create_with_value. This also fixes a situation where the type condition was appearing twice in the resultant SQL query. | ||||
* | Get rid of extra_conditions param from configure_dependency_for_has_many. I ↵ | Jon Leighton | 2010-12-31 | 1 | -9/+3 |
| | | | | can't see a particularly plausible argument for this being used by plugins, and if they really want they can just redefine the callback or whatever. Note also that before my recent commit the extra_conditions param was completely ignored for :dependent => :destroy. | ||||
* | And owner_quoted_id can go too | Jon Leighton | 2010-12-31 | 3 | -22/+0 |
| | |||||
* | Now we can drop-kick AssociationReflection#dependent_conditions into oblivion. | Jon Leighton | 2010-12-31 | 1 | -11/+0 |
| | |||||
* | Refactor configure_dependency_for_has_many to use ↵ | Jon Leighton | 2010-12-31 | 1 | -38/+20 |
| | | | | AssociationCollection#delete_all. It was necessary to change test_before_destroy in lifecycle_test.rb so that it checks topic.replies.size *before* doing the destroy, as afterwards it will now (correctly) be 0. | ||||
* | Make sure Model#touch doesn't try to update non existing columns | Pratik Naik | 2010-12-30 | 1 | -1/+1 |
| | |||||
* | Make serialized fixtures work again | Pratik Naik | 2010-12-29 | 1 | -1/+2 |
| | |||||
* | Do not use primary key on insertion when it's nil | Santiago Pastorino | 2010-12-29 | 1 | -2/+2 |
| | |||||
* | Simplify inspect implementation | Santiago Pastorino | 2010-12-28 | 1 | -1/+1 |
| | | | | | After 304d38c0536dc32a8a1595ba34370ebf69a0d50d we don't need the new_record? check anymore. | ||||
* | Allow primary_key to be an attribute when the model is a new record | Santiago Pastorino | 2010-12-28 | 2 | -3/+3 |
| | |||||
* | I N C E P T I O N: flatten_deeper works around a bug in Ruby 1.8.2. | Aaron Patterson | 2010-12-27 | 3 | -15/+3 |
| | |||||
* | No need to symbolize these. | José Valim | 2010-12-27 | 1 | -2/+4 |
| | |||||
* | try not to make so many funcalls | Aaron Patterson | 2010-12-26 | 1 | -3/+6 |
| | |||||
* | make our hash of klasses and ids actually have classes for keys | Aaron Patterson | 2010-12-26 | 1 | -8/+6 |
| | |||||
* | Refactor we_can_set_the_inverse_on_this? to use a less bizarre name amongst ↵ | Jon Leighton | 2010-12-26 | 10 | -52/+41 |
| | | | | other things | ||||
* | Add a HasAssociation module for common code for has_* associations | Jon Leighton | 2010-12-26 | 8 | -61/+69 |
| | |||||
* | Remove AssociationProxy#dependent? - it's badly named and only used in one place | Jon Leighton | 2010-12-26 | 2 | -6/+1 |
| | |||||
* | Associations: DRY up the code which is generating conditions, and make it ↵ | Jon Leighton | 2010-12-26 | 6 | -64/+50 |
| | | | | all use arel rather than SQL strings | ||||
* | Remove custom_select param from construct_select, as it isn't used | Jon Leighton | 2010-12-26 | 1 | -3/+3 |
| | |||||
* | Remove construct_from from ThroughAssociationScope - it's not called from ↵ | Jon Leighton | 2010-12-26 | 1 | -4/+0 |
| | | | | anywhere | ||||
* | Set the create scope to an empty hash in ThroughAssociationScope. For ↵ | Jon Leighton | 2010-12-26 | 1 | -1/+5 |
| | | | | reasoning please see the inline code comments. | ||||
* | Use conditionals and implicit returns rather than explicit returns and ↵ | Jon Leighton | 2010-12-26 | 1 | -3/+7 |
| | | | | postfix ifs (it's easier to read) | ||||
* | Remove has_cached_counter? and cached_counter_attribute_name from ↵ | Jon Leighton | 2010-12-26 | 1 | -8/+0 |
| | | | | HasManyThroughAssociation, as the exact same methods are inherited from HasManyAssociation | ||||
* | Remove pointless use of 'private' | Jon Leighton | 2010-12-26 | 1 | -1/+0 |
| | |||||
* | Use the through association proxy for operations on the through record, so ↵ | Jon Leighton | 2010-12-26 | 3 | -17/+17 |
| | | | | that those operations are automatically scoped and therefore construct_join_attributes does not need to use construct_owner_attributes. | ||||
* | Remove target_obsolete? which is not called from anywhere | Jon Leighton | 2010-12-26 | 1 | -4/+0 |
| | |||||
* | scoped.where_values_hash is never nil | Jon Leighton | 2010-12-26 | 1 | -1/+1 |
| | |||||
* | refactor to use group_by | Aaron Patterson | 2010-12-25 | 1 | -3/+3 |
| | |||||
* | arel will deal with casting the ids, so we can delete this | Aaron Patterson | 2010-12-25 | 1 | -13/+1 |
| | |||||
* | use arel to determine selection column | Aaron Patterson | 2010-12-25 | 1 | -2/+1 |
| | |||||
* | refactoring method selection | Aaron Patterson | 2010-12-25 | 1 | -10/+5 |
| | |||||
* | using arel to compile sql statements | Aaron Patterson | 2010-12-25 | 2 | -9/+19 |
| | |||||
* | use sql literal factory method | Aaron Patterson | 2010-12-25 | 1 | -1/+1 |
| | |||||
* | take more advantage of arel sql compiler | Aaron Patterson | 2010-12-25 | 1 | -12/+20 |
| | |||||
* | refactoring AST building | Aaron Patterson | 2010-12-25 | 1 | -5/+3 |
| | |||||
* | use arel to compile SQL statements | Aaron Patterson | 2010-12-25 | 1 | -6/+15 |
| | |||||
* | stop redifining methods on every call to set_primary_key | Aaron Patterson | 2010-12-24 | 1 | -4/+11 |
| | |||||
* | use the sql literal factory method | Aaron Patterson | 2010-12-24 | 1 | -1/+1 |
| | |||||
* | stop the recursive insanity | Aaron Patterson | 2010-12-24 | 1 | -5/+10 |
| | |||||
* | setting the primary key on the update manager | Aaron Patterson | 2010-12-24 | 1 | -0/+1 |
| | |||||
* | Raise an error for associations which try to go :through a polymorphic ↵ | Jon Leighton | 2010-12-23 | 2 | -2/+12 |
| | | | | association [#6212 state:resolved] | ||||
* | If a has_many goes :through a belongs_to, and the foreign key of the ↵ | Jon Leighton | 2010-12-23 | 6 | -4/+36 |
| | | | | belongs_to changes, then the has_many should be considered stale. | ||||
* | Improved strategy for updating a belongs_to association when the foreign key ↵ | Jon Leighton | 2010-12-23 | 5 | -43/+32 |
| | | | | changes. Rather than resetting each affected association when the foreign key changes, we should lazily check for 'staleness' (where fk does not match target id) when the association is accessed. | ||||
* | Revert "Optimize <association>_ids for hm:t with belongs_to source". The ↵ | Jon Leighton | 2010-12-23 | 1 | -8/+1 |
| | | | | | | | | | | optimisation has too many edge cases, such as when the reflection, source reflection, or through reflection has conditions, orders, etc. [#6153 state:resolved] This reverts commit 373b053dc8b99dac1abc3879a17a2bf8c30302b5. Conflicts: activerecord/lib/active_record/associations.rb | ||||
* | When a has_many association is not :uniq, appending the same record multiple ↵ | Jon Leighton | 2010-12-23 | 2 | -3/+14 |
| | | | | times should append it to the @target multiple times [#5964 state:resolved] | ||||
* | Fix behaviour of foo.has_many_through_association.select('custom select') ↵ | Michał Łomnicki | 2010-12-23 | 1 | -2/+2 |
| | | | | [#6089 state:resolved] |