Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | belongs_to records should be initialized within the association scope | Jon Leighton | 2011-01-16 | 1 | -2/+8 | |
| | | ||||||
* | | Document the new create_association! method on one-to-one associations | Jon Leighton | 2011-01-16 | 1 | -1/+9 | |
| | | ||||||
* | | Add create_association! for belongs_to | Jon Leighton | 2011-01-16 | 2 | -3/+7 | |
| | | ||||||
* | | push !loaded? conditional up | Aaron Patterson | 2011-01-14 | 1 | -10/+8 | |
| | | ||||||
* | | return early in case the left or right side lists are empty | Aaron Patterson | 2011-01-14 | 1 | -5/+4 | |
| | | ||||||
* | | only find_target can raise the exception, so isolate the rescue around that call | Aaron Patterson | 2011-01-14 | 1 | -5/+9 | |
| | | ||||||
* | | we always have a target, so stop checking | Aaron Patterson | 2011-01-14 | 1 | -1/+1 | |
| | | ||||||
* | | we should use [] instead of Array.new | Aaron Patterson | 2011-01-14 | 1 | -1/+1 | |
| | | ||||||
* | | @target is always a list, so stop doing is_a? checks | Aaron Patterson | 2011-01-14 | 1 | -1/+1 | |
| | | ||||||
* | | move complex logic to it's own method | Aaron Patterson | 2011-01-14 | 1 | -15/+19 | |
| | | ||||||
* | | loaded? will not raise an AR::RecordNotFound exception, so move the rescue ↵ | Aaron Patterson | 2011-01-14 | 1 | -4/+4 | |
| | | | | | | | | inside the conditional | |||||
* | | reduce funcalls by using falsey objects | Aaron Patterson | 2011-01-14 | 1 | -2/+2 | |
| | | ||||||
* | | write the delegate method directly to avoid `delegate` callstack overhead | Aaron Patterson | 2011-01-14 | 1 | -1/+5 | |
| | | ||||||
* | | reduce some lasigns | Aaron Patterson | 2011-01-14 | 1 | -2/+1 | |
| | | ||||||
* | | Arel::Table.engine will be deprecated, so stop using it | Aaron Patterson | 2011-01-14 | 1 | -1/+1 | |
| | | ||||||
* | | include_in_memory? should check against @target list in case of new records. ↵ | Aaron Patterson | 2011-01-12 | 1 | -2/+2 | |
| | | | | | | | | [#6257 state:resolved] | |||||
* | | use array maths rather than *args | Aaron Patterson | 2011-01-12 | 1 | -2/+4 | |
| | | ||||||
* | | just use return value of load_target | Aaron Patterson | 2011-01-12 | 1 | -2/+1 | |
| | | ||||||
* | | just call methods on return value of `load_target` | Aaron Patterson | 2011-01-12 | 1 | -8/+3 | |
| | | ||||||
* | | default return value is nil | Aaron Patterson | 2011-01-12 | 1 | -1/+0 | |
| | | ||||||
* | | @loaded is defined in initialize, so we should not need this | Aaron Patterson | 2011-01-12 | 1 | -2/+0 | |
| | | ||||||
* | | just use respond_to? and super rather than aliasing around methods | Aaron Patterson | 2011-01-12 | 2 | -5/+4 | |
| | | ||||||
* | | adding a test for no method error | Aaron Patterson | 2011-01-11 | 1 | -11/+5 | |
| | | ||||||
* | | use underlying _read_attribute method rather than causing NoMethodErrors | Aaron Patterson | 2011-01-11 | 1 | -1/+1 | |
| | | ||||||
* | | kill unused variable warnings | Aaron Patterson | 2011-01-11 | 1 | -1/+1 | |
| | | ||||||
* | | lazily instantiate AR objects in order to avoid NoMethodErrors | Aaron Patterson | 2011-01-11 | 2 | -17/+24 | |
| | | ||||||
* | | test_with_polymorphic_and_condition works without the conditions methods in ↵ | Jon Leighton | 2011-01-11 | 1 | -5/+0 | |
| | | | | | | | | BelongsToPolymorphicAssociation because the conditions are added straight to the association_scope as of a few days ago | |||||
* | | Support for create_association! for has_one associations | Jon Leighton | 2011-01-11 | 2 | -1/+5 | |
| | | ||||||
* | | Refactor the code for singular association constructors. This will allow me ↵ | Jon Leighton | 2011-01-11 | 1 | -8/+13 | |
| | | | | | | | | to define a create_association! method in a minute. | |||||
* | | It's not necessary to pass the association proxy class around now | Jon Leighton | 2011-01-11 | 1 | -22/+15 | |
| | | ||||||
* | | Get rid of set_association_target and association_loaded? as the parts of ↵ | Jon Leighton | 2011-01-11 | 4 | -20/+17 | |
| | | | | | | | | the code that need that can now just use association_proxy(:name).loaded?/target= | |||||
* | | We can use the association_proxy method directly in HasOneThroughAssociation now | Jon Leighton | 2011-01-11 | 2 | -20/+20 | |
| | | ||||||
* | | DRY up the code which instantiates the association proxy | Jon Leighton | 2011-01-11 | 2 | -35/+49 | |
| | | ||||||
* | | find_target can be inherited | Jon Leighton | 2011-01-11 | 1 | -4/+0 | |
| | | ||||||
* | | Document the recent changes to association assignment | Jon Leighton | 2011-01-11 | 1 | -4/+9 | |
| | | ||||||
* | | Raise ActiveRecord::RecordNotSaved if an AssociationCollection fails to be ↵ | Jon Leighton | 2011-01-11 | 1 | -1/+5 | |
| | | | | | | | | replaced | |||||
* | | When assigning a has_one, if anything fails, the assignment should be rolled ↵ | Jon Leighton | 2011-01-11 | 1 | -19/+23 | |
| | | | | | | | | back entirely | |||||
* | | SQLite3 has supported savepoints since version 3.6.8, we should use this! | Jon Leighton | 2011-01-11 | 2 | -2/+18 | |
| | | ||||||
* | | When assigning a has_one, if the new record fails to save, raise an error | Jon Leighton | 2011-01-11 | 1 | -3/+3 | |
| | | ||||||
* | | When assigning a has_one, if the existing record fails to be removed from ↵ | Jon Leighton | 2011-01-11 | 1 | -5/+11 | |
| | | | | | | | | the association, raise an error | |||||
* | | has_one should always remove the old record (properly), even if not saving ↵ | Jon Leighton | 2011-01-11 | 1 | -1/+1 | |
| | | | | | | | | the new record, so we don't get the database into a pickle | |||||
* | | Return value is irrelevant here as the RHS of the assignment is always ↵ | Jon Leighton | 2011-01-11 | 1 | -1/+0 | |
| | | | | | | | | returned by methods ending in '=' | |||||
* | | Remove incorrect documentation about build_assoc on has_one. This is proven, ↵ | Jon Leighton | 2011-01-11 | 1 | -2/+1 | |
| | | | | | | | | for example, by test_successful_build_association in has_one_associations_test.rb | |||||
* | | For a singular association, it should be build_association, rather than ↵ | Jon Leighton | 2011-01-11 | 1 | -1/+1 | |
| | | | | | | | | association.build (as association may be nil) | |||||
* | | Correctly indent the bullet points under 'One-to-one associations', so that ↵ | Jon Leighton | 2011-01-11 | 1 | -10/+10 | |
| | | | | | | | | the lines are not broken in the generated rdoc html | |||||
* | | avoid splatting arrays by using concat | Aaron Patterson | 2011-01-11 | 1 | -3/+3 | |
| | | ||||||
* | | Fix polymorphic belongs_to associationproxy raising errors when loading target. | Ernie Miller | 2011-01-11 | 1 | -0/+5 | |
| | | ||||||
* | | only use one array when collecting split up queries | Aaron Patterson | 2011-01-10 | 1 | -1/+1 | |
| | | ||||||
* | | Always return decimal average of integer fields | Raimonds Simanovskis | 2011-01-10 | 1 | -9/+5 | |
| | | | | | | | | In previous version if database adapter (e.g. SQLite and Oracle) returned non-String calculated values then type_cast_using_column converted decimal average value of intefer field to integer value. Now operation parameter is always checked to decide which conversion of calculated value should be done. | |||||
* | | Adding postgresql template option when executing db:test:clone_structure | Katrina Owen | 2011-01-09 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | Specify the template to use in config/database.yml, e.g. test: adapter: postgresql template: template_postgis If no template is specified, postgresql defaults to template1 |