| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Update ActiveRecord::AttributeMethods#attribute_present? to return false for empty strings
|
|
|
|
| |
builder
|
|
|
|
| |
Change the default for newly generated applications to whitelist all attribute assignment. Also update the generated model classes so users are reminded of the importance of attr_accessible.
|
|
|
|
|
|
| |
would get ConnectionNotEstablished error because it always tried to use
ActiveRecord::Base's connection, even though it should be using the connection
of the model whose context we're operating in
|
|
|
|
|
|
| |
Conflicts:
activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 3dbedd2 added NOT NULL constraints both to table
creation and modification. For creation the new default
makes sense, but the generic situation for changing a
table is that there exist records. Those records have
no creation or modification timestamps, and in the
general case you don't even know them, so when updating
a table these constraints are not going to work. See
a bug report for this use case in #3334.
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* 3-2-2:
bumping to 3.2.2
Ensure [] respects the status of the buffer.
Merge pull request #4834 from sskirby/fix_usage_of_psql_in_db_test_prepare
Merge pull request #5084 from johndouthat/patch-1
updating RAILS_VERSION
delete vulnerable AS::SafeBuffer#[]
use AS::SafeBuffer#clone_empty for flushing the output_buffer
add AS::SafeBuffer#clone_empty
fix output safety issue with select options
|
| | |
|
| |
| |
| |
| | |
Fix usage of psql in db:test:prepare
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Options is needed for some Rails extensions to determine when
referential integrity should be disabled
This reverts commit bcb466c543451dce69403aaae047295758589d8e.
Fixes #5052
|
| |
| |
| |
| | |
itself instead of other_money.amount
|
|/
|
|
| |
Fix usage of psql in db:test:prepare
|
| |
|
| |
|
| |
|
|
|
|
| |
Restoring ability to derive id/sequence from tables with nonstandard sequences for primary keys
|
| |
|
|
|
|
| |
Always reenable _dump task in AR databases rake. Closes #5030
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Our schema.rb is being generated with an `add_index` line similar to this:
add_index "foo", ["foo", "bar"], :name => "xxx", :length => {"foo"=>8, "bar=>nil}
This is the same as it was on Rails 3.1.3, however, now when that
schema.rb is evaluated, its generating bad SQL in MySQL:
Mysql::Error: You have an error in your SQL syntax; check the manual
that corresponds to your MySQL server version for the right syntax
to use near '))' at line 1: CREATE UNIQUE INDEX
`xxx` ON `foo` (`foo`(8), `bar`())
This commit adds a check for nil on the length attribute to prevent the
empty parens from being output.
Conflicts:
activerecord/test/cases/migration/index_test.rb
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
|
|
| |
Conflicts:
activerecord/lib/active_record/core.rb
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
'uninitialized constant ActiveRecord::Deprecation in Rails3.2.1'
Just a typo of 'ActiveSupport::...'
|
|
|
|
| |
Fix for SQLite binary data corrupter (to master branch)
|
|
|
|
| |
Don't instantiate two objects in collection proxy / find_or_instantiate_by
|
| |
|
|
|
|
| |
ids_reader method fixed, test added to has_many association (for PostgreSQL)
|
| |
|
|
|
|
| |
#4757.
|
|
|
|
| |
[MySQL] Fix GH #4754. Remove double-quote characters around PK when using sql_mode=ANSI_QUOTES
|
|
|
|
| |
[closes #4750]
|
|
|
|
| |
Fix regression from Rails 3.1
|
| |
|
| |
|
|
|
|
| |
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
|
|
|
|
|
|
| |
From 2c667f69aa2daac5ee6c29ca9679616e2a71532a.
Thanks @pwnall for the heads-up.
Conflicts:
activerecord/lib/active_record/core.rb
|
| |
|
|
|
|
| |
Add ActiveRecord::Base#with_lock
|
|
|
|
|
| |
Didn't cherry pick the master commit because this one already had some
of the fixes made in master.
|
|
|
|
| |
Fix bug where reset_counters resets the wrong counter cache.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When subclassing abstract_class table_name should be always computed
based on class name, no matter if superclass is subclassing base
or another abstract_class. So:
class FirstAbstract < ActiveRecord::Base
self.abstract_class = true
end
class SecondAbstract < FirstAbstract
self.abstract_class = true
end
class Post < SecondAbstract
self.table_name #=> 'posts' (not 'second_abstracts')
end
|
| |
|
| |
|
| |
|
|
|
|
| |
#[] and #[]= are no longer interchangeable with #read_attribute and #write_attribute
|
| |
|