Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | For a singular association, it should be build_association, rather than ↵ | Jon Leighton | 2011-01-11 | 1 | -1/+1 |
| | | | | association.build (as association may be nil) | ||||
* | Correctly indent the bullet points under 'One-to-one associations', so that ↵ | Jon Leighton | 2011-01-11 | 1 | -10/+10 |
| | | | | the lines are not broken in the generated rdoc html | ||||
* | avoid splatting arrays by using concat | Aaron Patterson | 2011-01-11 | 1 | -3/+3 |
| | |||||
* | Fix polymorphic belongs_to associationproxy raising errors when loading target. | Ernie Miller | 2011-01-11 | 1 | -0/+5 |
| | |||||
* | only use one array when collecting split up queries | Aaron Patterson | 2011-01-10 | 1 | -1/+1 |
| | |||||
* | Always return decimal average of integer fields | Raimonds Simanovskis | 2011-01-10 | 1 | -9/+5 |
| | | | | In previous version if database adapter (e.g. SQLite and Oracle) returned non-String calculated values then type_cast_using_column converted decimal average value of intefer field to integer value. Now operation parameter is always checked to decide which conversion of calculated value should be done. | ||||
* | Adding postgresql template option when executing db:test:clone_structure | Katrina Owen | 2011-01-09 | 1 | -1/+1 |
| | | | | | | | | | | Specify the template to use in config/database.yml, e.g. test: adapter: postgresql template: template_postgis If no template is specified, postgresql defaults to template1 | ||||
* | remove unused string substitution | Aaron Patterson | 2011-01-08 | 1 | -6/+1 |
| | |||||
* | use select_all because not all database adapters support bind values | Aaron Patterson | 2011-01-08 | 1 | -1/+1 |
| | |||||
* | join the cult of cargo. reduce the number of NoMethodErrors in the system | Aaron Patterson | 2011-01-07 | 1 | -1/+1 |
| | |||||
* | stop creating intermediate AR objects, just construct AR objects from a list ↵ | Aaron Patterson | 2011-01-07 | 1 | -1/+2 |
| | | | | of hashes | ||||
* | no need for to_sym | Aaron Patterson | 2011-01-07 | 1 | -1/+1 |
| | |||||
* | String#insert() mutates the string, so no need for lasgn | Aaron Patterson | 2011-01-07 | 1 | -1/+1 |
| | |||||
* | fewer funcalls to the cached attributes variable | Aaron Patterson | 2011-01-07 | 1 | -1/+1 |
| | |||||
* | Refactor HasOneAssociation#replace | Jon Leighton | 2011-01-07 | 1 | -26/+22 |
| | |||||
* | Don't not remove double negatives | Jon Leighton | 2011-01-07 | 1 | -4/+4 |
| | |||||
* | Clean up create, create! and build in HasOneAssociation | Jon Leighton | 2011-01-07 | 1 | -14/+8 |
| | |||||
* | merge_with_conditions is not necessary because the conditions will already ↵ | Jon Leighton | 2011-01-07 | 1 | -9/+0 |
| | | | | be in the scope_for_create hash in the scope | ||||
* | Not really worth having the HasAssociation module for just a single method | Jon Leighton | 2011-01-07 | 5 | -21/+9 |
| | |||||
* | Construct an actual ActiveRecord::Relation object for the association scope, ↵ | Jon Leighton | 2011-01-07 | 8 | -113/+72 |
| | | | | rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things. | ||||
* | Use encode_with for marshalling | Jon Leighton | 2011-01-07 | 1 | -0/+20 |
| | |||||
* | send() will raise an ArgumentError, so we should leverage ruby | Aaron Patterson | 2011-01-07 | 1 | -16/+6 |
| | |||||
* | no need for parens | Aaron Patterson | 2011-01-07 | 1 | -1/+1 |
| | |||||
* | use a hash for caching aggregations rather than ivars | Aaron Patterson | 2011-01-07 | 2 | -14/+9 |
| | |||||
* | method is never called with arguments | Aaron Patterson | 2011-01-07 | 1 | -4/+2 |
| | |||||
* | only rescue from Mysql::Error exceptions [#6236 state:resolved] | Aaron Patterson | 2011-01-07 | 1 | -4/+9 |
| | |||||
* | just use a hash for doing association caching | Aaron Patterson | 2011-01-07 | 3 | -11/+14 |
| | |||||
* | no need for self | Aaron Patterson | 2011-01-06 | 1 | -1/+1 |
| | |||||
* | adding an `encode_with` method for Psych dump/load methods | Aaron Patterson | 2011-01-05 | 1 | -0/+16 |
| | |||||
* | AR internals expect a normal hash, otherwise there are serialization ↵ | Aaron Patterson | 2011-01-05 | 1 | -1/+1 |
| | | | | incompatibilities | ||||
* | no need to specify self | Aaron Patterson | 2011-01-05 | 1 | -1/+1 |
| | |||||
* | no need to send a symbol to send() | Aaron Patterson | 2011-01-05 | 1 | -1/+1 |
| | |||||
* | avoid creating so many Arel::Table objects | Aaron Patterson | 2011-01-05 | 1 | -6/+9 |
| | |||||
* | use attr_reader and alias methods to access instance variables | Aaron Patterson | 2011-01-05 | 1 | -8/+4 |
| | |||||
* | we have a method for this, so let's use it | Aaron Patterson | 2011-01-05 | 1 | -2/+2 |
| | |||||
* | use arel ast construction rather than generating strings | Aaron Patterson | 2011-01-05 | 1 | -1/+7 |
| | |||||
* | use arel to construct AST rather than generate strings | Aaron Patterson | 2011-01-05 | 1 | -2/+3 |
| | |||||
* | Merge remote branch 'rsim/require_deprecation' | Aaron Patterson | 2011-01-04 | 1 | -0/+2 |
|\ | | | | | | | | | * rsim/require_deprecation: require ActiveSupport deprecatation file before using deprecate method in database_statements | ||||
| * | require ActiveSupport deprecatation file before using deprecate method in ↵ | Raimonds Simanovskis | 2011-01-04 | 1 | -0/+2 |
| | | | | | | | | | | database_statements otherwise when using external ActiveRecord adapters (e.g. Oracle) database_statements might be loaded before active_support/core_ext/module/deprecation which results in NoMethodError (commit 60cf65def805995bcca184c40b44bb01d86a48aa added "deprecate" call to database_statements.rb) | ||||
* | | Merge remote branch 'rsim/habtm_select_fix' | Aaron Patterson | 2011-01-04 | 2 | -2/+3 |
|\ \ | | | | | | | | | | | | | * rsim/habtm_select_fix: Explicitly select * from has_and_belongs_to_many association tables, simplify exists? query | ||||
| * | | Explicitly select * from has_and_belongs_to_many association tables, ↵ | Raimonds Simanovskis | 2011-01-04 | 2 | -2/+3 |
| |/ | | | | | | | | | simplify exists? query Previous version (after commit 3103296a61709e808aa89c3d37cf22bcdbc5a675) was generating wrong SQL for Oracle when calling exists? method on HABTM association. | ||||
* | | Use Rails 3.1 `change` method in 'add_' migration generator | Prem Sichanugrist | 2011-01-04 | 1 | -0/+8 |
| | | |||||
* | | Use Rails 3.1 `change` method in model generator | Prem Sichanugrist | 2011-01-04 | 1 | -5/+1 |
|/ | |||||
* | Remove undocumented feature from has_one where you could pass false as the ↵ | Jon Leighton | 2011-01-03 | 2 | -28/+11 |
| | | | | | | | | | | | | second parameter to build_assoc or create_assoc, and the existing associated object would be untouched (the foreign key would not be nullified, and it would not be deleted). If you want behaviour similar to this you can do the following things: * Use :dependent => :nullify (or don't specify :dependent) if you want to prevent the existing associated object from being deleted * Use has_many if you actually want multiple associated objects * Explicitly set the foreign key if, for some reason, you really need to have multiple objects associated with the same has_one. E.g. previous = obj.assoc obj.create_assoc previous.update_attributes(:obj_id => obj.id) | ||||
* | ActiveRecord::Relation#primary_key should return a string, just like ↵ | Jon Leighton | 2011-01-03 | 6 | -28/+21 |
| | | | | ActiveRecord::Base.primary_key does. | ||||
* | Implement deprecated version of AssociationReflection#primary_key_name, ↵ | Jon Leighton | 2011-01-03 | 1 | -0/+6 |
| | | | | which has been renamed to #foreign_key. Also bumping the deprecation_horizon in Active Support to 3.1. | ||||
* | When preloading a belongs_to, the target should still be set (to nil) if ↵ | Jon Leighton | 2011-01-03 | 3 | -12/+16 |
| | | | | there is no foreign key present. And the loaded flag should be set on the association proxy. This then allows us to remove the foreign_key_present? check from BelongsToAssociation#find_target. Also added a test for the same thing on polymorphic associations. | ||||
* | Create the association scope directly rather than going through with_scope | Jon Leighton | 2011-01-03 | 7 | -31/+32 |
| | |||||
* | Make Relation#create_with always merge rather than overwrite, not just when ↵ | Jon Leighton | 2011-01-03 | 2 | -4/+2 |
| | | | | merging two relations. If you wish to overwrite, you can do relation.create_with(nil), or for a specific attribute, relation.create_with(:attr => nil). | ||||
* | Use the association directly in other places too | Jon Leighton | 2011-01-03 | 3 | -20/+13 |
| |