Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Revert "record who created the node when $DEBUG is true" | Ryuta Kamizono | 2018-09-28 | 1 | -10/+0 |
| | | | | This reverts commit a1b72178714fbf0033fe076b7e51f57eff152bdd. | ||||
* | Abandon TOP support. | Vladimir Kochnev | 2018-09-25 | 2 | -5/+2 |
| | | | | | | | | | | | | | | | | Initially, `TOP` was introduced to support `limit` for MSSQL database. Unlike PostgreSQL/MySQL/SQLite, MSSQL does not have native `LIMIT`/`OFFSET` support. The commit adding `TOP` is 1a246f71616cf246a75ef6cbdb56032e43d4e643. However, it figured out that `TOP` implementation was weak and it's not sufficient to also support `OFFSET`, then `TOP` was substituted with `ROW_NUMBER()` subquery in be48ed3071fd6524d0145c4ad3faeb4aafe3eda3. This is a well known trick in MSSQL - https://stackoverflow.com/questions/2135418/equivalent-of-limit-and-offset-for-sql-server. So now we don't need this `visit_Arel_Nodes_Top` at all. It does nothing useful but also adds an extra space after `SELECT` when `LIMIT` is being used for **any** database. | ||||
* | Revert a writer for `BindParam#value` | Ryuta Kamizono | 2018-09-09 | 1 | -1/+1 |
| | | | | | | The writer was added during Arel refactoring to pass Active Record tests at 7a29220. That is no longer used since 846832a. | ||||
* | Remove math module from count | Nikolai B | 2018-04-25 | 1 | -2/+0 |
| | | | | Not required after https://github.com/rails/arel/pull/449 | ||||
* | Arel: :nodoc: all | Matthew Draper | 2018-02-24 | 43 | -43/+43 |
| | |||||
* | Arel: rubocop -a | Matthew Draper | 2018-02-24 | 43 | -91/+125 |
| | |||||
* | Merge Arel into Active Record | Matthew Draper | 2018-02-24 | 43 | -0/+1198 |