Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | explain how `to_param` wil truncate long values. [ci skip] refs #12900. | Yves Senn | 2013-11-15 | 1 | -0/+3 |
| | |||||
* | added one test case and example for ActiveRecord::Base.to_param method | Kuldeep Aggarwal | 2013-11-15 | 1 | -0/+4 |
| | |||||
* | document id prefixed String usage of `.find`. refs #12891 [ci skip] | Yves Senn | 2013-11-15 | 1 | -5/+6 |
| | |||||
* | Fix test name [ci skip] | Carlos Antonio da Silva | 2013-11-14 | 1 | -2/+0 |
| | |||||
* | Fix that eager loading of polymorphic associations did not work with ↵ | David Heinemeier Hansson | 2013-11-14 | 1 | -1/+9 |
| | | | | association empty?/any? predicates any more (there is still a problem when select is applied to a relation, or if you try association#exists? -- but its easier to work around) | ||||
* | Merge pull request #12893 from javan/to-param-addendum | Rafael Mendonça França | 2013-11-14 | 1 | -6/+10 |
|\ | | | | | Addendum to #12891 | ||||
| * | Addendum to #12891 | Javan Makhmali | 2013-11-14 | 1 | -6/+10 |
| | | | | | | | | | | | | * Fix incorrectly named tests * Restore Object#to_param behavior * Ensure param is derived from a squished and truncated string | ||||
* | | Merge pull request #12819 from vipulnsward/also_dup_column_types | Rafael Mendonça França | 2013-11-14 | 1 | -3/+4 |
|\ \ | |/ |/| | Also dup `column_types` in AR::Result `initialize_copy` | ||||
| * | Also dup `column_types` in AR::Result `initialize_copy` | Vipul A M | 2013-11-10 | 1 | -3/+4 |
| | | |||||
* | | Add AR::Base.to_param for convenient "pretty" URLs derived from a model's ↵ | Javan Makhmali | 2013-11-14 | 1 | -0/+31 |
| | | | | | | | | attribute or method. | ||||
* | | Merge pull request #12832 from vipulnsward/move_schema_creation | Yves Senn | 2013-11-14 | 2 | -78/+84 |
|\ \ | | | | | | | Move `SchemaCreation` to its own file instead of `AbstractAdapter`. | ||||
| * | | Move `SchemaCreation` to its own file instead of `AbstractAdapter`. | Vipul A M | 2013-11-12 | 2 | -78/+84 |
| |/ | |||||
* | | Merge pull request #12845 from amatsuda/should_ar_depend_on_rails | Guillermo Iguaran | 2013-11-13 | 1 | -1/+5 |
|\ \ | | | | | | | Refer to Rails.env from AR only when Rails is defined | ||||
| * | | Refer to Rails.env only when Rails is defined | Akira Matsuda | 2013-11-11 | 1 | -1/+5 |
| | | | |||||
* | | | add #no_touching on ActiveRecord models | Damien Mathieu | 2013-11-13 | 2 | -0/+53 |
| | | | |||||
* | | | Remove the unused, undocumented SQLite3Adapter#supports_count_distinct? | Ben Woosley | 2013-11-12 | 1 | -5/+0 |
| | | | | | | | | | | | | This has returned true since 3cc9b5f1, and is not used internally. | ||||
* | | | Drop a sqlite_version check because we only support SQLite 3.6.16 or newer. | Ben Woosley | 2013-11-12 | 2 | -7/+1 |
| | | | | | | | | | Drop some comments that document the implementation rather than the interface. | ||||
* | | | Prevent the counter cache from being decremented twice | dm1try | 2013-11-11 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | when destroying a record on a has_many :through association. :destroy method has own counter_cache callbacks. | ||||
* | | | Unifies mysql and mysql2 casting of booleans. | Yves Senn | 2013-11-11 | 2 | -6/+6 |
| | | | |||||
* | | | Merge pull request #12834 from dredozubov/has_one_association_replacement | Yves Senn | 2013-11-11 | 1 | -2/+4 |
|\ \ \ | | | | | | | | | Fixes problem with replacing has_one association record with itself | ||||
| * | | | Fixes problem with replacing has_one association record with itself | Denis Redozubov | 2013-11-11 | 1 | -2/+4 |
| |/ / | |||||
* / / | autoload ChangeColumnDefinition (Fixes #12835) | Anton Kalyaev | 2013-11-11 | 1 | -0/+1 |
|/ / | |||||
* | | Change array check for better aesthetics / reading the code | Carlos Antonio da Silva | 2013-11-09 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #12821 from arunagw/aa-removed-missleading-message | Yves Senn | 2013-11-09 | 1 | -1/+1 |
|\ \ | | | | | | | clarified missleading message | ||||
| * | | Changed message for Model.inspect | Arun Agrawal | 2013-11-09 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | (No database connection) sounds not be able to connect database. see more #12804 | ||||
* | | | improve Active Record Store docs when using PG types. [ci skip]. | Yves Senn | 2013-11-09 | 1 | -3/+4 |
| | | | |||||
* | | | type casted PG bytea values are represented as a Hash. | Yves Senn | 2013-11-09 | 1 | -0/+2 |
| | | | | | | | | | | | | | | | This is a follow up to: 97f0d9a0dd12e7ad634815eecfeff866f64aad92 This change is also related to: df0edafac9eb47cd971970a9e7b13a3eaddf214e | ||||
* | | | Document the bind return | Rafael Mendonça França | 2013-11-09 | 1 | -0/+3 |
| | | | |||||
* | | | Avoid shot circuit return. | Rafael Mendonça França | 2013-11-09 | 1 | -8/+20 |
| | | | | | | | | | | | | This will make the conditional and to code clear | ||||
* | | | Don't use Active Support where we don't need to | Rafael Mendonça França | 2013-11-09 | 3 | -3/+3 |
| | | | |||||
* | | | Fix typo in AR store docs [ci skip] | Carlos Antonio da Silva | 2013-11-09 | 1 | -1/+1 |
|/ / | |||||
* / | log bind variables after they were type casted. | Yves Senn | 2013-11-09 | 3 | -10/+16 |
|/ | | | | | | | | | | | | | | | The log output used to be confusing in situation where type casting has "unexpected" effects. For example when finding records with a `String`. BEFORE: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", "im-no-integer"]] AFTER: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", 0]] | ||||
* | Merge pull request #12791 from jasonayre/ja/fix_autoload_error | Rafael Mendonça França | 2013-11-07 | 1 | -0/+1 |
|\ | | | | | add autoload :TransactionState to fix Marshal.load issues | ||||
| * | add autoload :TransactionState to fix Marshal.load issues | Jason Ayre | 2013-11-07 | 1 | -0/+1 |
| | | |||||
* | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2013-11-07 | 2 | -0/+7 |
|\ \ | |/ |/| | |||||
| * | refine usage docs of `store` in combination with `hstore` and `json`. | Yves Senn | 2013-11-06 | 1 | -3/+3 |
| | | | | | | | | refs #11561 #12700 | ||||
| * | Hstore and JSON fields are not supported with store | Robin Dupret | 2013-10-30 | 1 | -0/+4 |
| | | | | | | | | | | The use of `store` on Hstore fields (for instance) is not needed because serialization aimed to interact with Ruby objects and not with provided field types | ||||
| * | warning about saving models with dirty attributes | Damien Mathieu | 2013-10-23 | 1 | -0/+3 |
| | | | | | | | | See #8328 | ||||
* | | Stop using method missing for singleton delegation. | Aaron Patterson | 2013-11-06 | 1 | -0/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This saved about 46 array allocations per request on an extremely simple application. The delegation happened in the notification subsystem which is a hotspot, so this should result in even more savings with larger apps. Squashed commit of the following: commit 41eef0d1479526f7de25fd4391d98e61c126d9f5 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Wed Nov 6 16:32:31 2013 -0800 speed up notifications commit 586b4a18656f66fb2c518fb8e8fee66a016e8ae6 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Wed Nov 6 16:31:05 2013 -0800 speed up runtime registry methods commit b67d074cb4314df9a88438f785868cef77e583d7 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Wed Nov 6 16:28:12 2013 -0800 change method name and make it public | ||||
* | | bring back constant to expose the enum mapping as HWIA. | Yves Senn | 2013-11-06 | 1 | -4/+13 |
| | | |||||
* | | update the AR enum docs to match the actual behavior. [ci skip] | Yves Senn | 2013-11-06 | 1 | -5/+3 |
| | | |||||
* | | store enum mapping using `Strings` instead of `Symbols`. | Yves Senn | 2013-11-05 | 1 | -1/+2 |
| | | | | | | | | | | This allows to assign both `String` and `Symbol` values to the enum without having to call `to_sym`, which is a security problem. | ||||
* | | direct enum assignment rasies ArgumentError for unknown values. | Yves Senn | 2013-11-05 | 1 | -1/+6 |
| | | |||||
* | | define enum methods inside a `Module` to make them overwritable. | Yves Senn | 2013-11-05 | 1 | -13/+24 |
| | | |||||
* | | Merge pull request #12390 from kennyj/rename_to_association_methods | Rafael Mendonça França | 2013-11-05 | 4 | -7/+7 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | Renamed generated_feature_methods to generated_association_methods. Conflicts: activerecord/lib/active_record/associations/builder/association.rb activerecord/lib/active_record/associations/builder/singular_association.rb activerecord/test/cases/base_test.rb | ||||
| * | | Renamed generated_feature_methods to generated_association_methods. | kennyj | 2013-09-28 | 4 | -7/+7 |
| | | | |||||
* | | | ask the fixture set for the sql statements | Aaron Patterson | 2013-11-04 | 2 | -11/+17 |
| | | | |||||
* | | | The enum value constant isn't used, so rm it for now. | Aaron Patterson | 2013-11-04 | 1 | -17/+7 |
| | | | |||||
* | | | stop doing the same calculation over and over | Aaron Patterson | 2013-11-04 | 1 | -4/+5 |
| | | | |||||
* | | | Fix failures related to enum changes | Carlos Antonio da Silva | 2013-11-04 | 1 | -6/+4 |
| | | | | | | | | | | | | | | | | | | Commit 6e4a810f51b9ed2468b92247ef5568cc9d6dbcc0 changed the implementation from class_eval to define_method, but missed the access to the constant versus the access to the constant name. |