aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
Commit message (Collapse)AuthorAgeFilesLines
* Re-check that the connection is still stale before we reap itMatthew Draper2016-07-061-0/+2
| | | | | | | A concurrent thread may have also detected it to be stale, and already released (or even reassigned) it by now. Fixes #25585
* Check connection ownership before allowing a thread to release itMatthew Draper2016-07-061-1/+11
| | | | | A thread can only release a connection if it owns it, or it's owned by a thread that has died.
* Merge pull request #25241 from aguynamedben/fix-touch-error-messagesRichard Schneeman2016-07-032-2/+12
|\ | | | | Improve error message when record touch fails.
| * Improve error message when record touch fails.Ben Standefer2016-07-022-2/+12
| | | | | | | | | | | | The current error message only indicates that a touch can fail because the record is new. In practice, we saw cases where touches were failing because the record had been destroyed. `persisted?` checks `new_record?` *and* `destroyed?`. It was confusing to get a message about a new record when in reality we were destroying records. I also included a helpful tip for users to consider using `persisted?`, `new_record?`, or `destroyed?` before touching.
* | Clarify Postgres initials. [skip ci]William Johnston2016-07-021-2/+2
|/
* Merge pull request #25638 from kamipo/remove_unused_predicate_builderSean Griffin2016-07-023-19/+3
|\ | | | | Remove unused `predicate_builder` for `BasicObjectHandler` and `RangeHandler`
| * Remove unused `predicate_builder` for `BasicObjectHandler` and `RangeHandler`Ryuta Kamizono2016-07-023-19/+3
| |
* | Merge pull request #25507 from ↵Rafael França2016-07-022-14/+7
|\ \ | | | | | | | | | | | | bquorning/optimize-for-first-result-and-remove-mysql-select_one Remove #select_one from Mysql2Adapter
| * | Optimize ActiveRecord::Result#lastBenjamin Quorning2016-06-241-1/+2
| | | | | | | | | | | | | | | If you only want the last element of a result set, there's no need to create all of hash_rows. Also, add a test.
| * | Remove MySQL::DatabaseStatements#select_oneBenjamin Quorning2016-06-241-13/+0
| | | | | | | | | | | | | | | | | | | | | | | | The implementation from abstract/database_statements.rb seems to work just fine. And with ActiveRecord::Result now implementing an optimized #first method, the performance concerns previously addressed in https://github.com/rails/rails/commit/bf79aa4fc14aeb2646331e767038acf0b77e9e7f should not be an issue.
| * | Add ActiveRecord::Result#firstBenjamin Quorning2016-06-241-0/+5
| | | | | | | | | | | | | | | When you only need the first element of a result set, you shouldn't need to instantiate all of hash_rows.
* | | Merge pull request #25631 from yahonda/revert_rename_to_ar_internal_metadataRafael França2016-07-011-13/+0
|\ \ \ | | | | | | | | Revert "Rename `active_record_internal_metadatas` to `ar_internal_metadata"
| * | | Revert "Rename `active_record_internal_metadatas` to `ar_internal_metadata`"Yasuo Honda2016-07-011-13/+0
| | | | | | | | | | | | | | | | This reverts commit 407e0ab5e5cddf6a8b6b278b12f50772d13b4d86.
* | | | Merge pull request #25633 from kamipo/remove_create_table_info_cacheRafael França2016-07-011-6/+1
|\ \ \ \ | |_|_|/ |/| | | Remove `create_table_info_cache` because it not be reused
| * | | Remove `create_table_info_cache` because it not be reusedRyuta Kamizono2016-07-021-6/+1
| |/ / | | | | | | | | | | | | | | | `create_table_info_cache` is used for sharing `create_table_info` both `table_options` and `foreign_keys`. But `foreign_keys` no longer uses `create_table_info_cache` by #25307. No need caching anymore.
* | | Merge pull request #25620 from kamipo/create_without_primary_keyRafael França2016-07-011-1/+1
|\ \ \ | |/ / |/| | Pass `pk: false` to `connection.insert` explicitly if do not have a primary key
| * | Pass `pk: false` to `connection.insert` explicitly if do not have a primary keyRyuta Kamizono2016-07-011-1/+1
| | | | | | | | | | | | | | | | | | Because causing an extra query by `sql_for_insert` for guessing a primary key. https://github.com/rails/rails/blob/v5.0.0/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb#L121-L125
* | | Merge pull request #25307 from ↵Eileen M. Uchitelle2016-07-012-17/+17
|\ \ \ | |/ / |/| | | | | | | | kamipo/extract_foreign_key_action_from_information_schema Extract foreign key action from `information_schema`
| * | Extract foreign key action from `information_schema`Ryuta Kamizono2016-06-071-15/+15
| | | | | | | | | | | | Fixes #25300.
| * | Make `foreign_keys` queries to `SCHEMA`Ryuta Kamizono2016-06-072-2/+2
| | |
* | | Do not specal case inspecting associated arrays of over 10 elements, ↵Kevin McPhillips2016-06-291-7/+3
| | | | | | | | | | | | preventing infinite looping in some cases.
* | | Don't attempt to clear active connections unless we'ere connectedSean Griffin2016-06-291-1/+1
| | | | | | | | | | | | | | | | | | Right now with this middleware we are likely always connected, but I'm hoping to change that soon. This is an easy change to pull out on its own.
* | | Remove unused `ActiveRecord::Base.connection_id`Sean Griffin2016-06-293-16/+4
| | | | | | | | | | | | | | | | | | | | | | | | This method appears to have been partially used in connection pool caching, but it was introduced without much reasoning or any tests. One edge case test was added later on, but it was focused on implementation details. This method is no longer used outside of tests, and as such is removed.
* | | [ci skip] Clarify DDL term in ActiveRecord::TransactionsAlex Kitchens2016-06-271-4/+4
| | |
* | | Remove unnecessary `assert_valid_default`Ryuta Kamizono2016-06-251-7/+0
| | | | | | | | | | | | | | | This was added at c7c3f73 but it never raised because MySQL cannot create text/blob columns with a default value.
* | | nodoc `ActiveRecord::AttributeSet::YAMLEncoder`Jon Moss2016-06-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | As mentioned in 7b86ea6715ee987e61a7f3bd8e72b1bbfcfbbbe7, this is an internal class. [ci skip] r? @sgrif
* | | Revert "[ci skip] better docs for ↵Jon Moss2016-06-241-17/+0
| | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::AttributeSet::YAMLEncoder#decode" This reverts commit 7ea502ae141fc26b736c7a73bdf7a676b1f9fc87, per internal discussion with @sgrif -- this is documenting the implementation of a class that isn't intended to be public API.
* | | Merge pull request #25506 from y-yagi/return_correct_from_enum_typeSean Griffin2016-06-241-0/+2
|\ \ \ | |_|/ |/| | return correct type from `EnumType`
| * | return correct type from `EnumType`yuuji.yaginuma2016-06-241-0/+2
| | |
* | | [ci skip] Update Documentation on ActiveRecord::InheritanceAlex Kitchens2016-06-231-1/+2
|/ /
* | [ci skip] better docs for ActiveRecord::AttributeSet::YAMLEncoder#decodeDavid Elliott2016-06-211-0/+17
| |
* | [ci skip] fix typo in ActiveRecord::ConnectionHandlingAlex Kitchens2016-06-201-1/+1
| |
* | Merge pull request #23301 from ppworks/improve_mysqldumpArthur Nogueira Neves2016-06-171-0/+1
|\ \ | | | | | | Improve mysqldump
| * | Skip comments when exec mysqldumpNaoto Koshikawa2016-01-281-0/+1
| | |
* | | Merge pull request #24773 from ralinc/fix-silent-fail-on-psql-commandArthur Nogueira Neves2016-06-161-1/+2
|\ \ \ | | | | | | | | PostgreSQL: Fix db:structure:load silent failure on SQL error
| * | | PostgreSQL: Fix db:structure:load silent failure on SQL errorRalin Chimev2016-05-101-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The command line flag "-v ON_ERROR_STOP=1" should be used when invoking psql to make sure errors are not suppressed. Example: psql -v ON_ERROR_STOP=1 -q -f awesome-file.sql my-app-db Fixes #23818.
* | | | Merge pull request #25271 from kamipo/prevent_range_error_for_existsSean Griffin2016-06-152-6/+4
|\ \ \ \ | | | | | | | | | | Prevent `RangeError` for `FinderMethods#exists?`
| * | | | Prevent `RangeError` for `FinderMethods#exists?`Ryuta Kamizono2016-06-162-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `FinderMethods#exists?` should return a boolean rather than raising an exception. `UniquenessValidator#build_relation` catches a `RangeError` because it includes type casting due to a string value truncation. But a string value truncation was removed at #23523 then type casting in `build_relation` is no longer necessary. aa06231 removes type casting in `build_relation` then a `RangeError` moves to `relation.exists?`. This change will remove the catching a `RangeError`.
| * | | | Avoid type casting in uniqueness validatorRyuta Kamizono2016-06-041-5/+2
| | |_|/ | |/| | | | | | | | | | | | | | Type casting in uniqueness validator is for a string value truncation. It was removed at #23523.
* | | | Merge pull request #25339 from prathamesh-sonpatki/reuse-validate-index-lengthRafael França2016-06-151-7/+7
|\ \ \ \ | | | | | | | | | | Reuse validate index length
| * | | | Reuse existing validate_index_length! methodPrathamesh Sonpatki2016-06-091-7/+7
| |/ / / | | | | | | | | | | | | - Followup of https://github.com/rails/rails/commit/1ea6cc11211dc89e3e14b2b641a3cca8a0a91d55.
* | | | Respect the current `connected?` method when calling `cache`Arthur Neves2016-06-141-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Before we enable query caching we check if the connection is connected. Before this fix we were always checking against the main connection, and not the model connection.
* | | | Fix error message to talk about the scale not precision of the typeRafael Mendonça França2016-06-131-1/+1
| | | | | | | | | | | | | | | | Fixes #25391
* | | | Fix `calculate` with a string value in `from` and eager loadingRyuta Kamizono2016-06-131-9/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `construct_relation_for_association_calculations` pass a string value to `construct_join_dependency` when setting a string value in `from`. It should not pass a string value, but always `joins_values`. Related #14834, #19452. Fixes #24193.
* | | | Fix typoFrancesco Rodriguez2016-06-121-1/+1
| | | | | | | | | | | | [ci skip]
* | | | Fix `or` result SQL [ci skip]Ryuta Kamizono2016-06-111-1/+1
|/ / /
* | | Ensure that records with unselected fields can be updatedSean Griffin2016-06-021-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As part of refactoring mutation detection to be more performant, we introduced the concept of `original_value` to `Attribute`. This was not overridden in `Attribute::Uninitialized` however, so assigning ot an uninitialized value and calling `.changed?` would raise `NotImplementedError`. We are using a sentinel value rather than checking the result of `original_attribute.initialized?` in `changed?` because `original_value` might go through more than one node in the tree. Fixes #25228
* | | Fix failing testsSean Griffin2016-06-022-5/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently CI is broken due to 56a61e0 and c4cb686. This occurred because the failures are not present on SQLite which is what I normally run locally before pushing. The optimizations to our YAML size were dropping mutations, as `with_type` didn't set the previous value if it'd already been read (that method was never really designed to be used with values on individual objects, it was previously only used for defaults). I'm questioning whether there's a better place to be handling the exclusion of the type, but this will fix the failing build. Additionally, there was a bug in `remove_foreign_key` if you passed it an options hash containing `to_table`. This now occurs whenever removing a reference, as we always normalize to a hash. [Sean Griffin & Ryuta Kamizono]
* | | Make Active Record emit significantly smaller YAMLSean Griffin2016-05-317-7/+72
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reduces the size of a YAML encoded Active Record object by ~80% depending on the number of columns. There were a number of wasteful things that occurred when we encoded the objects before that have resulted in numerous wins - We were emitting the result of `attributes_before_type_cast` as a hack to work around some laziness issues - The name of an attribute was emitted multiple times, since the attribute objects were in a hash keyed by the name. We now store them in an array instead, and reconstruct the hash using the name - The types were included for every attribute. This would use backrefs if multiple objects were encoded, but really we don't need to include it at all unless it differs from the type at the class level. (The only time that will occur is if the field is the result of a custom select clause) - `original_attribute:` was included over and over and over again since the ivar is almost always `nil`. We've added a custom implementation of `encode_with` on the attribute objects to ensure we don't write the key when the field is `nil`. This isn't without a cost though. Since we're no longer including the types, an object can find itself in an invalid state if the type changes on the class after serialization. This is the same as 4.1 and earlier, but I think it's worth noting. I was worried that I'd introduce some new state bugs as a result of doing this, so I've added an additional test that asserts mutation not being lost as the result of YAML round tripping. Fixes #25145
* | | Respect options passed to `foreign_key` when reverting `add_reference`Sean Griffin2016-05-311-4/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The code incorrectly assumes that the option was written as `foreign_key: true`, but that is not always the case. This now mirrors the behavior of reverting `add_foreign_key`. The code was changed to use kwargs while I was touching it, as well. This could really use a refactoring to go through the same code paths as `add_refernce` in the future, so we don't duplicate default values. Fixes #25169
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-12 09:36:12 +0000