| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
The visibility of all internal protected methods was changed to private
since 5b14129.
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
We try to not try! internally.
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
Make ActiveRecord structure load/dump configurable
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Without this patch it's impossible to pass extra flags to
mysqldump/pg_dump when running `rake db:structure:dump` or `load`
The following config variables (`structure_load_flags` and `structure_dump_flags`)
make it better configurable.
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | |
| | | | | | |
| | | | | | | |
kamipo/should_not_update_children_when_parent_creation_with_no_reason
Should not update children when the parent creation with no reason
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This issue was introduced with d849f42 to solve #19782. However, we can
solve #19782 without causing the issue. It is enough to save only when
necessary.
Fixes #27338.
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Remove extracting `polymorphic_base_class` for `Array` in `AssociationQueryValue`
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`AssociationQueryValue`
It is handled by `PolymorphicArrayValue`.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Use `#execute` instead of `@connection.query`
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
`@connection.query` bypasses instrumenting "sql.active_record".
This behavior preventing us from debugging SQLs which Rails generates.
|
| |_|_|/ / / /
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Some methods were added to public API in
5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of
the public API.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Add a record to target before any callbacks loads the record
|
| | |_|/ / / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`append_record` was added at 15ddd51 for not double adding the record.
But adding `append_record` (checking `@target.include?(record)`) caused
performance regression #27434. Instead of checking not double adding the
record, add a record to target before any callbacks loads the record.
Fixes #27434.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Follow up to 5b14129d8d4ad302b4e11df6bd5c7891b75f393c.
http://edgeapi.rubyonrails.org/classes/ActiveRecord/Attribute.html
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
|/ / / / / / |
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Simplify the regex for `unsigned?` method
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
It is enough to distinguish only the trailing `unsigned` and
`unsigned zerofill`.
|
|\ \ \ \ \ \
| |_|_|_|_|/
|/| | | | | |
Throw friendly error message when fixture is not a hash
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Right now, when fixture is not a Hash we throw an error message
saying "fixture is not a hash". This is not very user friendly because
it's not saying which fixture is invalid.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
make sql statements frozen
dup if arel is not our string
expect runtime error
dont wrap runtime error in invalid
log errors will now be treated as runtime errors
update changelog
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Schema cache in YAML
|
| | | | | | |
|
| |/ / / /
|/| | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
kamipo/prevent_range_error_for_belongs_to_associations
Prevent `RangeError` for `belongs_to` associations
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Currently to access `belongs_to` associations raises a `RangeError` if
foreign key attribute has out of range value.
It should return a nil value rather than raising a `RangeError`.
Fixes #20140.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Translate numeric value out of range to the specific exception
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Raise `ActiveRecord::RangeError` when values that executed are out of range.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Race conditions can occur when an ActiveRecord is destroyed
twice or destroyed and updated. The callbacks should only be
triggered once, similar to a SQL database trigger.
|
| | | | | | | |
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Moved database-specific ActiveModel types into ActiveRecord
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
ie. DecimalWithoutScale, Text and UnsignedInteger
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
- If aliased, then use the aliased attribute name.
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
- If aliased, then use the aliased attribute name.
- Fixes #26417.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Should be sync the `primary_key` definition with actually created
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Actually the `primary_key` definition is not used but the inconsistency
is confusing. Actual definition is `bigint auto_increment PRIMARY KEY`
so `UNSIGNED` and `(8)` is unnecessary.
See also #21607.
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
While these method aren't public API, they are a non-trivial internal
API which warrant a bit of explanation.
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | | |
Fix association scope inside autosaved association callbacks
|
| | |_|_|_|_|_|/ /
| |/| | | | | | | |
|
| |_|_|/ / / / /
|/| | | | | | | |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
kamipo/translate_not_null_violation_to_specific_exception
Translate NOT NULL violation to the specific exception
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Raise `ActiveRecord::NotNullViolation` when a record cannot be inserted
or updated because it would violate a not null constraint.
|
|\ \ \ \ \ \ \ \ \
| |/ / / / / / / /
|/| | | | | | | | |
Should inherit `StatementInvalid` rather than `WrappedDatabaseException`
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Because defunct wrapper class is kept for compatibility.
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | | |
Fix `add_index` to normalize column names and options
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Currently does not work the following code.
```ruby
add_index(:people, ["last_name", "first_name"], order: { last_name: :desc, first_name: :asc })
```
Normalize column names and options to fix the issue.
|