Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | preserve decimal column attributes after migration | Greg Reinacker | 2011-10-21 | 1 | -0/+3 |
| | |||||
* | Merge pull request #3258 from ileitch/3-1-stable | Aaron Patterson | 2011-10-20 | 1 | -1/+7 |
| | | | | Postgres: Do not attempt to deallocate a statement if the connection is no longer active. | ||||
* | reset prepared statement when schema changes imapact statement results. ↵ | Aaron Patterson | 2011-10-18 | 1 | -11/+43 |
| | | | | fixes #3335 | ||||
* | Merge pull request #3340 from surfacedamage/exclude_destroy_in_all_blank_check | José Valim | 2011-10-17 | 1 | -2/+3 |
|\ | | | | | Exclude _destroy parameter in :all_blank check (issue #2937) | ||||
| * | Exclude _destroy parameter in :all_blank check (issue #2937) | Aaron Christy | 2011-10-17 | 1 | -2/+3 |
| | | |||||
* | | Default timestamps to non-null | Mike Perham | 2011-10-14 | 2 | -3/+3 |
|/ | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-10-14 | 1 | -2/+2 |
|\ | |||||
| * | change activerecord query conditions example to avoid 'type' as column name | Steve Bourne | 2011-10-12 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | 'Type' is a reserved column for STI. Changed conditions example to avoid using that column name as an example. The example isn't STI-related (and mentioning STI here is needless clutter), so changing to avoid accidentally encouraging users to use 'type' as a column name for other purposes. | ||||
* | | Consider attempted action in exception message of ActiveRecord::StaleObjectError | Christian Bäuerlein | 2011-10-14 | 2 | -6/+7 |
| | | |||||
* | | Includes stale record in StaleObjectError | Christian Bäuerlein | 2011-10-14 | 2 | -2/+11 |
| | | |||||
* | | Added ActiveRecord::Base.store for declaring simple single-column key/value ↵ | David Heinemeier Hansson | 2011-10-13 | 2 | -1/+50 |
|/ | | | | stores [DHH] | ||||
* | Only use LOWER for mysql case insensitive uniqueness check when column has a ↵ | Joseph Palermo | 2011-10-09 | 5 | -10/+33 |
| | | | | case sensitive collation. | ||||
* | Merge pull request #500 from cyril/patch-1 | Jeremy Kemper | 2011-10-08 | 1 | -2/+2 |
|\ | | | | | Use quotes for command substitution | ||||
| * | Use quotes for command substitution | Cyril Wack | 2011-05-10 | 1 | -2/+2 |
| | | |||||
* | | use thread locals and an instance variable within QueryCache#BodyProxy to ↵ | Mark J. Titorenko | 2011-10-07 | 3 | -3/+13 |
| | | | | | | | | maintain appropriate linkage with AR database connection across threads | ||||
* | | Merge pull request #3232 from Juanmcuello/pg_prepared_statements | Aaron Patterson | 2011-10-06 | 1 | -3/+4 |
|\ \ | | | | | | | Use the schema_search_path in prepared statements. | ||||
| * | | Use the schema_search_path in prepared statements. | Juan M. Cuello | 2011-10-05 | 1 | -3/+4 |
| | | | | | | | | | | | | | | | To allow the use of prepared statements when changing schemas in postgres, the schema search path is added to the sql key. | ||||
* | | | Merge pull request #3203 from jrmehle/fix_clone_structure | Vijay Dev | 2011-10-06 | 1 | -2/+2 |
|\ \ \ | | | | | | | | | db:test:clone_structure if path to .sql file contains spaces or dashes | ||||
| * | | | Quoted path to <Rails.env>_structure.sql file in db:test:clone_structure task. | Jared Mehle | 2011-10-03 | 1 | -2/+2 |
| | | | | | | | | | | | | Leaving the path unquoted causes errors in paths containing spaces or dashes. | ||||
* | | | | Transactional fixtures enlist all active database connections. | Jeremy Kemper | 2011-10-05 | 1 | -6/+18 |
| | | | | | | | | | | | | | | | | You can use multiple databases in your tests without disabling transactional fixtures. | ||||
* | | | | Raise an exception on unknown primary key inside AssociationReflection. | Jon Leighton | 2011-10-05 | 2 | -4/+21 |
| | | | | | | | | | | | | | | | | | | | | An association between two models cannot be made if a relevant key is unknown, so fail fast rather than generating invalid SQL. Fixes #3207. | ||||
* | | | | Revert "Raise error on unknown primary key." | Jon Leighton | 2011-10-05 | 9 | -36/+14 |
| |/ / |/| | | | | | | | | This reverts commit ee2be435b1e5c0e94a4ee93a1a310e0471a77d07. | ||||
* | | | Raise error on unknown primary key. | Jon Leighton | 2011-10-05 | 9 | -14/+36 |
| | | | | | | | | | | | | | | | If we don't have a primary key when we ask for it, it's better to fail fast. Fixes GH #2307. | ||||
* | | | Changing rake db:schema:dump to run :environment as well as :load_config, as ↵ | Ben Woosley | 2011-10-04 | 1 | -1/+1 |
|/ / | | | | | | | | | | | | | | | | | | | running :load_config alone will lead to the dumper being run without including extensions such as those included in foreigner and spatial_adapter. This reverses a change made here: https://github.com/rails/rails/commit/5df72a238e9fcb18daf6ab6e6dc9051c9106d7bb#L0L324 I'm assuming here that :load_config needs to be invoked separately from :environment, as it is elsewhere in the file for db operations, if not the alternative is to go back to "task :dump => :environment do". Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Don't call self.class unless necessary. Closes #3171. | Jon Leighton | 2011-09-29 | 1 | -2/+2 |
| | | |||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-09-28 | 1 | -1/+1 |
|\ \ | |||||
| * | | fixing docs for delete_sql where quotes should be used in this example. | Diego Plentz | 2011-09-26 | 1 | -1/+1 |
| | | | |||||
* | | | Don't require a DB connection when setting primary key. | Jon Leighton | 2011-09-26 | 2 | -1/+4 |
| | | | | | | | | | | | | Closes #2807. | ||||
* | | | Merge pull request #3030 from htanata/fix_habtm_select_query_method | Jon Leighton | 2011-09-26 | 1 | -4/+0 |
| | | | | | | | | | | | | Fix: habtm doesn't respect select query method | ||||
* | | | Fix belongs_to polymorphic with custom primary key on target. | Jon Leighton | 2011-09-26 | 3 | -17/+22 |
| | | | | | | | | | | | | Closes #3104. | ||||
* | | | CollectionProxy#replace should change the DB records rather than just ↵ | Jon Leighton | 2011-09-26 | 1 | -1/+1 |
|/ / | | | | | | | mutating the array. Fixes #3020. | ||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-09-21 | 1 | -0/+29 |
|\ \ | |||||
| * | | copy edits 908f2616 | Vijay Dev | 2011-09-20 | 1 | -4/+4 |
| | | | |||||
| * | | Document ActiveRecord::QueryMethods#select | Ryan Bigg | 2011-09-17 | 1 | -0/+29 |
| | | | |||||
* | | | to_xml should also rely on serializable hash. | José Valim | 2011-09-18 | 1 | -1/+1 |
|/ / | |||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-09-15 | 2 | -1/+37 |
|\ \ | |||||
| * | | minor edit | Vijay Dev | 2011-09-14 | 1 | -1/+1 |
| | | | |||||
| * | | Add documentation for the extending method in ActiveRecord:QueryMethods | Ryan Bigg | 2011-09-14 | 1 | -0/+36 |
| | | | |||||
| * | | [:class_name] option in belongs_to should mention belongs_to and not has_one | Erik Behrends | 2011-09-13 | 1 | -1/+1 |
| | | | |||||
* | | | Stop trying to be clever about when to define attribute methods. | Jon Leighton | 2011-09-14 | 1 | -10/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | There is no meaningful performance penalty in defining attribute methods, since it only happens once. There is also no reason *not* to define them, since they get thrown in an included module, so they will not 'overwrite' anything. In fact, this is desirable, since it allows us to call super. | ||||
* | | | We don't need to build a set for DangerousAttributeError. | Jon Leighton | 2011-09-14 | 1 | -7/+13 |
| | | | | | | | | | | | | We can just use method_defined? and private_method_defined? | ||||
* | | | Rename first_or_new to first_or_initialize. | Jon Leighton | 2011-09-13 | 2 | -3/+2 |
|/ / | | | | | | | | | For consistency with find_or_initialize_by. Also remove first_or_build alias. | ||||
* | | Deprecate using method_missing for attributes that are columns. | Jon Leighton | 2011-09-13 | 1 | -0/+15 |
| | | | | | | | | | | | | This shouldn't ever happen unless people are doing something particularly weird, but adding a deprecation in case there are bugs not caught by our tests. | ||||
* | | Let Ruby deal with method visibility. | Jon Leighton | 2011-09-13 | 1 | -7/+10 |
| | | | | | | | | | | | | Check respond_to_without_attributes? in method_missing. If there is any method that responds (even private), let super handle it and raise NoMethodError if necessary. | ||||
* | | Always generate attribute methods on the base class. | Jon Leighton | 2011-09-13 | 2 | -6/+19 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a situation I encountered where a subclass would cache the name of a generated attribute method in @_defined_class_methods. Then, when the superclass has it's attribute methods undefined, the subclass would always have to dispatch through method_missing, because the presence of the attribute in @_defined_class_methods would mean that it is never generated again, even if undefine_attribute_methods is called on the subclass. There various other confusing edge cases like this. STI classes share columns, so let's just keep all the attribute method generation state isolated to the base class. | ||||
* | | Raise error when using write_attribute with a non-existent attribute. | Jon Leighton | 2011-09-13 | 4 | -6/+15 |
| | | | | | | | | | | | | | | | | | | Previously we would just silently write the attribute. This can lead to subtle bugs (for example, see the change in AutosaveAssociation where a through association would wrongly gain an attribute. Also, ensuring that we never gain any new attributes after initialization will allow me to reduce our dependence on method_missing. | ||||
* | | Fix warnings. | Jon Leighton | 2011-09-13 | 1 | -1/+1 |
| | | | | | | | | Make sure we don't redefine an already-defined attribute method. | ||||
* | | Add deprecation for doing `attribute_method_suffix ''` | Jon Leighton | 2011-09-13 | 1 | -2/+0 |
| | | |||||
* | | Alias id= if necessary, rather than relying on method_missing | Jon Leighton | 2011-09-13 | 1 | -0/+4 |
| | | |||||
* | | Merge pull request #2936 from joelmoss/migration_status | Santiago Pastorino | 2011-09-11 | 1 | -5/+7 |
| | | | | | | | | db:migrate:status not looking at all migration paths |