aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
Commit message (Collapse)AuthorAgeFilesLines
* Timestamp values should be present on callbacksRafael Mendonça França2014-06-091-1/+1
| | | | | | | This reverts commit dd3ea17191e316aeebddaa7b176f6cfeee7a6365 and add a regression test. Fixes #15418
* Rename `type_cast` to `type_cast_from_database`Sean Griffin2014-06-0914-31/+34
| | | | | | | | In some cases there is a difference between the two, we should always be doing one or the other. For convenience, `type_cast` is still a private method on type, so new types that do not need different behavior don't need to implement two methods, but it has been moved to private so it cannot be used accidentally.
* Merge pull request #15586 from sgrif/sg-identity-typeRafael Mendonça França2014-06-091-1/+1
|\ | | | | Use an actual identity type in AR::Result#identity_type
| * Use an actual identity type in AR::Result#identity_typeSean Griffin2014-06-091-1/+1
| | | | | | | | | | We should be able to rely on this object implenting the full type interface.
* | Merge pull request #15591 from sgrif/sg-rm-write-attributeRafael Mendonça França2014-06-099-58/+52
|\ \ | | | | | | Make `_before_type_cast` actually be before type cast
| * | Make `_before_type_cast` actually be before type castSean Griffin2014-06-099-58/+52
| |/ | | | | | | | | | | | | | | | | | | | | | | | | - The following is now true for all types, all the time - `model.attribute_before_type_cast == given_value` - `model.attribute == model.save_and_reload.attribute` - `model.attribute == model.dup.attribute` - `model.attribute == YAML.load(YAML.dump(model)).attribute` - Removes the remaining types implementing `type_cast_for_write` - Simplifies the implementation of time zone aware attributes - Brings tz aware attributes closer to being implemented as an attribute decorator - Adds additional point of control for custom types
* | Do not try to set the foreign_key again on has_many throughRafael Mendonça França2014-06-091-1/+1
| | | | | | | | | | | | | | Integration tests are inside protected_attributes test suite. Fixes #15496 Fixes rails/protected_attributes#35
* | Remove a long gone :order option from has_one's valid_options.thedarkone2014-06-091-1/+1
|/
* Merge pull request #15558 from sgrif/sg-rename-propertyRafael Mendonça França2014-06-072-8/+8
|\ | | | | | | | | | | | | | | Rename `property` to `attribute` Conflicts: activerecord/lib/active_record/attribute_methods/serialization.rb activerecord/lib/active_record/base.rb
| * Rename `property` to `attribute`Sean Griffin2014-06-073-9/+9
| | | | | | | | For consistency with https://github.com/rails/rails/pull/15557
* | Merge pull request #15546 from sgrif/sg-lazy-decoratorsRafael Mendonça França2014-06-075-16/+60
|\ \ | | | | | | Don't query the database schema when calling `serialize`
| * | Don't query the database schema when calling `serialize`Sean Griffin2014-06-075-16/+60
| | | | | | | | | | | | | | | | | | We need to decorate the types lazily. This is extracted to a separate API, as there are other refactorings that will be able to make use of it, and to allow unit testing the finer points more granularly.
* | | Merge pull request #15561 from sgrif/sg-time-zone-aware-arraysRafael Mendonça França2014-06-071-1/+11
|\ \ \ | | | | | | | | Ensure time zones don't change after round trip with array columns
| * | | Ensure time zones don't change after round trip with array columnsSean Griffin2014-06-071-1/+11
| | | | | | | | | | | | | | | | | | | | The times would be equivalent, even if they were in different time zones. E.g. 12:00 UTC == 5:00 PDT
* | | | Merge pull request #15562 from sgrif/sg-double-type-cast-dirtyRafael Mendonça França2014-06-075-25/+27
|\ \ \ \ | | | | | | | | | | Do not type cast twice on attribute assignment
| * | | | Do not type cast twice on attribute assignmentSean Griffin2014-06-075-25/+27
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The definition of `write_attribute` in dirty checking ultimately leads to the columns calling `type_cast` on the value to perform the comparison. However, this is a potentially expensive computation that we cache when it occurs in `read_attribute`. The only case that we need the non-type-cast form is for numeric, so we pass that through as well (something I'm looking to remove in the future). This also reduces the number of places that manually access various stages in an attribute's type casting lifecycle, which will aid in one of the larger refactorings that I'm working on.
* | | | Merge pull request #15564 from sgrif/sg-remove-dead-codeRafael Mendonça França2014-06-071-7/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove dead branch when restoring ID within a transaction Conflicts: activerecord/lib/active_record/transactions.rb
| * | | | Remove dead branch when restoring ID within a transactionSean Griffin2014-06-071-7/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is no way to have an instance of an Active Record model where `has_attribute?(self.class.primary_key)` returns false. The record is always initialized in such a way that `@raw_attributes` will have an id key with nil for the value.
* | | | | Move conditionals about freezing closer to the definition of `freeze`Sean Griffin2014-06-072-4/+8
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | Reduces the number of places that care about the internals of how we store and type cast attributes. We do not need to go through the dup/freeze dance, as you couldn't have saved a frozen new record anyway, and that is the only time we would end up modifying the frozen hash.
* / / / Remove duplicated `@raw_attributes.keys`Sean Griffin2014-06-072-3/+3
|/ / / | | | | | | | | | | | | Reduces the number of things outside of attribute methods that cares about the details of how we store and type cast attributes
* | / changelog for #15556 and credit @kuldeepaggarwal [Kuldeep Aggarwal]Yves Senn2014-06-071-2/+0
| |/ |/| | | | | | | | | This is a follow up to #15556 @kuldeepaggarwal did submit this patch way back (#13624).
* | Merge pull request #15556 from sgrif/sg-time-zone-aware-arraysYves Senn2014-06-071-1/+13
|\ \ | | | | | | Add array support when time zone aware attributes are enabled
| * | Add array support when time zone aware attributes are enabledSean Griffin2014-06-071-1/+13
| | |
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-06-071-3/+4
|\ \ \
| * | | [ci skip] remove double "in your"schneems2014-06-041-1/+1
| | | |
| * | | [ci skip] less derogatory explanation of defaultsschneems2014-06-021-2/+3
| | | |
| * | | [ci skip] fix "note" syntaxschneems2014-06-021-1/+1
| | | |
* | | | Merge pull request #15542 from Gaurav2728/gaurav-remove_shutdown_linkArthur Nogueira Neves2014-06-061-4/+4
|\ \ \ \ | | | | | | | | | | remove rubyforge.org that was shut down [ci skip]
| * | | | remove rubyforge.org that was shut down [ci skip]Gaurav Sharma2014-06-061-4/+4
| | |_|/ | |/| |
* | | | Removed unused `klass` definitions from typesSean Griffin2014-06-066-21/+0
| |_|/ |/| | | | | | | | Only `Date` and `Time` are handled.
* | | Merge pull request #15552 from sgrif/sg-remove-klass-special-caseRafael Mendonça França2014-06-062-4/+7
|\ \ \ | | | | | | | | Remove composed_of special case from multi-parameter attributes
| * | | Remove composed_of special case from multi-parameter attributesSean Griffin2014-06-062-4/+7
| |/ / | | | | | | | | | | | | As we move towards removing the `klass` method from `column`, the else clause as it stands right now will become the only case.
* / / Don't mess with `_before_type_cast` for numeric typesSean Griffin2014-06-062-9/+9
|/ /
* | `ActiveRecord::SchemaMigration` has no primary key.Yves Senn2014-06-061-0/+3
| | | | | | | | | | | | | | | | | | | | Before this patch, using `ActiveRecord::Base.primary_key_prefix_type` with `:table_name_with_underscore` would change the `SchemaMigration` model to have a primary key. This resulted in broken queries for PG because it tried to return the inserted PK (which does not exist). Closes #15051. Closes #15419.
* | serialized Type should delegate `type_cast_for_write` to underlying TypeYves Senn2014-06-061-1/+1
| | | | | | | | | | | | | | This adds a regression test for #14411, which was fixed by #15503. Closes #14411 Closes #14595
* | Merge pull request #15503 from sgrif/sg-json-hstore-storageYves Senn2014-06-064-16/+7
|\ \ | | | | | | Bring type casting behavior of hstore/json in line with serialized
| * | Bring type casting behavior of hstore/json in line with serializedSean Griffin2014-06-044-16/+7
| | | | | | | | | | | | | | | `@raw_attributes` should not contain the type-cast, mutable version of the value.
* | | `bin/rake db:migrate:status` works with legacy migration numbers.Yves Senn2014-06-063-4/+9
| | | | | | | | | | | | | | | | | | | | | The migration numbers were normalized different ways. This left the task output in an inconsistent state. Closes #15538.
* | | Merge pull request #14971 from versioncontrol/#14785Yves Senn2014-06-061-1/+8
|\ \ \ | | | | | | | | | | | | Baseclass becomes! subclass
| * | | Fix Baseclass becomes! subclass.Edo Balvers2014-05-131-1/+8
| | | |
* | | | Remove optimization that was required with whiny nilsSean Griffin2014-06-051-8/+0
| | | | | | | | | | | | | | | | Whiny nils is no longer a thing, so we no longer need this optimization
* | | | Fix behavior of handling BC era dates.edogawaconan2014-06-052-3/+5
| | | | | | | | | | | | | | | | BC era year is (astronomical year + 1) and starts from 1 BC.
* | | | Remove deprecated method ActiveRecord::Migrator.proper_table_nameAkshay Vishnoi2014-06-051-13/+0
| | | |
* | | | have an actual `NullColumn` object and update docs accordingly.Yves Senn2014-06-043-5/+15
| | | | | | | | | | | | | | | | | | | | | | | | Follow up to #15438 and #15502. /cc @sgrif
* | | | Merge pull request #15502 from sgrif/sg-use-null-columnYves Senn2014-06-042-23/+23
|\ \ \ \ | | | | | | | | | | | | | | | Use null column for association key types
| * | | | Use null column for association key typesSean Griffin2014-06-042-23/+23
| | |/ / | |/| |
* | | | Merge pull request #15504 from sgrif/sg-postgres-defaultsRafael Mendonça França2014-06-041-48/+6
|\ \ \ \ | | | | | | | | | | Collapse PG default extractoin of most types to single regex
| * | | | Collapse PG default extractoin of most types to single regexSean Griffin2014-06-041-48/+6
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | For any type that is represented as a string and then type cast, we do not need separate regular expressions for the various types. No function will match this regex. User defined types *should* match this, so that the type object can decide what to do with the value.
* | | | Merge pull request #15463 from geopet/refactor_xml_compute_typeRafael Mendonça França2014-06-041-4/+4
|\ \ \ \ | |/ / / |/| | | Refactor XML serializer to not depend on `serialized_attributes`
| * | | Refactor XML serializer to not depend on `serialized_attributes`Geoff Petrie & Sean Griffin2014-06-011-3/+5
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-09 23:37:47 +0000