aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
Commit message (Collapse)AuthorAgeFilesLines
* Handle specified schemas when removing a Postgres indexGrey Baker2015-12-181-3/+16
|
* Merge pull request #22653 from matthewd/find_array_orderedMatthew Draper2015-12-181-0/+17
|\ | | | | | | ActiveRecord::Base#find(array) returning result in the same order as the array passed
| * Implement limit & offset for ourselvesMatthew Draper2015-12-181-6/+19
| | | | | | | | | | | | | | | | | | | | We know the query will return exactly one row for each entry in the `ids` array, so we can do all the limit/offset calculations on that array, in advance. I also split our new ordered-ids behaviour out of the existing `find_some` method: especially with this change, the conditionals were overwhelming the actual logic.
| * using order_values method instead of relying on ActiveRecord::Relation ↵Miguel Grazziotin2015-06-191-2/+2
| | | | | | | | @values hash
| * WIP: fixing the limit bug and introducing new tests (failing for now) on ↵Miguel Grazziotin2015-06-191-3/+5
| | | | | | | | .find(array) with offset
| * do not change the order of the result if the object was already ordered by ↵Miguel Grazziotin2015-06-051-0/+1
| | | | | | | | the user via :order clause
| * [#20338] improving implementation, fixing and adding some more specsMiguel Grazziotin2015-06-031-5/+2
| |
| * [#20338] WIP: first basic implementation and specsMiguel Grazziotin2015-05-291-1/+5
| |
* | Merge pull request #20815 from ↵Matthew Draper2015-12-181-2/+2
|\ \ | | | | | | | | | | | | | | | byroot/do-not-include-column-limit-if-it-is-default Do not include column limit in schema.rb if it matches the default
| * | Do not include column limit in schema.rb if it matches the defaultJean Boussier2015-07-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | When working on engines that supports multiple databases, it's very annoying to have a different schema.rb output based on which database you use. MySQL being the primary offender. This patch should reduce the disparities a bit.
* | | Merge pull request #22623 from greysteil/support-passing-schema-name-to-indexesMatthew Draper2015-12-181-9/+12
|\ \ \ | | | | | | | | | | | | Support passing the schema name prefix to `conenction.indexes`
| * | | Support passing the schema name prefix to `conenction.indexes`Grey Baker2015-12-171-9/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Support passing the schema name as a prefix to table name in `ConnectionAdapters::SchemaStatements#indexes`. Previously the prefix would be considered a full part of the index name, and only the schema in the current search path would be considered.
* | | | Merge pull request #19456 from greysteil/index-exists-behaviourMatthew Draper2015-12-182-15/+64
|\ \ \ \ | | | | | | | | | | | | | | | Ignore index name in `index_exists?` when not passed a name to check for
| * | | | Support removing custom-names indexes when only specifying column namesGrey Baker2015-12-152-13/+52
| | | | |
| * | | | Ignore index name in `index_exists?` when not passed a name to check forGrey Baker2015-12-152-2/+12
| | | | |
* | | | | Merge pull request #22642 from seuros/remove-mysql-adapterMatthew Draper2015-12-185-488/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Remove legacy mysql adapter
| * | | | | Remove legacy mysql adapterAbdelkader Boudih2015-12-175-488/+1
| | |/ / / | |/| | |
* | | | | Expanding the documentation for collection=objects for has_many :through ↵Eric Krause2015-12-171-1/+2
| | | | | | | | | | | | | | | | | | | | [ci-skip]
* | | | | Call the new point behavior `:point`, not `:rails_5_1_point`Sean Griffin2015-12-172-3/+2
|/ / / / | | | | | | | | | | | | | | | | Since the attributes API is new in Rails 5, we don't actually need to keep the behavior of `attribute :point`, as it's not a breaking change.
* | | | fix typo in method name [ci skip]yuuji.yaginuma2015-12-171-1/+1
| | | | | | | | | | | | | | | | It was changed by mistake at 428d47adfed8d6aa7b21aec2bf5ad890961c9de3
* | | | Revert "Merge pull request #22615 from ↵Rafael Mendonça França2015-12-173-5/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/join_to_delete_is_same_as_join_to_update" This reverts commit 4d06ea9a829de8f6f5a345589828e182eacab6a3, reversing changes made to e9d15072a94e2ae4dec5b7a121c84a5db38547b8. Reason: This will break oracle-enhanced, see https://github.com/rsim/oracle-enhanced/blob/3c42131db82b64ac41645db3affc6e4650289df6/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb#L1254
* | | | `join_to_delete` is same as `join_to_update`Ryuta Kamizono2015-12-173-11/+5
| | | |
* | | | Merge pull request #22598 from yui-knk/deprecate_string_callbackRafael França2015-12-161-15/+0
|\ \ \ \ | | | | | | | | | | Deprecate passing string to define callback.
| * | | | Deprecate passing string to define callback.yui-knk2015-12-161-15/+0
| | | | |
* | | | | Merge pull request #22562 from sblackstone/masterJeremy Daer2015-12-151-2/+2
|\ \ \ \ \ | |_|/ / / |/| | | | Allow users to pass flags from database.yml
| * | | | Allow users to pass flags from database.ymlStephen Blackstone2015-12-151-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix white-space Add test case demonstrating flags are received by the adapter
* | | | | Merge pull request #22596 from y-yagi/remove_extra_space_from_deprecation_msgEileen M. Uchitelle2015-12-152-2/+5
|\ \ \ \ \ | | | | | | | | | | | | remove extra spaces from deprecation message
| * | | | | remove extra spaces from deprecation messageyuuji.yaginuma2015-12-152-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` # before DEPRECATION WARNING: Time columns will become time zone aware in Rails 5.1. This still causes `String`s to be parsed as if they were in `Time.zone`, and `Time`s to be converted to `Time.zone`. To keep the old behavior, you must add the following to your initializer: config.active_record.time_zone_aware_types = [:datetime] To silence this deprecation warning, add the following: config.active_record.time_zone_aware_types << :time ``` ``` # after DEPRECATION WARNING: Time columns will become time zone aware in Rails 5.1. This still causes `String`s to be parsed as if they were in `Time.zone`, and `Time`s to be converted to `Time.zone`. To keep the old behavior, you must add the following to your initializer: config.active_record.time_zone_aware_types = [:datetime] To silence this deprecation warning, add the following: config.active_record.time_zone_aware_types << :time ```
* | | | | | Use a real migration version number in docsMatthew Draper2015-12-154-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Even though this means more things to change when we bump after a release, it's more important that our examples are directly copyable.
* | | | | | Schema uses current migration APIMatthew Draper2015-12-151-1/+1
| | | | | |
* | | | | | In 4.2 migrations, `timestamps` defaulted to `null: true`Matthew Draper2015-12-151-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | .. it also showed a deprecation warning, but we obviously needn't retain that.
* | | | | | Find the delegate, even in a deeper inheritance treeMatthew Draper2015-12-151-1/+5
| | | | | |
* | | | | | Use a deliberately-invalid migration version in all doc examplesMatthew Draper2015-12-154-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we use a real version, at best that'll be an onerous update required for each release; at worst, it will encourage users to write new migrations against an older version than they're using. The other option would be to leave these bare, without any version specifier. But as that's just a variant spelling of "4.2", it would seem to raise the same concerns as above.
* | | | | | Add migration versioning via Migration subclassesMatthew Draper2015-12-152-0/+56
|/ / / / /
* | | | | Revert "Perform a more efficient query in `Relation#any?`"Sean Griffin2015-12-142-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6d5b1fdf55611de2a1071c37544933bb588ae88e. `eager_load` and `references` can include hashes, which won't match up with `references` A test case has been added to demonstrate the problem
* | | | | Merge pull request #22395 from avokhmin/becomes-errors-base-2Sean Griffin2015-12-141-1/+1
|\ \ \ \ \ | | | | | | | | | | | | `ActiveRecord::Base#becomes` should copy the errors
| * | | | | `ActiveRecord::Base#becomes` should copy the errorsVokhmin Alexey V2015-12-141-1/+1
| | | | | |
* | | | | | Perform a more efficient query in `Relation#any?`Sean Griffin2015-12-142-8/+8
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was changed in 421c81b, as `exists?` blows up if you are eager loading a polymorphic association, as it'll try to construct a join to that table. The previous change decided to execute a `count` instead, which wouldn't join. Of course, the only time we actually need to perform a join on the eager loaded values (which would perform a left outer join) is if they're being referenced in the where clause. This doesn't affect inner joins.
* | | | | Use a bind param for `LIMIT` and `OFFSET`Sean Griffin2015-12-141-4/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We currently generate an unbounded number of prepared statements when `limit` or `offset` are called with a dynamic argument. This changes `LIMIT` and `OFFSET` to use bind params, eliminating the problem. `Type::Value#hash` needed to be implemented, as it turns out we busted the query cache if the type object used wasn't exactly the same object. This drops support for passing an `Arel::Nodes::SqlLiteral` to `limit`. Doing this relied on AR internals, and was never officially supported usage. Fixes #22250.
* | | | | Deprecate limit strings with commasSean Griffin2015-12-141-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some backends allow `LIMIT 1,2` as a shorthand for `LIMIT 1 OFFSET 2`. Supporting this in Active Record massively complicates using bind parameters for limit and offset, and it's trivially easy to build an invalid SQL query by also calling `offset` on the same `Relation`. This is a niche syntax that is only supported by a few adapters, and can be trivially worked around by calling offset explicitly.
* | | | | Merge pull request #22209 from ↵Sean Griffin2015-12-141-0/+9
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | yui-knk/add_test_sanitize_sql_array_handles_named_bind_variables Add test cases for `#sanitize_sql_array` with named_bind_variables
| * | | | Add test cases for `#sanitize_sql_array` with named_bind_variablesyui-knk2015-11-091-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | And add code examples to `sanitize_sql_for_conditions`, `sanitize_sql_for_assignment`, and `sanitize_sql_array`.
* | | | | Merge pull request #22381 from yahonda/use_adapter_subsecond_precision_supportedAaron Patterson2015-12-131-0/+4
|\ \ \ \ \ | |_|/ / / |/| | | | Use adapter supports_datetime_with_precision
| * | | | Support supports_datetime_with_precision? for sqlite3Yasuo Honda2015-11-301-0/+4
| | | | |
* | | | | Revert "Merge pull request #22502 from maclover7/remove-deprecation-notice"Arthur Neves2015-12-111-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c2e70ca9b042a3461aac0dc073a80e84bd77eb57, reversing changes made to b0e5fc2737ed0b2f67f9b9538d01e084545493fd. this broke the build
* | | | | Merge pull request #22502 from maclover7/remove-deprecation-noticeArthur Nogueira Neves2015-12-111-8/+0
|\ \ \ \ \ | | | | | | | | | | | | Remove unused deprecation notice
| * | | | | Remove unused deprecation noticeJon Moss2015-12-051-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `rake db:test:*` tasks were deprecated in #13528, but were undeprecated and added back in via #17739.
* | | | | | Merge pull request #22523 from Elektron1c97/masterRafael França2015-12-071-4/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | Typo correction
| * | | | | | Typo correctionYves Siegrist2015-12-071-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the doc the `dependent` option was set with: `dependent: destroy`. This is not working because destroy would call the method of the activerecord::base object. The right way is: `dependent: :destroy`
* | | | | | | Make sure we touch all the parents when touch_later.Arthur Neves2015-12-063-6/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The problem was that when saving an object, we would call touch_later on the parent which wont be saved immediteally, and it wont call any callbacks. That was working one level up because we were calling touch, during the touch_later commit phase. However that still didnt solve the problem when you have a 3+ levels of parents to be touched, as calling touch would affect the parent, but it would be too late to run callbacks on its grand-parent. The solution for this, is instead, call touch_later upwards when the first touch_later is called. So we make sure all the timestamps are updated without relying on callbacks. This also removed the hard dependency BelongsTo builder had with the TouchLater module. So we can still have the old behaviour if TouchLater module is not included. [fixes 5f5e6d924973003c105feb711cefdb726f312768] [related #19324]
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-10 22:14:20 +0000