| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| |
| |
| |
| | |
MySQL 8.0.1 and higher supports descending indexes: `DESC` in an index
definition is no longer ignored.
See https://dev.mysql.com/doc/refman/8.0/en/descending-indexes.html.
|
| |
| |
| |
| |
| |
| |
| | |
* Use keyword arguments in `IndexDefinition` to ease to ignore unused
options and to avoid to initialize incorrect empty value.
* Place it in `SchemaStatements` for consistency.
* And tiny tweaks.
|
|\ \
| | |
| | | |
Rename `association_query_handler.rb` to `association_query_value.rb`
|
| | |
| | |
| | |
| | |
| | |
| | | |
Since `AssociationQueryHandler` and `PolymorphicArrayHandler` has
removed in #28715, only exists `AssociationQueryValue` and
`PolymorphicArrayValue` in these files.
|
|/ /
| |
| |
| | |
Partitioning to `values` and `nils` is unneeded before early return.
|
| |
| |
| |
| |
| |
| | |
We already have a _read_attribute method that can get the value we need
from the model. Lets define that method in AM::Dirty and use the
existing one from AR::Dirty rather than introducing a new method.
|
|\ \
| | |
| | |
| | |
| | | |
bogdanvlviv/fix-dirty-attributes-if-override-attr_accessor
Fix inconsistency with changed attributes when overriding AR attribute reader
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
kamipo/convert_association_queries_to_poro_queries
Convert association queries to PORO queries
|
| | | |
| | | |
| | | |
| | | | |
association handling
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
|\ \ \ \
| | | | |
| | | | | |
Add comprehensive locking around DB transactions
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Transactional-fixture using tests with racing threads and inter-thread
synchronisation inside transaction blocks will now deadlock... but
without this, they would just crash.
In 5.0, the threads didn't share a connection at all, so it would've
worked... but with the main thread inside the fixture transaction, they
wouldn't've been able to see each other.
So: as far as I can tell, the set of operations this "breaks" never had
a compelling use case. Meanwhile, it provides an increased level of
coherency to the operational feel of transactional fixtures.
If this does cause anyone problems, they're probably best off disabling
transactional fixtures on the affected tests, and managing transactions
themselves.
|
|\ \ \ \
| | | | |
| | | | | |
Tweaks #28678
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Fix the comment on `formatted_version`
* Extract `define_params`
* Remove duplicated guard clause for `@version`
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | | |
Also, explicitly apply the order: generate_subscripts is unlikely to
start returning values out of order, but we should still be clear about
what we want.
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| / /
| |/ / |
Expose `queries` for `AssociationQueryValue` and `PolymorphicArrayValue`
|
| | | |
|
| | |
| | |
| | |
| | | |
It should be handled by `PolymorphicArrayHandler` if polymorphic association.
|
|\ \ \
| | | |
| | | | |
use formatted number as schema version
|
| | |/
| |/| |
|
| | |
| | |
| | |
| | | |
To ease to customize a relation for `exists?`.
|
|/ /
| |
| |
| | |
fixtures, not an empty array.
|
|\ \
| | |
| | | |
Clear active connections after initialization
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Any connections that were checked out during initialization should be
checked back in before the first request is processed, for two reasons:
- Returning the connection to the pool allows it to be health checked
before it's used again. If the connection dies before the first
request arrives, the health check will replace it with a new one.
- If the thread that initialized Rails is not the same thread that will
be performing work, checking in the connection will allow it to be
reused instead of being stuck to the initialization thread forever.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit a680a5814184e2f37c4686aa53d0ad3c7fb6b1ee, reversing
changes made to 842f67dd242e738419f27e752ea7dcd0bbe87b6d.
Reason: I can't resist to the joke, so better to keep it there
https://github.com/rails/rails/pull/28598#issuecomment-290945339.
|
| | | |
|
| | |
| | |
| | | |
`ActiveRecord::Base.establish_connection` accepts a single symbol argument to specify a named connection; a single string argument appears to be interpreted as a connection URI
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
htanata/ar_relation_inspect_should_not_load_all_records
Load only needed records on ActiveRecord::Relation#inspect
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | | |
Instead of loading all records and returning only a subset of those,
just load the records as needed.
Fixes #25537.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
silly method gets a silly doc fix,
or I'm missing an even sillier joke and I'm about to get schooled.
BUT I'm pretty sure this is some serious Beaudrillard simulacrum, though.
I'm just doing my part to spread the gospel of Douglas Adams.
|
|\ \ \
| | | |
| | | | |
Fix `primary_keys` across multiple schemas
|
| | | |
| | | |
| | | |
| | | | |
Fixes #28470.
|
|\ \ \ \
| |_|/ /
|/| | | |
Make internal methods to private
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Preprocess association query handling in predicate builder
|
| | | | |
| | | | |
| | | | |
| | | | | |
Because `RelationHandler` uses `value.arel`.
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently association query is handled as a postprocess. This has two
problems.
1. When `value` is a `Hash`, we need to skip the postprocess using
`next`.
2. `can_be_bound?` should return false if
`table.associated_with?(column_name)` is true (pass to the postprocess).
These are unneeded if preprocessing association query handling.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
mtsmfm/disable-referential-integrity-without-superuser-privilege-take-2
Use `SET CONSTRAINTS` for `disable_referential_integrity` without superuser privileges (take 2)
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
privileges (take 2)
Re-create https://github.com/rails/rails/pull/21233
eeac6151a5 was reverted (127509c071b4) because it breaks tests.
----------------
ref: 72c1557254
- We must use `authors` fixture with `author_addresses` because of its foreign key constraint.
- Tests require PostgreSQL >= 9.4.2 because it had a bug about `ALTER CONSTRAINTS` and fixed in 9.4.2.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add stronger assertions to rake migration tasks to make sure the user is providing a numeric VERSION
An empty string was getting converted to version = 0. This would in turn pass the presence check.
Address linting warning
Add test for rake task and refactor code to meet expectations
In particular passing VERSION=0 should not raise an error.
Addressed Comments for PR #28485. Trimmed empty lines + change of wording for error message
Adjust test for change of wording in error message
Change condition to follow rails idioms
|
| | |
| | |
| | |
| | |
| | |
| | | |
Because this comment is not document for `supports_ranges?`
ref: https://github.com/rails/rails/pull/27636#discussion_r107560081
|
| | |
| | |
| | |
| | |
| | | |
Since #28473 `uniq` is delegated to `records`, so `CollectionProxy#uniq`
is unnecessary.
|
|\ \ \
| | | |
| | | | |
Fix `LogSubscriber` to allow legacy `binds`
|
| | | |
| | | |
| | | |
| | | | |
Follow up of #27939.
|
|/ / /
| | |
| | |
| | |
| | | |
The old top level classes PGconn, PGresult and PGError were deprecated
since pg-0.13.0: https://github.com/ged/ruby-pg/blob/master/History.rdoc#v0130-2012-02-09-michael-granger-gedfaeriemudorg
|
| | | |
|