aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
Commit message (Collapse)AuthorAgeFilesLines
* Don't need to check if the scope respond to callRafael Mendonça França + Kassio Borges2013-08-311-5/+1
| | | | | We are checking this when defining the default scope and raising an ArgumentError
* Do not dup the binds when visiting the ASTRafael Mendonça França2013-08-312-3/+2
| | | | | | | The visitor have to consume the bind parameters to make the statements work when the prepared statement option is disabled. Fixes #12023
* Don't use Enumerable#next in pluck since it is very slowRyan Wallace2013-08-301-2/+1
|
* Merge pull request #12090 from njakobsen/merger-performanceAaron Patterson2013-08-301-3/+3
|\ | | | | [Performance] Don't create fibers while merging bind variables
| * Don't create fibers just to iterateNicholas Jakobsen2013-08-301-3/+3
| |
* | reduce relation allocationsAaron Patterson2013-08-301-1/+3
| |
* | no need to fully qualifyAaron Patterson2013-08-301-1/+1
| |
* | move the cache to the AR models and populate it on inheritedAaron Patterson2013-08-302-20/+31
| |
* | no need for the const_get since we lockAaron Patterson2013-08-301-5/+1
| |
* | require a class for cache computationsAaron Patterson2013-08-302-2/+4
| |
* | cache misses should return selfAaron Patterson2013-08-301-1/+1
|/
* FIX reload! within rails console --sandbox causes undefined method rollback ↵Val Kotlarov Hoffman2013-08-301-1/+3
| | | | upon exiting [https://github.com/rails/rails/issues/11834]
* pk should not be required for hm:t associationsAaron Patterson2013-08-291-1/+0
|
* correctly typecast keys, remove conditionals, reduce object allocationsAaron Patterson2013-08-282-7/+11
|
* no need to to_a the scopeAaron Patterson2013-08-281-1/+1
|
* remove extra flat_map arrayAaron Patterson2013-08-281-8/+9
|
* avoid extra empty array allocationAaron Patterson2013-08-281-10/+10
|
* extract owner id calculation to a methodAaron Patterson2013-08-281-1/+5
|
* only call to_a when we have toAaron Patterson2013-08-282-2/+6
|
* use consistent keys between cache get / setAaron Patterson2013-08-271-1/+1
|
* remove intermediate variableAaron Patterson2013-08-271-3/+1
|
* cache association reset calculationAaron Patterson2013-08-271-4/+4
|
* query the association rather than send the method for the association nameAaron Patterson2013-08-271-5/+6
|
* check class hierarchy with is_a? in PredicateBuilder.expandMikhail Dieterle2013-08-271-1/+1
| | | | add changelog entry for #11945
* Merge pull request #12038 from SamSaffron/memoize_decorate_colsRafael Mendonça França2013-08-261-17/+27
|\ | | | | Perf: memoize serialized column list and time zone column list
| * Perf: memoize serialized column list and time zone column listSam2013-08-271-17/+27
| |
* | Perf: avoid array allocation where not neededSam2013-08-271-1/+1
| |
* | Perf: fields in pg gem causes an allocation, cache itSam2013-08-271-2/+3
|/
* Add config to method calls in fixtures.wangjohn2013-08-261-23/+26
| | | | | | | Allows you to change your configuration for calls to `table_name_prefix`, `table_name_suffix`, and `pluralize_table_names`. The default configuration is still ActiveRecord::Base, but you are now able to change the configuration easily.
* Merge pull request #11827 from vipulnsward/remove_extra_caseSantiago Pastorino2013-08-261-1/+0
|\ | | | | Remove extra case.
| * Remove extra case.Vipul A M2013-08-101-1/+0
| |
* | PG adapter deals with negative money values formatted with parenthesis.Yves Senn2013-08-261-0/+5
| | | | | | | | Closes #11899.
* | Merge pull request #12014 from wangjohn/change_deprecation_horizonSantiago Pastorino2013-08-251-1/+1
|\ \ | | | | | | Changing deprecation_horizon to be Rails 4.2
| * | Changing deprecation_horizon to be Rails 4.2wangjohn2013-08-241-1/+1
| | | | | | | | | | | | | | | Also, +ActiveRecord::Migrator.proper_table_name+ should actually have a deprecation horizon of Rails 4.2 (not 4.1).
* | | Removing instances of string class_names in fixtures.wangjohn2013-08-241-3/+6
|/ / | | | | | | | | | | | | Also, constantizing the default_fixture_model_name when it gets loaded in from the file. Later, when the class_name is passed to a new FixtureSet, a deprecation warning will occur if the class_name is a string.
* | Merge pull request #12000 from ↵Santiago Pastorino2013-08-231-7/+1
|\ \ | | | | | | | | | | | | wangjohn/deprecating_class_name_string_in_fixtures Deprecating passing strings as class name in fixtures.
| * | Deprecating passing strings as class name in fixtures.wangjohn2013-08-231-7/+1
| | |
* | | Making proper_table_name take in options.wangjohn2013-08-221-18/+40
|/ / | | | | | | | | | | | | | | | | | | | | The options will specify the prefix and the suffix. Also, I'm moving the method to be an instance method on the +Migration+ instance. This makes more sense than being a class method on the +Migrator+ class because the only place that uses it is on a +Migration+ instance (in a method_missing hook). The logic for the Migrator shouldn't be doing any work to calculate the table name, it should be the Migration itself. Also made some small indentation fixes.
* | Merge pull request #11971 from freerunningtechnologies/dynamic_respond_toAaron Patterson2013-08-221-1/+1
|\ \ | | | | | | Performance regression in AR::Base.respond_to?
| * | Avoid compiling regexs in AR::Base.respond_to?John Hawthorn2013-08-211-1/+1
| | | | | | | | | | | | | | | Caches the patterns of ActiveRecord::DynamicMatchers in a class instance variable.
* | | Merge pull request #11976 from etehtsea/infYves Senn2013-08-221-2/+2
|\ \ \ | | | | | | | | [PG adapter] Use infinity const
| * | | Use infinity constKonstantin Shabanov2013-08-221-2/+2
| |/ /
* / / Stray nodoc causes rest of file not parsed [ci skip]edogawaconan2013-08-221-2/+0
|/ /
* | Merge pull request #11922 from Empact/string-confusionYves Senn2013-08-201-1/+1
|\ \ | | | | | | Stop interpreting SQL 'string' columns as :string type.
| * | Stop interpreting SQL 'string' columns as :string type.Ben Woosley2013-08-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | SQL doesn't have a string type, and interpreting 'string' as text is contrary to at least SQLite3's behavior: "Note that a declared type of 'STRING' has an affinity of NUMERIC, not TEXT." http://www.sqlite.org/datatype3.html
* | | let AR::FinderMethods#exists? return singletons in all cases [closes #11592]Xavier Noria2013-08-191-7/+7
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a regression. The documentation said in its introduction paragraph that the method returns truthy/falsy, but then below it was said that if there were no arguments you'd get `true` or `false`. Also when the argument is exactly `false` a singleton is documented to be returned. The method was not returning the singletons so it didn't conform to those special cases. The best solution here seems to be to just return singletons in all cases. This solution is backwards compatible. Also, the contract has been revised because it has no sense that the predicate varies that way depending on the input. I bet the previous contract was just an accident, not something mixed on purpose. Conflicts: activerecord/lib/active_record/relation/finder_methods.rb activerecord/test/cases/finder_test.rb
* | Fixing multi-word automatic inverse detection.wangjohn2013-08-151-2/+2
| | | | | | | | | | Currently, ActiveRecord models with multiple words cannot have their inverse associations detected automatically.
* | Rescue invalid ip address exceptions on assign.Paul Nikitochkin2013-08-141-1/+5
| | | | | | | | In order that set attribute should not be bang method
* | Merge pull request #11838 from vipulnsward/drop_extra_varSteve Klabnik2013-08-121-2/+2
|\ \ | | | | | | drop extra variable
| * | drop extra variableVipul A M2013-08-121-2/+2
| |/
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 02:06:45 +0000