aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
Commit message (Collapse)AuthorAgeFilesLines
* Ensure association proxy responds to private class methods defined in ↵Pratik Naik2008-10-161-2/+2
| | | | associated class. [#1083]
* Merge docrailsPratik Naik2008-10-162-3/+5
|
* Allow class methods to be sent (via #send) to association proxy (fix for bug ↵Ian White2008-10-161-0/+4
| | | | | | introduced by 691aa20) [#1083] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Ensure methods called on association proxies respect access control. [#1083 ↵Pratik Naik2008-10-132-1/+12
| | | | state:resolved] [Adam Milligan, Pratik]
* Remove the functionality introduce in 28d3390Michael Koziarski2008-10-101-12/+1
| | | | There are several situations it doesn't cater for, and the inconsistency isn't worth blocking 2.2.
* explicitly including child associations that are also included in the parent ↵Will Bryant2008-10-102-0/+8
| | | | | | | association definition should not result in double records in the collection/double loads (#1110) Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1110 state:committed]
* Add documentation for AbstractAdapter#sanitize_limit, and make its code more ↵Hongli Lai (Phusion)2008-10-091-4/+15
| | | | | | | readable. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1068 status:committed]
* Merge docrailsPratik Naik2008-10-0510-79/+469
|
* Ensure Model.sum and Model.avg typecast appropriately. [#1066 state:resolved]Pratik Naik2008-10-041-3/+7
| | | | | Model.sum delegates typecasting to the column being summed. If that's not feasible, returns a string. Model.avg always returns big decimal.
* Remove HasManyAssociationStrategy and move the logic to ↵Pratik Naik2008-10-042-27/+21
| | | | ActiveRecord::Reflection::ThroughReflection.
* Introduce ActiveRecord::Reflection::ThroughReflection to simplify hm:t ↵Pratik Naik2008-10-041-53/+66
| | | | reflection logic
* Fix has_many :through when the source is a belongs_to association. [#323 ↵Zach Dennis2008-10-042-10/+45
| | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Try reloading model on class mismatch [#229 state:resolved]Lawrence Pit2008-10-041-1/+1
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix performance bug in AttibuteMethods#respond_to? in handling of private ↵Aliaksey Kandratsenka2008-10-041-1/+3
| | | | | | | | | | | methods We have hit dramatic increase in tests time after upgrading rails. Profiling revealed this particular place. After this fix our test times returned back to norm. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1173 state:committed]
* made ConnectionPool#checkout more robust by trying to loot dead threads when ↵Aliaksey Kandratsenka2008-10-041-1/+5
| | | | | | | | pool is empty Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1169 state:committed]
* Fix race in ConnectionPool#checkoutAliaksey Kandratsenka2008-10-041-15/+14
| | | | | | | After releasing monitor some connection(s) may appear in pool before monitor is re-aquired. When this happens we'll wait for connection which is already available. Signed-off-by: Michael Koziarski <michael@koziarski.com>
* don't quote decimal values for mysql. It doesn't make sense and breaks in ↵Aliaksey Kandratsenka2008-10-041-1/+1
| | | | | | | newer versions of mysql Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1168 state:committed]
* Make sure recreate MySQL test database with the proper encoding and ↵Luca Guidi2008-10-031-2/+2
| | | | | | | collation [#1165 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1165 state:committed]
* Remove AS for oracle compatibilityMichael Koziarski2008-10-031-1/+1
|
* Dynamic finders should use the ActiveRecord::Base::find method instead of ↵Eloy Duran2008-10-032-8/+8
| | | | | | | | | | | | ::find_initial, :find_last, and ::find_all. This is so when people override ActiveRecord::Base::find, the new ::find method will also be invoked by the dynamic finders. Associations for instance do go through ::find, so this makes it more consistent. Also removed the unnecessary deprecation silence blocks. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1162 state:committed]
* fix eager loading's :condition sanitizing expanding against the wrong tableWill Bryant2008-09-291-5/+5
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Ignore all exceptions for validates_acceptance_of columns fetch so it can ↵Tarmo Tänav2008-09-261-1/+1
| | | | | | run even without a database connection Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Changed ActiveRecord attributes to respect access control.Adam Milligan2008-09-241-1/+7
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1084 state:committed]
* Refactor configure_dependency_for_has_many to use a few more methods.Hongli Lai (Phusion)2008-09-241-3/+34
| | | | | | | Add an additional conditions option to make it slightly easier for certain plugins. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1087 state:committed]
* Allowed passing arrays-of-strings to :join everywhere. Merge duplicate join ↵Pivotal Labs2008-09-241-13/+21
| | | | | | | strings to avoid table aliasing problems. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1077 state:committed]
* Make AssociationCollection start transactions in the correct database.Hongli Lai (Phusion)2008-09-232-6/+21
| | | | | | | | | | AssociationCollection now starts transactions by calling AssociationCollection#transaction instead of @owner.transaction or @reflection.klass.transaction. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1081 state:committed]
* Merge branch 'patches' into multibyteMichael Koziarski2008-09-224-6/+17
|\
| * Bump the Version constants to align with the *next* release rather than the ↵Michael Koziarski2008-09-221-1/+1
| | | | | | | | | | | | previous release. This allows people tracking non-release gems or git submodules to use the constants.
| * Association#first and last should not load the association if not needed. ↵Jan De Poorter2008-09-221-3/+4
| | | | | | | | | | | | [#1091 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
| * Add Model#delete instance method, similar to Model.delete class method. ↵Hongli Lai (Phusion2008-09-212-2/+12
| | | | | | | | | | | | [#1086 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* | Change all calls to String#chars to String#mb_chars.Manfred Stienstra2008-09-211-1/+1
|/
* applied patch to fix the associations with blocks in modules bug from an old ↵Adeh DeSandies2008-09-201-4/+4
| | | | trac ticket
* I18n: move old-style interpolation syntax deprecation to Active Record. ↵Sven Fuchs2008-09-201-0/+26
| | | | | | [#1044 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fixed an error triggered by a reload followed by a foreign key assignment.Nathaniel Talbott2008-09-201-1/+5
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Update the documentation to reflect the change handling :group earlierMichael Koziarski2008-09-161-1/+4
|
* When counting grouped records the target should be loaded to return a valid ↵miloops2008-09-151-0/+2
| | | | | | | | | groups count result. Without this change count_records will group for the count in the query and return erroneous results. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#937 state:committed]
* Deal with MySQL's quirky handling of defaults and blob/text columnsFrederick Cheung2008-09-143-2/+11
| | | | | | [#1043 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Multiparameter attributes skip time zone conversion for time-only columns ↵gbuesing2008-09-141-1/+1
| | | | [#1030 state:resolved]
* Base.skip_time_zone_conversion_for_attributes uses ↵miloops2008-09-141-1/+1
| | | | class_inheritable_accessor, so that subclasses don't overwrite Base [#346 state:resolved]
* Merge docrailsPratik Naik2008-09-133-48/+116
|
* Allow for the dirty tracking to work with the aliased name of aliased ↵Rich Cavanaugh2008-09-131-1/+19
| | | | | | | attributes. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#812 state:committed]
* Support for updating a belongs to association from the foreign key (without ↵Jon Leighton2008-09-131-1/+8
| | | | | | | saving and reloading the record) Signed-off-by: Michael Koziarski <michael@koziarski.com> [#142 state:committed]
* Remove the .to_s fix in validates_uniqueness_of, as Chars get quoted correctly.Michael Koziarski2008-09-111-1/+1
|
* Fix ActiveRecord::Base.quote_bound_value for ActiveSupper::Multibyte::Chars ↵Manfred Stienstra2008-09-111-1/+1
| | | | | | | | | | values. - Adds String#acts_like_string? - Adds Chars#acts_like_string? Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1029 state:committed]
* Fixes validates_uniquness_of problem with case insensitive string containing ↵wmoxam2008-09-111-1/+1
| | | | | | newline characters Signed-off-by: Michael Koziarski <michael@koziarski.com>
* fixed association preloading to use = instead of IN when there's only one recordrsl2008-09-101-5/+8
| | | | | | [#1013 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Revert "Add :accessible option to Associations for allowing mass assignments ↵Pratik Naik2008-09-102-24/+4
| | | | | | | | | | | | using hash. [#474 state:resolved]" This reverts commit e0750d6a5c7f621e4ca12205137c0b135cab444a. Conflicts: activerecord/CHANGELOG activerecord/lib/active_record/associations.rb activerecord/lib/active_record/associations/association_collection.rb
* Expanded documentation for new composed_of optionsRob Anderton2008-09-101-10/+53
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#892 state:committed]
* Added :constructor and :converter options to composed_of and deprecated the ↵Rob Anderton2008-09-101-31/+60
| | | | | | conversion block Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Support :limit on update_all so that has_many with :limit can be safely updatedTarmo Tänav2008-09-103-3/+25
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>