| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| |
| |
| |
| | |
Rename `property` to `attribute`
Conflicts:
activerecord/lib/active_record/attribute_methods/serialization.rb
activerecord/lib/active_record/base.rb
|
| |
| |
| |
| | |
For consistency with https://github.com/rails/rails/pull/15557
|
|\ \
| | |
| | | |
Don't query the database schema when calling `serialize`
|
| | |
| | |
| | |
| | |
| | |
| | | |
We need to decorate the types lazily. This is extracted to a separate
API, as there are other refactorings that will be able to make use of
it, and to allow unit testing the finer points more granularly.
|
|\ \ \
| | | |
| | | | |
Ensure time zones don't change after round trip with array columns
|
| | | |
| | | |
| | | |
| | | |
| | | | |
The times would be equivalent, even if they were in different time
zones. E.g. 12:00 UTC == 5:00 PDT
|
|\ \ \ \
| | | | |
| | | | | |
Do not type cast twice on attribute assignment
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The definition of `write_attribute` in dirty checking ultimately leads
to the columns calling `type_cast` on the value to perform the
comparison. However, this is a potentially expensive computation that we
cache when it occurs in `read_attribute`. The only case that we need the
non-type-cast form is for numeric, so we pass that through as well
(something I'm looking to remove in the future).
This also reduces the number of places that manually access various
stages in an attribute's type casting lifecycle, which will aid in one
of the larger refactorings that I'm working on.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Remove dead branch when restoring ID within a transaction
Conflicts:
activerecord/lib/active_record/transactions.rb
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
There is no way to have an instance of an Active Record model where
`has_attribute?(self.class.primary_key)` returns false. The record is
always initialized in such a way that `@raw_attributes` will have an id
key with nil for the value.
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Reduces the number of places that care about the internals of how we
store and type cast attributes. We do not need to go through the
dup/freeze dance, as you couldn't have saved a frozen new record anyway,
and that is the only time we would end up modifying the frozen hash.
|
|/ / /
| | |
| | |
| | |
| | | |
Reduces the number of things outside of attribute methods that cares
about the details of how we store and type cast attributes
|
| |/
|/|
| |
| |
| |
| | |
This is a follow up to #15556
@kuldeepaggarwal did submit this patch way back (#13624).
|
|\ \
| | |
| | | |
Add array support when time zone aware attributes are enabled
|
| | | |
|
|\ \ \ |
|
| | | | |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
remove rubyforge.org that was shut down [ci skip]
|
| | |_|/
| |/| | |
|
| |_|/
|/| |
| | |
| | | |
Only `Date` and `Time` are handled.
|
|\ \ \
| | | |
| | | | |
Remove composed_of special case from multi-parameter attributes
|
| |/ /
| | |
| | |
| | |
| | | |
As we move towards removing the `klass` method from `column`, the else
clause as it stands right now will become the only case.
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Before this patch, using `ActiveRecord::Base.primary_key_prefix_type`
with `:table_name_with_underscore` would change the `SchemaMigration` model
to have a primary key. This resulted in broken queries for PG because it tried
to return the inserted PK (which does not exist).
Closes #15051.
Closes #15419.
|
| |
| |
| |
| |
| |
| |
| | |
This adds a regression test for #14411, which was fixed by #15503.
Closes #14411
Closes #14595
|
|\ \
| | |
| | | |
Bring type casting behavior of hstore/json in line with serialized
|
| | |
| | |
| | |
| | |
| | | |
`@raw_attributes` should not contain the type-cast, mutable version of
the value.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The migration numbers were normalized different ways. This left
the task output in an inconsistent state.
Closes #15538.
|
|\ \ \
| | | |
| | | |
| | | | |
Baseclass becomes! subclass
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Whiny nils is no longer a thing, so we no longer need this optimization
|
| | | |
| | | |
| | | |
| | | | |
BC era year is (astronomical year + 1) and starts from 1 BC.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Follow up to #15438 and #15502.
/cc @sgrif
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Use null column for association key types
|
| | |/ /
| |/| | |
|
|\ \ \ \
| | | | |
| | | | | |
Collapse PG default extractoin of most types to single regex
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
For any type that is represented as a string and then type cast, we do
not need separate regular expressions for the various types. No function
will match this regex. User defined types *should* match this, so that
the type object can decide what to do with the value.
|
|\ \ \ \
| |/ / /
|/| | | |
Refactor XML serializer to not depend on `serialized_attributes`
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The previous tests were passing, because nothing ever looked at the
generated XML. What was previously being generated was
`<firstname type="NilClass">...`, which is not consistent with all other
cases where there is not a known type.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
prathamesh-sonpatki/change-wording-of-explanation-about-precision-and-scale-of-decimal-numbers
Change wording of explanation about precision & scale of decimal numbers [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | | |
skip]
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fix regression on eager loading association based on SQL query rather than existing column.
Conflicts:
activerecord/CHANGELOG.md
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
than existing column.
Fixes #15480.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Reflection has a `belongs_to?` method. Instead of checking for
`macro == :belongs_to` throughout the source reuse existing
method.
I also bumped `foreign_key_present?` method onto on line because
the `belongs_to?` makes it shorter than other longer lines in
the same class.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Return a null column when no column exists for an attribute
Conflicts:
activerecord/CHANGELOG.md
|
| | | | | | |
|