aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
Commit message (Collapse)AuthorAgeFilesLines
* Raise error on unknown primary key.Jon Leighton2011-10-059-14/+36
| | | | | If we don't have a primary key when we ask for it, it's better to fail fast. Fixes GH #2307.
* Changing rake db:schema:dump to run :environment as well as :load_config, as ↵Ben Woosley2011-10-041-1/+1
| | | | | | | | | | running :load_config alone will lead to the dumper being run without including extensions such as those included in foreigner and spatial_adapter. This reverses a change made here: https://github.com/rails/rails/commit/5df72a238e9fcb18daf6ab6e6dc9051c9106d7bb#L0L324 I'm assuming here that :load_config needs to be invoked separately from :environment, as it is elsewhere in the file for db operations, if not the alternative is to go back to "task :dump => :environment do". Signed-off-by: José Valim <jose.valim@gmail.com>
* Don't call self.class unless necessary. Closes #3171.Jon Leighton2011-09-291-2/+2
|
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-09-281-1/+1
|\
| * fixing docs for delete_sql where quotes should be used in this example.Diego Plentz2011-09-261-1/+1
| |
* | Don't require a DB connection when setting primary key.Jon Leighton2011-09-262-1/+4
| | | | | | | | Closes #2807.
* | Merge pull request #3030 from htanata/fix_habtm_select_query_methodJon Leighton2011-09-261-4/+0
| | | | | | | | Fix: habtm doesn't respect select query method
* | Fix belongs_to polymorphic with custom primary key on target.Jon Leighton2011-09-263-17/+22
| | | | | | | | Closes #3104.
* | CollectionProxy#replace should change the DB records rather than just ↵Jon Leighton2011-09-261-1/+1
|/ | | | mutating the array. Fixes #3020.
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-09-211-0/+29
|\
| * copy edits 908f2616Vijay Dev2011-09-201-4/+4
| |
| * Document ActiveRecord::QueryMethods#selectRyan Bigg2011-09-171-0/+29
| |
* | to_xml should also rely on serializable hash.José Valim2011-09-181-1/+1
|/
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-09-152-1/+37
|\
| * minor editVijay Dev2011-09-141-1/+1
| |
| * Add documentation for the extending method in ActiveRecord:QueryMethodsRyan Bigg2011-09-141-0/+36
| |
| * [:class_name] option in belongs_to should mention belongs_to and not has_oneErik Behrends2011-09-131-1/+1
| |
* | Stop trying to be clever about when to define attribute methods.Jon Leighton2011-09-141-10/+1
| | | | | | | | | | | | | | | | | | There is no meaningful performance penalty in defining attribute methods, since it only happens once. There is also no reason *not* to define them, since they get thrown in an included module, so they will not 'overwrite' anything. In fact, this is desirable, since it allows us to call super.
* | We don't need to build a set for DangerousAttributeError.Jon Leighton2011-09-141-7/+13
| | | | | | | | We can just use method_defined? and private_method_defined?
* | Rename first_or_new to first_or_initialize.Jon Leighton2011-09-132-3/+2
|/ | | | | For consistency with find_or_initialize_by. Also remove first_or_build alias.
* Deprecate using method_missing for attributes that are columns.Jon Leighton2011-09-131-0/+15
| | | | | | This shouldn't ever happen unless people are doing something particularly weird, but adding a deprecation in case there are bugs not caught by our tests.
* Let Ruby deal with method visibility.Jon Leighton2011-09-131-7/+10
| | | | | | Check respond_to_without_attributes? in method_missing. If there is any method that responds (even private), let super handle it and raise NoMethodError if necessary.
* Always generate attribute methods on the base class.Jon Leighton2011-09-132-6/+19
| | | | | | | | | | | | | | This fixes a situation I encountered where a subclass would cache the name of a generated attribute method in @_defined_class_methods. Then, when the superclass has it's attribute methods undefined, the subclass would always have to dispatch through method_missing, because the presence of the attribute in @_defined_class_methods would mean that it is never generated again, even if undefine_attribute_methods is called on the subclass. There various other confusing edge cases like this. STI classes share columns, so let's just keep all the attribute method generation state isolated to the base class.
* Raise error when using write_attribute with a non-existent attribute.Jon Leighton2011-09-134-6/+15
| | | | | | | | | Previously we would just silently write the attribute. This can lead to subtle bugs (for example, see the change in AutosaveAssociation where a through association would wrongly gain an attribute. Also, ensuring that we never gain any new attributes after initialization will allow me to reduce our dependence on method_missing.
* Fix warnings.Jon Leighton2011-09-131-1/+1
| | | | Make sure we don't redefine an already-defined attribute method.
* Add deprecation for doing `attribute_method_suffix ''`Jon Leighton2011-09-131-2/+0
|
* Alias id= if necessary, rather than relying on method_missingJon Leighton2011-09-131-0/+4
|
* Merge pull request #2936 from joelmoss/migration_statusSantiago Pastorino2011-09-111-5/+7
| | | | db:migrate:status not looking at all migration paths
* Merge pull request #2757 from andmej/first_or_create_pull_requestJon Leighton2011-09-082-0/+44
|\ | | | | Add first_or_create family of methods to Active Record
| * Using more precise method signatures for AR::Relation#first_or_create family ↵Andrés Mejía2011-09-061-6/+6
| | | | | | | | of methods.
| * Adding first example with no arguments to AR::Relation#first_or_create and ↵Andrés Mejía2011-09-061-15/+15
| | | | | | | | removing examples that create several users at the same time (this is confusing and not really helpful).
| * Adding first_or_create, first_or_create!, first_or_new and first_or_build to ↵Andrés Mejía2011-08-302-0/+44
| | | | | | | | | | | | | | | | | | | | Active Record. This let's you write things like: User.where(:first_name => "Scarlett").first_or_create!(:last_name => "Johansson", :hot => true) Related to #2420.
* | LRU cache in mysql and sqlite are now per-process caches.Aaron Patterson2011-09-072-21/+30
| |
* | LRU should cache per process in postgresql. fixes #1339Aaron Patterson2011-09-071-10/+14
| |
* | fixing view queriesAaron Patterson2011-09-071-3/+5
| |
* | use the supplied bind valuesAaron Patterson2011-09-071-1/+1
| |
* | Merge commit 'refs/pull/2909/head' of https://github.com/rails/rails into rawrAaron Patterson2011-09-071-6/+4
| | | | | | | | | | | | * https://github.com/rails/rails: Postgresql adapter: added current_schema check for table_exists? Postgresql adapter: added current_schema check for table_exists?
* | Don't include any of includes, preload, joins, eager_load in the through ↵Jon Leighton2011-09-071-1/+1
| | | | | | | | association scope.
* | Merge pull request #2485 from akaspick/exists_fixJon Leighton2011-09-071-1/+3
|\ \ | | | | | | fix exists? to return false if passed nil (which may come from a missing
| * | fix exists? to return false if passed nil (which may come from a missing URL ↵Andrew Kaspick2011-08-101-1/+3
| | | | | | | | | | | | param)
* | | Merge pull request #2897 from rsutphin/ar31-remove_connectionAaron Patterson2011-09-062-2/+2
| | | | | | | | | | | | Patch for issue #2820
* | | Database adapters use a statement pool.Aaron Patterson2011-09-063-8/+46
| | | | | | | | | | | | | | | | | | Database adapters use a statement pool for limiting the number of open prepared statments on the database. The limit defaults to 1000, but can be adjusted in your database config by changing 'statement_limit'.
* | | adding a statement pool for mysql and sqlite3Aaron Patterson2011-09-063-9/+102
| | |
* | | Nested through associations: preloads from the default scope of a through ↵Jon Leighton2011-09-061-1/+1
| | | | | | | | | | | | model should not be included in the association scope. (We're already excluding includes.) Fixes #2834.
* | | Ensure we are not comparing a string with a symbol in ↵Jon Leighton2011-09-061-1/+1
| | | | | | | | | | | | HasManyAssociation#inverse_updates_counter_cache?. Fixes #2755, where a counter cache could be decremented twice as far as it was supposed to be.
* | | Make the logic easier to readJon Leighton2011-09-061-4/+7
| | |
* | | Merge pull request #2716 from jbbarth/fix_invert_rename_indexAaron Patterson2011-09-051-1/+1
|\ \ \ | | | | | | | | Fix bad options order in AR::Migration::CommandRecorder#invert_rename_index
| * | | Fixed bad options order in ↵jbbarth2011-08-281-1/+1
| | | | | | | | | | | | | | | | ActiveRecord::Migration::CommandRecorder#invert_rename_index
* | | | Don't find belongs_to target when the foreign_key is NULL. Fixes #2828Georg Friedrich2011-09-051-0/+4
| | | |
* | | | Use LIMIT sql word in last when it's possibleDamien Mathieu2011-09-051-1/+5
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-24 08:40:58 +0000