aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #12129 from Empact/deprecate-array-bang-delegationRafael Mendonça França2013-09-121-3/+14
|\ | | | | | | | | | | | | | | Deprecate the delegation of Array bang methods in ActiveRecord::Delegation Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/relation_test.rb
| * Deprecate the delegation of Array bang methods in ActiveRecord::DelegationBen Woosley2013-09-041-3/+14
| | | | | | | | | | | | | | | | | | | | | | The primary means of returning results for Array bang methods is to modify the array in-place. When you call these methods on a relation, that array is created, modified, and then thrown away. Only the secondary return value is exposed to the caller. Removing this delegation is a straight-forward way to reduce user error by forcing callers to first explicitly call #to_a in order to expose the array to be acted on by the bang method.
* | Merge pull request #12137 from lann/fix_association_first_lastRafael Mendonça França2013-09-121-3/+1
|\ \ | | | | | | | | | | | | | | | | | | Make CollectionAssociation first/last with integer fetch with query Conflicts: activerecord/CHANGELOG.md
| * | Make CollectionAssociation first/last with integer fetch with queryLann Martin2013-09-091-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When first or last is called with an integer on an unloaded association, the entire collection is loaded. This differs surprisingly from the behavior of Relation#first/last, which translate the call into a limit query. For large collections this can make a big difference in performance. Change CollectionAssociation#fetch_first_or_last_using_find? to make this kind of call delegate to Relation.
* | | Merge pull request #11698 from dmathieu/sqlite_tasks_without_railsRafael Mendonça França2013-09-123-2/+4
|\ \ \ | | | | | | | | | | | | Let the SQLite rake tasks run without rails
| * | | let the sqlite task run without railsDamien Mathieu2013-08-073-2/+4
| | | |
* | | | Merge pull request #12156 from rywall/from-copy-bindsRafael Mendonça França2013-09-121-0/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow Relation#from to accept other relations with bind values. Conflicts: activerecord/CHANGELOG.md
| * | | | Allow Relation#from to accept other relations with bind values.Ryan Wallace2013-09-081-0/+1
| | | | |
* | | | | Disable prepared statements in the unprepared_statement blockRafael Mendonça França2013-09-121-2/+3
| | | | |
* | | | | Fix typo on instance variable get callCarlos Antonio da Silva2013-09-121-1/+1
| | | | |
* | | | | Remove conditional adding a new methodRafael Mendonça França2013-09-112-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At the point we want to add the reflection we already know the reflection is of the AggregateReflection type so we can call a specific method
* | | | | Fix inverted conditionalRafael Mendonça França2013-09-111-1/+1
| | | | | | | | | | | | | | | | | | | | Oops, I should had run the tests
* | | | | Remove invalid commentRafael Mendonça França2013-09-111-4/+0
| | | | | | | | | | | | | | | | | | | | This is not valid anymore after 08477a651648ba4417ded128aa37b9ae0dcbc9ce
* | | | | Check if the SQL is not a prepared statementRafael Mendonça França2013-09-118-7/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the adapter is with prepared statement disabled and the binds array is not empty the connection adapter will try to set the binds values and will fail. Now we are checking if the adapter has the prepared statement disabled. Fixes #12023
* | | | | Merge pull request #12188 from SamSaffron/masterAaron Patterson2013-09-113-11/+15
|\ \ \ \ \ | | | | | | | | | | | | Perf: avoid dupes add fallback logic for coders
| * | | | | Perf: avoid dupes add fallback logic for codersSam2013-09-113-11/+15
| | | | | |
* | | | | | Merge pull request #12135 from dylanahsmith/avoid_empty_transactionRafael Mendonça França2013-09-111-1/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid empty transaction from setting has_one association on new record. Conflicts: activerecord/CHANGELOG.md
| * | | | | | Avoid empty transaction from setting has_one association on new record.Dylan Thacker-Smith2013-09-111-1/+2
| | | | | | |
* | | | | | | WhitespacesRafael Mendonça França2013-09-111-1/+2
| | | | | | |
* | | | | | | Merge pull request #12185 from SamSaffron/join_depRafael Mendonça França2013-09-111-1/+13
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Reduce allocations when extracting AR models
| * | | | | | | Reduce allocations when extracting AR modelsSam2013-09-111-1/+13
| | | | | | | |
* | | | | | | | Merge pull request #12194 from thedarkone/readonly-merger-fixRafael Mendonça França2013-09-111-1/+5
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Relation#merge should not lose readonly(false) flag.
| * | | | | | | | Relation#merge should not lose readonly(false) flag.thedarkone2013-09-111-1/+5
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | The original code ignores the `false` value because `false.blank? # => true`.
* | / / / / / / fix deleting join models with no pkAaron Patterson2013-09-111-1/+15
| |/ / / / / / |/| | | | | |
* | | | | | | ask the association for records rather than calling `send`Aaron Patterson2013-09-101-1/+2
|/ / / / / /
* | | | | | let the class cache object clean up user inputAaron Patterson2013-09-091-8/+20
| | | | | |
* | | | | | Fix fixtures regression that required table names to map to classes only, ↵Jeremy Kemper2013-09-081-1/+1
| |/ / / / |/| | | | | | | | | | | | | | not class names
* | | | | hm:t join tables may not have a primary keyAaron Patterson2013-09-061-1/+5
| | | | |
* | | | | use polymorphic proxies to remove duplicate codeAaron Patterson2013-09-061-24/+43
| | | | |
* | | | | reduce duplication somewhatAaron Patterson2013-09-061-14/+14
| | | | |
* | | | | make the duplicate code more similarAaron Patterson2013-09-061-4/+10
| | | | |
* | | | | auto link hm:t fixture join tables like habtmAaron Patterson2013-09-061-0/+16
| | | | |
* | | | | don't depend on object state when reading fixture filesAaron Patterson2013-09-061-8/+7
| | | | |
* | | | | ensure @model_class is initializedAaron Patterson2013-09-061-0/+1
| | | | |
* | | | | no need to dupAaron Patterson2013-09-051-1/+1
| | | | |
* | | | | push logic outside the FixtureSet constructorAaron Patterson2013-09-051-3/+3
| | | | |
* | | | | only construct the FixtureSet with AR modelsAaron Patterson2013-09-051-2/+11
| | | | |
* | | | | push constant lookup in the a cache objectAaron Patterson2013-09-051-2/+21
| |_|/ / |/| | |
* | | | Merge pull request #11958 from jetthoughts/extract_pre_process_orders_argsYves Senn2013-09-041-13/+16
|\ \ \ \ | |_|_|/ |/| | | Re-use order arguments pre-processing for reorder
| * | | Extracted from `order` processing of arguments, and use it for `reorder` to ↵Paul Nikitochkin2013-09-041-13/+16
| | | | | | | | | | | | | | | | be consistent.
* | | | support anonymous classes on has_many associationsAaron Patterson2013-09-032-1/+2
| | | |
* | | | Merge pull request #12065 from SamSaffron/result_optimisationAaron Patterson2013-09-031-1/+15
|\ \ \ \ | | | | | | | | | | Perf: micro optimised Result column hash_row creation
| * | | | Perf: micro optimised Result column hash_row creationSam2013-08-291-1/+15
| | | | |
* | | | | Revert "Merge pull request #12085 from valk/master"Santiago Pastorino2013-09-031-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 15455d76c8d33b3767a61e0cdd2de0ff592098ef, reversing changes made to ffa56f73d5ae98fe0b8b6dd2ca6f0dffac9d9217.
* | | | | Remove useless comment and white spaces :scissors: [ci skip]Carlos Antonio da Silva2013-09-012-3/+2
| | | | |
* | | | | Revert "Do not dup the binds when visiting the AST"Rafael Mendonça França + Kassio Borges2013-08-312-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 71ff7d9c6592b93e2c810a1f464943dd7bd02c7f. Reason: I need to check with @jeremy if we can do this.
* | | | | Don't need to check if the scope respond to callRafael Mendonça França + Kassio Borges2013-08-311-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | We are checking this when defining the default scope and raising an ArgumentError
* | | | | Do not dup the binds when visiting the ASTRafael Mendonça França2013-08-312-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The visitor have to consume the bind parameters to make the statements work when the prepared statement option is disabled. Fixes #12023
* | | | | Don't use Enumerable#next in pluck since it is very slowRyan Wallace2013-08-301-2/+1
| | | | |
* | | | | Merge pull request #12090 from njakobsen/merger-performanceAaron Patterson2013-08-301-3/+3
|\ \ \ \ \ | | | | | | | | | | | | [Performance] Don't create fibers while merging bind variables
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 22:21:26 +0000