aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
Commit message (Collapse)AuthorAgeFilesLines
* fix mysql version check in rename_indexCody Cutrer2013-11-281-1/+1
| | | | also clarify native rename_index support is >= 5.7, not > 5.7
* implement rename_index natively for MySQL > 5.7Cody Cutrer2013-11-281-0/+8
|
* [ci skip]removed obsolete information about `options` parameter in create methodKuldeep Aggarwal2013-11-271-3/+0
|
* [ci skip] used new syntax for scopesKuldeep Aggarwal2013-11-271-1/+1
|
* Merge pull request #13061 from ↵Rafael Mendonça França2013-11-261-1/+9
| | | | | | | | laurocaetano/fix-uniqueness-validation-for-aliased-attribute Fix bug when validating the uniqueness of an aliased attribute. Conflicts: activerecord/CHANGELOG.md
* changed update counter to act on unscoped modelheruku2013-11-261-1/+1
|
* tyopAkira Matsuda2013-11-261-1/+1
|
* `rename_index`: add the new index before removing the old one.Yves Senn2013-11-261-2/+2
| | | | | | | | | | | This prevents the following error when a MySQL index on a foreign key column is renamed: ``` ActiveRecord::StatementInvalid: Mysql2::Error: Cannot drop index 'index_engines_on_car_id': needed in a foreign key constraint: DROP INDEX `index_engines_on_car_id` ON `engines` ``` refs: #13038.
* Raise `RecordNotDestroyed` when children can't be replacedBrian Thomas Storti2013-11-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #12812 Raise `ActiveRecord::RecordNotDestroyed` when a child marked with `dependent: destroy` can't be destroyed. The following code: ```ruby class Post < ActiveRecord::Base has_many :comments, dependent: :destroy end class Comment < ActiveRecord::Base before_destroy do return false end end post = Post.create!(comments: [Comment.create!]) post.comments = [Comment.create!] ```` would result in a `post` with two `comments`. With this commit, the same code would raise a `RecordNotDestroyed` exception, keeping the `post` with the same `comment`.
* Merge remote-tracking branch 'docrails/master'Xavier Noria2013-11-244-19/+19
|\ | | | | | | | | | | Conflicts: activesupport/lib/active_support/core_ext/hash/deep_merge.rb activesupport/lib/active_support/core_ext/hash/keys.rb
| * Change syntax format for example returned valuesPrem Sichanugrist2013-11-114-19/+19
| | | | | | | | | | | | | | | | | | According to our guideline, we leave 1 space between `#` and `=>`, so we want `# =>` instead of `#=>`. Thanks to @fxn for the suggestion. [ci skip]
* | Fix validation on uniqueness of empty associationEvgeny Li2013-11-221-1/+1
| |
* | Merge pull request #12962 from ↵Xavier Noria2013-11-211-1/+1
|\ \ | | | | | | | | | | | | kamipo/call_initialize_schema_migrations_table_from_migration Use `SchemaStatements#initialize_schema_migrations_table` instead of `ActiveRecord::SchemaMigration.create_table`.
| * | Use `SchemaStatements#initialize_schema_migrations_table` instead of ↵Ryuta Kamizono2013-11-201-1/+1
| | | | | | | | | | | | `ActiveRecord::SchemaMigration.create_table`.
* | | Fix ActiveRecord::Relation#unscopeJon Leighton2013-11-202-6/+13
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm pretty confused about the addition of this method. The documentation says that it was intended to allow the removal of values from the default scope (in contrast to #except). However it behaves exactly the same as except: https://gist.github.com/jonleighton/7537008 (other than having a slightly enhanced syntax). The removal of the default scope is allowed by 94924dc32baf78f13e289172534c2e71c9c8cade, which was not a change we could make until 4.1 due to the need to deprecate things. However after that change #unscope still gives us nothing that #except doesn't already give us. However there *is* a desire to be able to unscope stuff in a way that persists across merges, which would allow associations to be defined which unscope stuff from the default scope of the associated model. E.g. has_many :comments, -> { unscope where: :trashed } So that's what this change implements. I've also corrected the documentation. I removed the guide references to #except as I think unscope really supercedes #except now. While we're here, there's also a potential desire to be able to write this: has_many :comments, -> { unscoped } However, it doesn't make sense and would not be straightforward to implement. While with #unscope we're specifying exactly what we want to be removed from the relation, with "unscoped" we're just saying that we want it to not have some things which were added earlier on by the default scope. However in the case of an association, we surely don't want *all* conditions to be removed, otherwise the above would just become "SELECT * FROM comments" with no foreign key constraint. To make the above work, we'd have to somehow tag the relation values which get added when evaluating the default scope in order to differentiate them from other relation values. Which is way too much complexity and therefore not worth it when most use cases can be satisfied with unscope. Closes #10643, #11061.
* | use arel nodes to represent non-string `order_values`.Yves Senn2013-11-191-19/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a bug when merging relations of different classes. ``` Given: Post.joins(:author).merge(Author.order(name: :desc)).to_sql Before: SELECT "posts".* FROM "posts" INNER JOIN "authors" ON "authors"."id" = "posts"."author_id" ORDER BY "posts"."name" DESC After: SELECT "posts".* FROM "posts" INNER JOIN "authors" ON "authors"."id" = "posts"."author_id" ORDER BY "authors"."name" DESC ```
* | Revert "Explicitly exit with status "1" for create and drop failures"Rafael Mendonça França2013-11-192-29/+10
| | | | | | | | | | | | | | | | | | | | This reverts commit 22f80ae57b26907f662b7fd50a7270a6381e527e. See https://github.com/rails/rails/commit/22f80ae57b26907f662b7fd50a7270a6381e527e#commitcomment-4640676 Conflicts: activerecord/CHANGELOG.md
* | Drop unused param `should_be_quoted` to `PostgreSQLColumn#array_to_string`Vipul A M2013-11-171-1/+1
| |
* | pass the pk to compile_updateAaron Patterson2013-11-163-3/+6
| |
* | Merge pull request #12918 from versioncontrol/rails-12866Rafael Mendonça França2013-11-161-1/+6
|\ \ | | | | | | | | | | | | | | | | | | Checks to see if the record contains the foreign_key to set the inverse automatically Conflicts: activerecord/CHANGELOG.md
| * | Checks to see if the record contains the foreign_key to set the inverse ↵Edo Balvers2013-11-161-1/+6
| | | | | | | | | | | | automatically
* | | Merge pull request #12779 from ↵Aaron Patterson2013-11-152-10/+0
|\ \ \ | | | | | | | | | | | | | | | | dougbarth/dont_swallow_exceptions_during_transactional_statements_in_mysql Don't swallow exceptions in transctional statements
| * | | Don't swallow exceptions in transctional statementsDoug Barth2013-11-052-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The MySQL connection adapater swallows all StandardError exceptions, which includes Mysql::Error and Mysql2::Error. The comment in the exception clause claims errors thrown here indicate that transactions aren't supported by the server but that isn't necessarily true. It's possible the MySQL server has gone away and swallowing a failed commit may let the application return a successful response when the data has not been saved. Also, replication libraries like Galera require that the application handle exceptions thrown at BEGIN/COMMIT. I'm unable to determine what version of MySQL threw an exception for transactional statements. I tried as far back as 3.23.49 with InnoDB disabled but BEGIN & COMMIT statements do not throw an error. If there's a real case for this logic to continue, we could instead push this behavior into a configuration setting. The exception swallowing has been there since the beginning: db045dbbf60b53dbe013ef25554fd013baf88134
* | | | Merge pull request #12531 from iamvery/database-tasks-exit-statusRafael Mendonça França2013-11-152-10/+29
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Explicitly exit with status "1" for create and drop task failures Conflicts: activerecord/CHANGELOG.md
| * | | | Explicitly exit with status "1" for create and drop failuresJay Hayes2013-11-112-10/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * A non-zero exit status allows subsequent shell commands to be chained together such as: `rake db:reset test:prepare && rspec && cap deploy` (if you're feeling brave :) * Any exceptions raised during the `create` and `drop` tasks are caught in order to print a "pretty" message to the user. Unfortunately doing so prevents rake from aborting with a non-zero exit status to the shell. * Therefore we re-raise the exceptions after the "pretty" message and re-catch them in the task. * From the task we explicitly exit with a non-zero status. This method was chosen (rather than just letting rake fail from the exception) so that the backtrace is suppressed and the output to stderr is unchanged. * Update activerecord CHANGELOG
* | | | | explain how `to_param` wil truncate long values. [ci skip] refs #12900.Yves Senn2013-11-151-0/+3
| | | | |
* | | | | added one test case and example for ActiveRecord::Base.to_param methodKuldeep Aggarwal2013-11-151-0/+4
| | | | |
* | | | | document id prefixed String usage of `.find`. refs #12891 [ci skip]Yves Senn2013-11-151-5/+6
| | | | |
* | | | | Fix test name [ci skip]Carlos Antonio da Silva2013-11-141-2/+0
| | | | |
* | | | | Fix that eager loading of polymorphic associations did not work with ↵David Heinemeier Hansson2013-11-141-1/+9
| | | | | | | | | | | | | | | | | | | | association empty?/any? predicates any more (there is still a problem when select is applied to a relation, or if you try association#exists? -- but its easier to work around)
* | | | | Merge pull request #12893 from javan/to-param-addendumRafael Mendonça França2013-11-141-6/+10
|\ \ \ \ \ | | | | | | | | | | | | Addendum to #12891
| * | | | | Addendum to #12891Javan Makhmali2013-11-141-6/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix incorrectly named tests * Restore Object#to_param behavior * Ensure param is derived from a squished and truncated string
* | | | | | Merge pull request #12819 from vipulnsward/also_dup_column_typesRafael Mendonça França2013-11-141-3/+4
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Also dup `column_types` in AR::Result `initialize_copy`
| * | | | | Also dup `column_types` in AR::Result `initialize_copy`Vipul A M2013-11-101-3/+4
| | | | | |
* | | | | | Add AR::Base.to_param for convenient "pretty" URLs derived from a model's ↵Javan Makhmali2013-11-141-0/+31
| | | | | | | | | | | | | | | | | | | | | | | | attribute or method.
* | | | | | Merge pull request #12832 from vipulnsward/move_schema_creationYves Senn2013-11-142-78/+84
|\ \ \ \ \ \ | | | | | | | | | | | | | | Move `SchemaCreation` to its own file instead of `AbstractAdapter`.
| * | | | | | Move `SchemaCreation` to its own file instead of `AbstractAdapter`.Vipul A M2013-11-122-78/+84
| |/ / / / /
* | | | | | Merge pull request #12845 from amatsuda/should_ar_depend_on_railsGuillermo Iguaran2013-11-131-1/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | Refer to Rails.env from AR only when Rails is defined
| * | | | | | Refer to Rails.env only when Rails is definedAkira Matsuda2013-11-111-1/+5
| | | | | | |
* | | | | | | add #no_touching on ActiveRecord modelsDamien Mathieu2013-11-132-0/+53
| | | | | | |
* | | | | | | Remove the unused, undocumented SQLite3Adapter#supports_count_distinct?Ben Woosley2013-11-121-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This has returned true since 3cc9b5f1, and is not used internally.
* | | | | | | Drop a sqlite_version check because we only support SQLite 3.6.16 or newer.Ben Woosley2013-11-122-7/+1
| | | | | | | | | | | | | | | | | | | | | Drop some comments that document the implementation rather than the interface.
* | | | | | | Prevent the counter cache from being decremented twicedm1try2013-11-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when destroying a record on a has_many :through association. :destroy method has own counter_cache callbacks.
* | | | | | | Unifies mysql and mysql2 casting of booleans.Yves Senn2013-11-112-6/+6
| | | | | | |
* | | | | | | Merge pull request #12834 from dredozubov/has_one_association_replacementYves Senn2013-11-111-2/+4
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fixes problem with replacing has_one association record with itself
| * | | | | | | Fixes problem with replacing has_one association record with itselfDenis Redozubov2013-11-111-2/+4
| |/ / / / / /
* / / / / / / autoload ChangeColumnDefinition (Fixes #12835)Anton Kalyaev2013-11-111-0/+1
|/ / / / / /
* | | | | | Change array check for better aesthetics / reading the codeCarlos Antonio da Silva2013-11-091-1/+1
| | | | | |
* | | | | | Merge pull request #12821 from arunagw/aa-removed-missleading-messageYves Senn2013-11-091-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | clarified missleading message
| * | | | | | Changed message for Model.inspectArun Agrawal2013-11-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (No database connection) sounds not be able to connect database. see more #12804
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-15 22:40:39 +0000