aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
Commit message (Collapse)AuthorAgeFilesLines
* Extract `default_extensions` to avoid `klass.all`Ryuta Kamizono2017-05-302-1/+9
| | | | | As @matthewd's suggestion, if `klass` has no default scope, it will more faster.
* Refactor `default_scoped` to avoid creating extra relation and mergingRyuta Kamizono2017-05-281-7/+2
|
* Cache the association proxy objectRyuta Kamizono2017-05-282-4/+8
| | | | | | | | | | Some third party modules expects that association returns same proxy object each time (e.g. for stubbing collection methods: https://github.com/rspec/rspec-rails/issues/1817). So I decided that cache the proxy object and reset scope in the proxy object each time. Related context: https://github.com/rails/rails/commit/c86a32d7451c5d901620ac58630460915292f88b#commitcomment-2784312
* Fix association with extension issuesRyuta Kamizono2017-05-285-24/+18
| | | | | | | | This fixes the following issues. * `association_scope` doesn't include `default_scope`. Should use `scope` instead. * We can't use `method_missing` for customizing existing method. * We can't use `relation_delegate_class` for sharing extensions. Should extend per association.
* Merge pull request #29240 from tjschuck/ar_batches_doc_updatesRafael França2017-05-261-12/+12
|\ | | | | Doc updates for ActiveRecord::Batches
| * Doc updates for ActiveRecord::BatchesT.J. Schuck2017-05-261-12/+12
| | | | | | [ci skip]
* | Merge pull request #29237 from mohitnatoo/arel-update-docRafael França2017-05-261-3/+3
|\ \ | |/ |/| [ci skip] Changed sentence formation for ActiveRecordRelation#update
| * [ci skip] Changed sentence formation for ActiveRecordRelation#updateMohit Natoo2017-05-261-3/+3
| |
* | Avoid circular require due to autoloadMatthew Draper2017-05-261-9/+9
| |
* | Merge pull request #29215 from voxmedia/ar_optimizationsMatthew Draper2017-05-263-3/+4
|\ \ | | | | | | ActiveRecord initialization optimizations
| * | Make #deep_dup use #allocate instead of #newMichael Lovitt2017-05-251-1/+3
| | | | | | | | | | | | | | | | | | This change preserves the speedup made in a24912cb1d3 (by avoiding the wasted shallow dup of @attributes) while ensuring that the performance of #deep_dup won't be tied to the performance of #initialize
| * | Performance optimization for ActiveRecord#column_defaultsMichael Lovitt2017-05-241-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Memoize the #column_defaults class property, as ActiveRecord does for other properties in this module. This change addresses slowness in ActiveRecord initialization introduced starting in Rails 5.0. This method's performance has not changed with Rails 5, but it is now called much more frequently than before: every time an STI model is instantiated.
| * | Performance optimization for ActiveRecord#subclass_from_attributesMichael Lovitt2017-05-241-1/+1
| | | | | | | | | | | | | | | This change addresses slowness in ActiveRecord initialization introduced starting in Rails 5.0.
| * | Performance optimization for AttributeSet#deep_dupMichael Lovitt2017-05-241-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Skip the call to #dup, since it does a shallow copy of attributes, which is wasted effort, since #deep_dup then replaces that shallow copy with a #deep_dup of the given attributes. This change addresses slowness in ActiveRecord initialization introduced starting in Rails 5.0.
* | | Merge pull request #29216 from matthewd/threadsafe-load-schemaMatthew Draper2017-05-261-3/+22
|\ \ \ | | | | | | | | Add a Monitor to ModelSchema#load_schema
| * | | Add a Monitor to ModelSchema#load_schemaMatthew Draper2017-05-251-3/+22
| |/ / | | | | | | | | | [Vikrant Chaudhary, David Abdemoulaie, Matthew Draper]
* | | Merge pull request #29181 from kamipo/fix_circular_left_joins_with_scopingMatthew Draper2017-05-251-1/+1
|\ \ \ | |/ / |/| | Fix crashing on circular left join references with scoping
| * | Fix crashing on circular left join references with scopingRyuta Kamizono2017-05-241-1/+1
| | | | | | | | | | | | Follow up of #25702.
* | | Fix a RuboCop offences using `rubocop -a`Koichi ITO2017-05-242-4/+3
|/ /
* | Merge pull request #29145 from kamipo/reference_type_should_be_not_nullMatthew Draper2017-05-241-1/+1
|\ \ | | | | | | Both reference id and type should be `NOT NULL` if `null: false` is specified
| * | Both reference id and type should be `NOT NULL` if `null: false` is specifiedRyuta Kamizono2017-05-191-1/+1
| | | | | | | | | | | | | | | | | | This is a regression due to #28282. Fixes #29136.
* | | Merge pull request #29027 from mohitnatoo/foreign-key-nameMatthew Draper2017-05-241-2/+3
|\ \ \ | | | | | | | | Adding Foreing Key - Don't worry about building the identifier if name is already present.
| * | | [Foreign Key] Don't worry about the building identifier if name is already ↵Mohit Natoo2017-05-101-2/+3
| | |/ | |/| | | | | | | present.
* | | Merge pull request #29174 from kamipo/remove_unused_join_part_nameMatthew Draper2017-05-241-4/+0
|\ \ \ | | | | | | | | Remove unused `JoinPart#name`
| * | | Remove unused `JoinPart#name`Ryuta Kamizono2017-05-221-4/+0
| | | |
* | | | Merge pull request #29182 from kamipo/remove_unused_left_joins_values_generationMatthew Draper2017-05-241-1/+1
|\ \ \ \ | | | | | | | | | | Remove unused `left_joins_values` generation
| * | | | Remove unused `left_joins_values` generationRyuta Kamizono2017-05-231-1/+1
| |/ / / | | | | | | | | | | | | This was added at #22125 but `left_joins_values` is never used.
* | | | Merge pull request #29183 from kamipo/refactor_making_join_constraintsMatthew Draper2017-05-241-23/+6
|\ \ \ \ | | | | | | | | | | Refactor making join constraints
| * | | | Refactor making join constraintsRyuta Kamizono2017-05-231-23/+6
| |/ / / | | | | | | | | | | | | | | | | The only difference between `make_inner_joins` and `make_left_outer_joins` is the `join_type`.
* / / / More friendly exception in nested attributesKir Shatrov2017-05-221-1/+1
|/ / /
* | | Merge pull request #29156 from kamipo/make_valid_directions_to_setAndrew White2017-05-201-3/+5
|\ \ \ | | | | | | | | Make `VALID_DIRECTIONS` to `Set`
| * | | Make `VALID_DIRECTIONS` to `Set`Ryuta Kamizono2017-05-201-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ```ruby require "benchmark/ips" require "set" array = [:asc, :desc, :ASC, :DESC, "asc", "desc", "ASC", "DESC"] set = array.to_set item = "DESC" Benchmark.ips do |x| x.report "array" do array.include?(item) end x.report "set" do set.include?(item) end end ``` ``` % ruby array_vs_set.rb Warming up -------------------------------------- array 188.441k i/100ms set 229.531k i/100ms Calculating ------------------------------------- array 3.508M (± 9.0%) i/s - 17.525M in 5.043058s set 5.134M (± 7.6%) i/s - 25.707M in 5.038921s ```
* | | | Fix `warning: assigned but unused variable - timestamp`Ryuta Kamizono2017-05-201-1/+1
|/ / /
* | / Add cache_key_with_version and use it in ActiveSupport::Cache.expand_cache_keyDavid Heinemeier Hansson2017-05-191-17/+26
| |/ |/| | | | | | | | | This retains the existing behavior of ActiveSupport::Cache.expand_cache_key (as used by etaging) where the cache key includes the version.
* | Use recyclable cache keys (#29092)David Heinemeier Hansson2017-05-181-9/+40
| |
* | Remove unneeded `association.respond_to?(:reset_scope)`Ryuta Kamizono2017-05-171-1/+1
| | | | | | | | | | Since 86390c3 all associations have `reset_scope` so `respond_to?` is unneeded.
* | Fix association documentationRafael Mendonça França2017-05-161-6/+5
| | | | | | | | | | | | | | The object inside the scope is of the class that define the association not the associated class. [ci skip]
* | Improvements for SQLite rake task.Guillermo Iguaran2017-05-151-7/+18
| | | | | | | | | | | | * Use NOT IN in SQL query * Quote table names propertly * Use array form of command invocation
* | Update SchemaDumper.ignore_tables docsGuillermo Iguaran2017-05-151-2/+2
| |
* | Respect 'ignore_tables' in SQLite structure dumpGuillermo Iguaran2017-05-151-1/+10
| |
* | Respect 'ignore_tables' in MySQL structure dumpGuillermo Iguaran2017-05-151-0/+6
| |
* | Respect `ignore_tables` in Postgres structure dumpRusty Geldmacher2017-05-151-0/+6
| | | | | | | | | | | | When using `sql` as the schema format, or even just doing `rake db:structure:dump`, it would be good to respect the list of ignored tables that has been configured.
* | Merge pull request #28919 from ↵Kasper Timm Hansen2017-05-121-1/+1
|\ \ | | | | | | | | | | | | meinac/fix_ambigious_exception_message_of_select_query_method Fix ambigious error message of select query method [ci skip]
| * | Fix ambigious error message of select query methodMehmet Emin INAC2017-05-081-1/+1
| | |
* | | Merge pull request #29043 from kamipo/dont_eager_loading_if_unneeded_for_existsAaron Patterson2017-05-112-4/+5
|\ \ \ | | | | | | | | Don't eager loading if unneeded for `FinderMethods#exists?`
| * | | Don't eager loading if unneeded for `FinderMethods#exists?`Ryuta Kamizono2017-05-112-4/+5
| | |/ | |/| | | | | | | Fixes #29025.
* / | Defer loading each DB Tasks class from AR DatabaseTasksAkira Matsuda2017-05-111-6/+6
|/ / | | | | | | | | | | Because we don't need to load tasks for DBs that we don't use for the current app. Also, these Tasks classes load AR::Base in their class level, and so immediately kick :active_record on_load hooks. This used to happen when we were loading tasks, not when we run a task.
* | Merge pull request #28989 from matthewd/quoted_id-deprecationMatthew Draper2017-05-061-1/+8
|\ \ | | | | | | Clarify deprecation message for #quoted_id
| * | Clarify deprecation message for #quoted_idMatthew Draper2017-05-051-1/+8
| | | | | | | | | | | | | | | In this case, it's the method definition that's more at fault, rather than the current caller.
* | | Don't pass `arel.engine` to `Arel::SelectManager.new`Ryuta Kamizono2017-05-053-9/+6
| | | | | | | | | | | | | | | | | | The argument of `Arel::SelectManager.new` is `table`, not `engine`. https://github.com/rails/arel/blob/v8.0.0/lib/arel/select_manager.rb#L10
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 22:54:25 +0000