aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | Don't swallow exceptions in transctional statementsDoug Barth2013-11-052-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The MySQL connection adapater swallows all StandardError exceptions, which includes Mysql::Error and Mysql2::Error. The comment in the exception clause claims errors thrown here indicate that transactions aren't supported by the server but that isn't necessarily true. It's possible the MySQL server has gone away and swallowing a failed commit may let the application return a successful response when the data has not been saved. Also, replication libraries like Galera require that the application handle exceptions thrown at BEGIN/COMMIT. I'm unable to determine what version of MySQL threw an exception for transactional statements. I tried as far back as 3.23.49 with InnoDB disabled but BEGIN & COMMIT statements do not throw an error. If there's a real case for this logic to continue, we could instead push this behavior into a configuration setting. The exception swallowing has been there since the beginning: db045dbbf60b53dbe013ef25554fd013baf88134
* | | | | Merge pull request #12531 from iamvery/database-tasks-exit-statusRafael Mendonça França2013-11-152-10/+29
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Explicitly exit with status "1" for create and drop task failures Conflicts: activerecord/CHANGELOG.md
| * | | | | Explicitly exit with status "1" for create and drop failuresJay Hayes2013-11-112-10/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * A non-zero exit status allows subsequent shell commands to be chained together such as: `rake db:reset test:prepare && rspec && cap deploy` (if you're feeling brave :) * Any exceptions raised during the `create` and `drop` tasks are caught in order to print a "pretty" message to the user. Unfortunately doing so prevents rake from aborting with a non-zero exit status to the shell. * Therefore we re-raise the exceptions after the "pretty" message and re-catch them in the task. * From the task we explicitly exit with a non-zero status. This method was chosen (rather than just letting rake fail from the exception) so that the backtrace is suppressed and the output to stderr is unchanged. * Update activerecord CHANGELOG
* | | | | | explain how `to_param` wil truncate long values. [ci skip] refs #12900.Yves Senn2013-11-151-0/+3
| | | | | |
* | | | | | added one test case and example for ActiveRecord::Base.to_param methodKuldeep Aggarwal2013-11-151-0/+4
| | | | | |
* | | | | | document id prefixed String usage of `.find`. refs #12891 [ci skip]Yves Senn2013-11-151-5/+6
| | | | | |
* | | | | | Fix test name [ci skip]Carlos Antonio da Silva2013-11-141-2/+0
| | | | | |
* | | | | | Fix that eager loading of polymorphic associations did not work with ↵David Heinemeier Hansson2013-11-141-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | association empty?/any? predicates any more (there is still a problem when select is applied to a relation, or if you try association#exists? -- but its easier to work around)
* | | | | | Merge pull request #12893 from javan/to-param-addendumRafael Mendonça França2013-11-141-6/+10
|\ \ \ \ \ \ | | | | | | | | | | | | | | Addendum to #12891
| * | | | | | Addendum to #12891Javan Makhmali2013-11-141-6/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix incorrectly named tests * Restore Object#to_param behavior * Ensure param is derived from a squished and truncated string
* | | | | | | Merge pull request #12819 from vipulnsward/also_dup_column_typesRafael Mendonça França2013-11-141-3/+4
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Also dup `column_types` in AR::Result `initialize_copy`
| * | | | | | Also dup `column_types` in AR::Result `initialize_copy`Vipul A M2013-11-101-3/+4
| | | | | | |
* | | | | | | Add AR::Base.to_param for convenient "pretty" URLs derived from a model's ↵Javan Makhmali2013-11-141-0/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | attribute or method.
* | | | | | | Merge pull request #12832 from vipulnsward/move_schema_creationYves Senn2013-11-142-78/+84
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Move `SchemaCreation` to its own file instead of `AbstractAdapter`.
| * | | | | | | Move `SchemaCreation` to its own file instead of `AbstractAdapter`.Vipul A M2013-11-122-78/+84
| |/ / / / / /
* | | | | | | Merge pull request #12845 from amatsuda/should_ar_depend_on_railsGuillermo Iguaran2013-11-131-1/+5
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Refer to Rails.env from AR only when Rails is defined
| * | | | | | | Refer to Rails.env only when Rails is definedAkira Matsuda2013-11-111-1/+5
| | | | | | | |
* | | | | | | | add #no_touching on ActiveRecord modelsDamien Mathieu2013-11-132-0/+53
| | | | | | | |
* | | | | | | | Remove the unused, undocumented SQLite3Adapter#supports_count_distinct?Ben Woosley2013-11-121-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This has returned true since 3cc9b5f1, and is not used internally.
* | | | | | | | Drop a sqlite_version check because we only support SQLite 3.6.16 or newer.Ben Woosley2013-11-122-7/+1
| | | | | | | | | | | | | | | | | | | | | | | | Drop some comments that document the implementation rather than the interface.
* | | | | | | | Prevent the counter cache from being decremented twicedm1try2013-11-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when destroying a record on a has_many :through association. :destroy method has own counter_cache callbacks.
* | | | | | | | Unifies mysql and mysql2 casting of booleans.Yves Senn2013-11-112-6/+6
| | | | | | | |
* | | | | | | | Merge pull request #12834 from dredozubov/has_one_association_replacementYves Senn2013-11-111-2/+4
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Fixes problem with replacing has_one association record with itself
| * | | | | | | | Fixes problem with replacing has_one association record with itselfDenis Redozubov2013-11-111-2/+4
| |/ / / / / / /
* / / / / / / / autoload ChangeColumnDefinition (Fixes #12835)Anton Kalyaev2013-11-111-0/+1
|/ / / / / / /
* | | | | | | Change array check for better aesthetics / reading the codeCarlos Antonio da Silva2013-11-091-1/+1
| | | | | | |
* | | | | | | Merge pull request #12821 from arunagw/aa-removed-missleading-messageYves Senn2013-11-091-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | clarified missleading message
| * | | | | | | Changed message for Model.inspectArun Agrawal2013-11-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (No database connection) sounds not be able to connect database. see more #12804
* | | | | | | | improve Active Record Store docs when using PG types. [ci skip].Yves Senn2013-11-091-3/+4
| | | | | | | |
* | | | | | | | type casted PG bytea values are represented as a Hash.Yves Senn2013-11-091-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to: 97f0d9a0dd12e7ad634815eecfeff866f64aad92 This change is also related to: df0edafac9eb47cd971970a9e7b13a3eaddf214e
* | | | | | | | Document the bind returnRafael Mendonça França2013-11-091-0/+3
| | | | | | | |
* | | | | | | | Avoid shot circuit return.Rafael Mendonça França2013-11-091-8/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will make the conditional and to code clear
* | | | | | | | Don't use Active Support where we don't need toRafael Mendonça França2013-11-093-3/+3
| | | | | | | |
* | | | | | | | Fix typo in AR store docs [ci skip]Carlos Antonio da Silva2013-11-091-1/+1
|/ / / / / / /
* / / / / / / log bind variables after they were type casted.Yves Senn2013-11-093-10/+16
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The log output used to be confusing in situation where type casting has "unexpected" effects. For example when finding records with a `String`. BEFORE: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", "im-no-integer"]] AFTER: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", 0]]
* | | | | | Merge pull request #12791 from jasonayre/ja/fix_autoload_errorRafael Mendonça França2013-11-071-0/+1
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | add autoload :TransactionState to fix Marshal.load issues
| * | | | | add autoload :TransactionState to fix Marshal.load issuesJason Ayre2013-11-071-0/+1
| | |_|/ / | |/| | |
* | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2013-11-072-0/+7
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | refine usage docs of `store` in combination with `hstore` and `json`.Yves Senn2013-11-061-3/+3
| | | | | | | | | | | | | | | | | | | | refs #11561 #12700
| * | | | Hstore and JSON fields are not supported with storeRobin Dupret2013-10-301-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | The use of `store` on Hstore fields (for instance) is not needed because serialization aimed to interact with Ruby objects and not with provided field types
| * | | | warning about saving models with dirty attributesDamien Mathieu2013-10-231-0/+3
| | | | | | | | | | | | | | | | | | | | See #8328
* | | | | Stop using method missing for singleton delegation.Aaron Patterson2013-11-061-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This saved about 46 array allocations per request on an extremely simple application. The delegation happened in the notification subsystem which is a hotspot, so this should result in even more savings with larger apps. Squashed commit of the following: commit 41eef0d1479526f7de25fd4391d98e61c126d9f5 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Wed Nov 6 16:32:31 2013 -0800 speed up notifications commit 586b4a18656f66fb2c518fb8e8fee66a016e8ae6 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Wed Nov 6 16:31:05 2013 -0800 speed up runtime registry methods commit b67d074cb4314df9a88438f785868cef77e583d7 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Wed Nov 6 16:28:12 2013 -0800 change method name and make it public
* | | | | bring back constant to expose the enum mapping as HWIA.Yves Senn2013-11-061-4/+13
| | | | |
* | | | | update the AR enum docs to match the actual behavior. [ci skip]Yves Senn2013-11-061-5/+3
| |_|/ / |/| | |
* | | | store enum mapping using `Strings` instead of `Symbols`.Yves Senn2013-11-051-1/+2
| | | | | | | | | | | | | | | | | | | | This allows to assign both `String` and `Symbol` values to the enum without having to call `to_sym`, which is a security problem.
* | | | direct enum assignment rasies ArgumentError for unknown values.Yves Senn2013-11-051-1/+6
| | | |
* | | | define enum methods inside a `Module` to make them overwritable.Yves Senn2013-11-051-13/+24
| | | |
* | | | Merge pull request #12390 from kennyj/rename_to_association_methodsRafael Mendonça França2013-11-054-7/+7
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Renamed generated_feature_methods to generated_association_methods. Conflicts: activerecord/lib/active_record/associations/builder/association.rb activerecord/lib/active_record/associations/builder/singular_association.rb activerecord/test/cases/base_test.rb
| * | | | Renamed generated_feature_methods to generated_association_methods.kennyj2013-09-284-7/+7
| | | | |
* | | | | ask the fixture set for the sql statementsAaron Patterson2013-11-042-11/+17
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-10 02:52:01 +0000