Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | push ivar initialization down to a common method | Aaron Patterson | 2012-01-19 | 1 | -16/+20 |
| | |||||
* | just use an alias. The target method is public, so make this one public | Aaron Patterson | 2012-01-19 | 1 | -4/+1 |
| | | | | too. | ||||
* | avoid useless is_a checks | Aaron Patterson | 2012-01-19 | 1 | -8/+8 |
| | |||||
* | Merge pull request #4531 from exviva/pessimistic_with_lock | Aaron Patterson | 2012-01-19 | 1 | -0/+22 |
|\ | | | | | Add ActiveRecord::Base#with_lock | ||||
| * | Add ActiveRecord::Base#with_lock | Olek Janiszewski | 2012-01-18 | 1 | -0/+22 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a `with_lock` method to ActiveRecord objects, which starts a transaction, locks the object (pessimistically) and yields to the block. The method takes one (optional) parameter and passes it to `lock!`. Before: class Order < ActiveRecord::Base def cancel! transaction do lock! # ... cancelling logic end end end After: class Order < ActiveRecord::Base def cancel! with_lock do # ... cancelling logic end end end | ||||
* | | select doesn't take multiple arguments - fixes #4539 [ci skip] | Vijay Dev | 2012-01-19 | 1 | -5/+5 |
|/ | | | | | Also, fixed the bit about returning AM::MissingAttributeError. This seems to be fixed earlier in 3-2-stable only. | ||||
* | Merge pull request #4487 from sarenji/fix-reset-counters | Aaron Patterson | 2012-01-17 | 1 | -1/+2 |
|\ | | | | | Fix bug where reset_counters resets the wrong counter cache. | ||||
| * | Fix bug where reset_counters resets the wrong counter cache. | David Peter | 2012-01-16 | 1 | -1/+2 |
| | | | | | | | | | | | | | | | | If a model belongs_to two associations with the same class, then reset_counters will reset the wrong counter cache. Finding the right reflection should use the foreign_key instead, which should be unique. | ||||
* | | validate related records in the same validation context as parent. | Emmanuel Oga | 2012-01-17 | 2 | -2/+2 |
|/ | | | | | | | | | | | | | | | | | | | | E.G.: ```ruby class Parent < ActiveRecord::Base has_one :child validates_presence_of :name, :on => "custom_context" validates_associated :child end class Child < ActiveRecord::Base belongs_to :parent validates_presence_of :name, :on => "custom_context" end p = Parent.new(:name => "Montoto", :child => Child.new) p.valid?(:custom_context) # => Returns true, even though the child is not valid under the same context. ``` | ||||
* | Deprecate inferred JOINs with includes + SQL snippets. | Jon Leighton | 2012-01-16 | 4 | -7/+29 |
| | | | | | | See the CHANGELOG for details. Fixes #950. | ||||
* | infer references from Relation#order | Jon Leighton | 2012-01-16 | 1 | -1/+7 |
| | |||||
* | store references as a string | Jon Leighton | 2012-01-16 | 2 | -2/+2 |
| | |||||
* | Avoid sanitize_sql when we can use Relation#where instead | Jon Leighton | 2012-01-16 | 4 | -22/+16 |
| | |||||
* | automatically add references when we can | Jon Leighton | 2012-01-16 | 2 | -1/+15 |
| | |||||
* | Make referencing an included item trigger eager loading | Jon Leighton | 2012-01-16 | 1 | -1/+2 |
| | |||||
* | Add ActiveRecord::Relation#references (#950) | Jon Leighton | 2012-01-16 | 3 | -3/+21 |
| | |||||
* | Revert "Deprecate implicit eager loading. Closes #950." | Jon Leighton | 2012-01-16 | 6 | -19/+5 |
| | | | | This reverts commit c99d507fccca2e9e4d12e49b4387e007c5481ae9. | ||||
* | moving verbosity tests to the migrator test, removing ddl changes | Aaron Patterson | 2012-01-16 | 1 | -2/+1 |
| | |||||
* | silencing migrator tests, refactoring the migration test helper | Aaron Patterson | 2012-01-16 | 1 | -1/+2 |
| | |||||
* | use Rack::BodyProxy in activerecord middlewares | Sergey Nartimov | 2012-01-16 | 3 | -86/+23 |
| | |||||
* | Delegate clear_active_connections to handler as well | Carlos Antonio da Silva | 2012-01-14 | 1 | -6/+2 |
| | |||||
* | make sure the migration table is alive and empty | Aaron Patterson | 2012-01-13 | 1 | -2/+1 |
| | |||||
* | refactor schema migration table creation to the schema migration model | Aaron Patterson | 2012-01-13 | 3 | -10/+20 |
| | |||||
* | Fix race condition :bomb: | Jon Leighton | 2012-01-13 | 1 | -4/+11 |
| | |||||
* | convert the migration list to a Set, remove duplicate code | Aaron Patterson | 2012-01-13 | 2 | -16/+18 |
| | |||||
* | deprecate the block argument to Migrator#migrate | Aaron Patterson | 2012-01-13 | 1 | -8/+19 |
| | |||||
* | refactor the migrate method to filter migrations before running them | Aaron Patterson | 2012-01-13 | 1 | -25/+32 |
| | |||||
* | use the schema migration model to dump schema info | Aaron Patterson | 2012-01-13 | 2 | -3/+8 |
| | |||||
* | use the model to delete records | Aaron Patterson | 2012-01-13 | 1 | -4/+1 |
| | |||||
* | use the schema migration model to create a new record | Aaron Patterson | 2012-01-13 | 1 | -2/+1 |
| | |||||
* | moving migrator tests to a migrator test class | Aaron Patterson | 2012-01-13 | 1 | -38/+41 |
| | |||||
* | add a migration schema model | Aaron Patterson | 2012-01-13 | 2 | -3/+12 |
| | |||||
* | construct a migrator with a list of migrations rather than a list of paths | Aaron Patterson | 2012-01-13 | 1 | -18/+29 |
| | |||||
* | Fix table_name in ActiveRecord with more than one abstract ancestors | Piotr Sarnacki | 2012-01-12 | 1 | -3/+7 |
| | | | | | | | | | | | | | | | | | When subclassing abstract_class table_name should be always computed based on class name, no matter if superclass is subclassing base or another abstract_class. So: class FirstAbstract < ActiveRecord::Base self.abstract_class = true end class SecondAbstract < FirstAbstract self.abstract_class = true end class Post < SecondAbstract self.table_name #=> 'posts' (not 'second_abstracts') end | ||||
* | fixes in api docs | Vijay Dev | 2012-01-13 | 1 | -1/+1 |
| | |||||
* | AS::Callbacks: remove unused runner | Bogdan Gusiev | 2012-01-12 | 1 | -1/+1 |
| | |||||
* | on and ON are type casted to a true boolean column | Santiago Pastorino | 2012-01-11 | 1 | -2/+2 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-01-11 | 2 | -1/+12 |
|\ | |||||
| * | add documentation explaining reorder behavior | Matt Jones | 2012-01-09 | 1 | -0/+10 |
| | | |||||
| * | Expanded rdoc about primary keys being protected from mass assignment. | Joost Baaij | 2012-01-06 | 1 | -1/+2 |
| | | | | | | People need to make sure they are generated internally or added to attr_accessible so they can be mass assigned (for instance, from an import job). | ||||
* | | Revert "Base#[] and Base#[]= are aliases so implement them as aliases :)" | Tom Stuart | 2012-01-11 | 1 | -4/+6 |
| | | | | | | | | This reverts commit 21eadc1b3f2eb818a4833381ee0a6cfa205f2955. | ||||
* | | move column ordering tests to it's own class | Aaron Patterson | 2012-01-10 | 1 | -10/+2 |
| | | |||||
* | | deprecate the subdirectories parameter to `migrations` | Aaron Patterson | 2012-01-10 | 1 | -2/+10 |
| | | |||||
* | | dropping support for `schema_info`. | Aaron Patterson | 2012-01-10 | 1 | -12/+0 |
| | | |||||
* | | migrate(:down) method with table_name_prefix | kennyj | 2012-01-11 | 1 | -6/+22 |
| | | |||||
* | | no need for extra method calls inside the framework | Aaron Patterson | 2012-01-09 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #4370 from EnlightSolutions/validates_unique_association | Aaron Patterson | 2012-01-09 | 1 | -1/+14 |
|\ \ | | | | | | | Validates unique association | ||||
| * | | allow association as 1st uniqueness validation arg | Dan Pickett | 2012-01-06 | 1 | -1/+9 |
| | | | | | | | | | #4321 | ||||
| * | | allow an association as a scope parameter | Dan Pickett | 2012-01-06 | 1 | -0/+5 |
| | | | | | | | | | #4321 | ||||
* | | | Fixed after_initialize callbacks call on AR model #dup | Bogdan Gusiev | 2012-01-07 | 1 | -1/+1 |
|/ / |