aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
Commit message (Collapse)AuthorAgeFilesLines
* Update documentation for collection<< to reflect << on new records.Robert Whitney2013-03-091-2/+2
| | | | | | | | | | | | | | | | | | collection<< does not automatically fire update sql unless the parent object is not a new record (and thus has a primary key). eg: p = Post.new p.comments << Comment.new does not call update sql until: p.save at which point it saves the parent object and then the collection object. changes that to the
* Preserve magic comments and content encoding of copied migrations.OZAWA Sakuro2013-03-091-3/+12
| | | | | During insertion of "# This migration comes from ... " comment at the beginning of a migration, presence of magic comment was not considered.
* Refactored nested associations so they are more readable. Added commentswangjohn2013-03-081-26/+54
| | | | which make it clearer about what's going on.
* Fix changelog indent, remove self from method call in changelog/doc examplesCarlos Antonio da Silva2013-03-081-1/+2
| | | | [ci skip]
* The console --sandbox transaction should not be joinableJon Leighton2013-03-081-1/+2
| | | | Thanks @neerajdotname for noticing this bug.
* Make sure options is a hashRafael Mendonça França2013-03-081-1/+3
|
* Avoid short-circuit returnRafael Mendonça França2013-03-081-5/+9
|
* Merge pull request #9497 from route/subclass_from_attrsRafael Mendonça França2013-03-081-2/+3
|\ | | | | | | | | | | | | Fix ActiveRecord `subclass_from_attrs` when eager_load is false. Conflicts: activerecord/CHANGELOG.md
| * Fix ActiveRecord `subclass_from_attrs` when eager_load is false.Dmitry Vorotilin2013-03-061-2/+3
| | | | | | | | | | It cannot find subclass because all classes are loaded automatically when it needs.
* | Fix rails console --sandboxJon Leighton2013-03-081-2/+2
| | | | | | | | | | | | I've also added a proper acceptance test which reproduced the issue. Closes #9513, #9515.
* | Merge pull request #8868 from tehgeekmeister/masterRafael Mendonça França2013-03-081-0/+6
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | Use the index name explicitly provided in a migration when reverting. Fixes #8868 Conflicts: activerecord/CHANGELOG.md
| * | If an index can't be found by column, use the index name.Ezekiel Smithburg2013-03-071-0/+6
| | | | | | | | | | | | schema_statements uses the column name by default to construct the index name, and then raises an exception if it doesn't exist, even if the name option is specified, which causes #8858. this commit makes index_name_for_remove fall back to constructing the index name to remove based on the name option.
* | | Merge pull request #8966 from ↵Rafael Mendonça França2013-03-084-3/+14
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | cfabianski/disable_prepared_statement_when_preparing_a_query Unprepared Visitor + unprepared_statement Conflicts: activerecord/CHANGELOG.md
| * | | Unprepared Visitor + unprepared_statementCédric FABIANSKI2013-03-084-3/+14
| |/ /
* | | Update test name to reflect change in how scopes merging worksCarlos Antonio da Silva2013-03-081-1/+0
| | | | | | | | | | | | | | | | | | | | | Introduced in f1082b8588a9144eedb34d511f0074031f692d98. Full changelog in 9f007d7fe5f90257c71baa2c4e7c76fb44512986. [ci skip]
* | | Merge pull request #9553 from neerajdotname/7365-mergin-scopes-and-whereJon Leighton2013-03-081-3/+13
|\ \ \ | |/ / |/| | 7365 merging scopes for where clauses
| * | Combine scope conditions using ANDNeeraj Singh and John Leighton2013-03-071-3/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently Post.active.inactive will result in Post.inactive since the last where clause wins when scopes are merged. This pull request will merge all scopes ( barring defaul scope) using AND. The default scope will be overridden if another scope acts on the same where clause. closes #7365
* | | SQLite3 3.6.8+ supports savepointsNeeraj Singh2013-03-071-1/+2
|/ / | | | | | | | | http://www.sqlite.org/lang_savepoint.html https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L130-L132
* | Merge pull request #9105 from bemurphy/cache_key_updated_onRafael Mendonça França2013-03-072-1/+7
|\ \ | | | | | | | | | | | | | | | | | | cache_key consults updated_on timestamp if present Conflicts: activerecord/CHANGELOG.md
| * | cache_key consults updated_on timestamp if presentBrendon Murphy2013-02-262-1/+7
| | | | | | | | | | | | | | | - Extract max timestamp retrieval for cache_key - Update changelog for cache_key changes
* | | Merge pull request #9474 from HonoreDB/masterRafael Mendonça França2013-03-071-0/+3
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | More helpful error message when instantiating an abstract class Conflicts: activerecord/CHANGELOG.md
| * | | More helpful error message when instantiating an abstract classAaron Weiner2013-03-031-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Calling a literal ActiveRecord::Base.new raises NoMethodError, since it ends up calling Class.abstract_class? which does not exist. Similarly, instantiating an actual abstract class hits the database, when conventionally it should immediately throw NotImplementedError. ActiveRecord::Base can't be made abstract without breaking many, many things, so check for it separately.
* | | | rake db:structure:dump warns when `mysqldump` is not in PATH.Yves Senn2013-03-061-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9518. The rake task used to fail silently and left an empty `structure.sql`. It's confusing for users to get to the root of the problem. The warning message tells them where to look.
* | | | `Connection#structure_dump` is no longer used. #9518Yves Senn2013-03-062-19/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | As of ccc6910c we use `mysqldump` to create the `structure.sql`. The old `#structure_dump` code is still in AR but never used. I removed all relevant parts from the code-base.
* | | | Merge pull request #9507 from senny/9483_migrations_without_transactionsRafael Mendonça França2013-03-061-7/+37
|\ \ \ \ | |_|_|/ |/| | | Transactions can be turned off per Migration
| * | | transactions can be turned off per Migration.Yves Senn2013-03-051-7/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9483. There are SQL Queries that can't run inside a transaction. Since the Migrator used to wrap all Migrations inside a transaction there was no way to run these queries within a migration. This patch adds `self.disable_ddl_transaction!` to the migration to turn transactions off when necessary.
* | | | Merge pull request #9565 from kennyj/remove_unused_return_valueXavier Noria2013-03-052-3/+3
|\ \ \ \ | | | | | | | | | | Remove unused return value, because collecting_queries_for_explain isn't public API.
| * | | | Remove unused return value, because collecting_queries_for_explain isn't ↵kennyj2013-03-062-3/+3
| |/ / / | | | | | | | | | | | | public API.
* | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-03-052-2/+2
|\ \ \ \ | |/ / / |/| | |
| * | | Fix typoCarson McDonald2013-03-051-1/+1
| | | |
| * | | Fix WhereChain docs to mention only notErnie Miller2013-03-041-1/+1
| | | |
* | | | assigning '0.0' to a nullable numeric column does not make it dirtyYves Senn2013-03-051-1/+5
| | | |
* | | | `ActiveRecord::Base.include_root_in_json` is `false` by default.Yves Senn2013-03-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9459. The PR #6597 unified the configuration for `include_root_in_json` in AM and AR to `false`. Later on with the refactoring commit: e030f26 the value in AR was set to `true` but I think this was not on purpose. With this commit both AM and AR will have the same configuration for `include_root_in_json`, which is `false`.
* | | | Remove .all usage from unscope doc examples [ci skip]Carlos Antonio da Silva2013-03-041-4/+4
| | | |
* | | | Use 1.9 hash style in changelog and doc examples [ci skip]Carlos Antonio da Silva2013-03-041-3/+3
| | | |
* | | | Merge pull request #9200 from wangjohn/unscoping_activerecord_mergingJeremy Kemper2013-03-031-0/+94
|\ \ \ \ | | | | | | | | | | Introduce relation #unscope
| * | | | Created an unscope method for removing relations from a chain ofwangjohn2013-03-031-0/+94
| | |/ / | |/| | | | | | | | | | | | | | relations. Specific where values can be unscoped, and the unscope method still works when relations are merged or combined.
* | | | Merge pull request #9532 from neerajdotname/fix-sql-in-exampleCarlos Antonio da Silva2013-03-031-1/+2
|\ \ \ \ | |/ / / |/| | | In example fix sql that is generated from scoping
| * | | fix the sql that is generated from scopingNeeraj Singh2013-03-031-1/+2
| | | |
* | | | Remove hard coded references to Active Record in railtiesJosé Valim2013-03-023-4/+4
| | | |
* | | | Merge pull request #9431 from troyk/patch-2Andrew White2013-03-021-4/+1
|\ \ \ \ | | | | | | | | | | | | | | | Fix PostgreSQL TIMESTAMP WITH TIME ZONE to return ActiveSupport::Time
| * | | | Fix PostgreSQL TIMESTAMP WITH TIME ZONE to return ActiveSupport::TimeTroy Kruthoff2013-03-011-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In an AR model a timestamptz attribute would return a ruby string and AR tests did not check for any type casting. Previous tests would pass only because an assert_equal was being used on a Time.utc object, which will parse the right side of the eq to a valid Time instance for comparision. switch to test instance of Time instead of ActiveSupport::TimeWithZone
* | | | | deal with `#append` and `#prepend` on association collections.Yves Senn2013-03-011-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #7364. Collection associations behave similar to Arrays. However there is no way to prepend records. And to append one should use `<<`. Before this patch `#append` and `#prepend` did not add the record to the loaded association. `#append` now behaves like `<<` and `#prepend` is not defined.
* | | | | don't use non-ascii ' chars in documentationYves Senn2013-03-011-4/+4
|/ / / /
* | | | Wrong exception is occured when raising no translatable exceptionkennyj2013-03-011-0/+2
| | | |
* | | | Support PostgreSQL specific column types when using `change_table`.Yves Senn2013-02-282-6/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9480. We use `TableDefinition` for `#create_table` and `Table` for `#change_table`. The PostgreSQL sepcifc types were only defined on `TableDefinition` so I also added them to `Table`.
* | | | update docs, change_table does not use TableDefinition.Yves Senn2013-02-281-3/+3
| | | |
* | | | Revert "Merge pull request #9207 from dylanahsmith/mysql-quote-numeric"Steve Klabnik2013-02-273-13/+4
|/ / / | | | | | | | | | | | | This reverts commit 408227d9c5ed7de26310d72a1a99c1ee02311c63, reversing changes made to dca0b57d03deffc933763482e615c3cf0b9a1d97.
* | | Merge pull request #9218 from Fivell/masterCarlos Antonio da Silva2013-02-271-1/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix calculation of db_runtime property in ActiveRecord::Railties::ControllerRuntime#cleanup_view_runtime. Previously, after raising ActionView::MissingTemplate, db_runtime was not populated. Closes #9218, Fixes #9215. Conflicts: activerecord/CHANGELOG.md
| * | | fix db_runtime attribute value after raising ActionView::MissingTemplate ↵Igor2013-02-271-1/+2
| | | | | | | | | | | | | | | | exception
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-29 03:45:27 +0000