Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #3833 from kennyj/fix_3678-3 | Jon Leighton | 2011-12-03 | 1 | -3/+8 |
|\ | | | | | Use show create table (fix 3678: third time). | ||||
| * | Use show create table. | kennyj | 2011-12-03 | 1 | -3/+8 |
| | | |||||
* | | yield > block.call | Xavier Noria | 2011-12-02 | 1 | -3/+3 |
| | | |||||
* | | two small details from the previous patch | Xavier Noria | 2011-12-02 | 1 | -1/+1 |
| | | |||||
* | | implements AR::Base(.|#)silence_auto_explain | Xavier Noria | 2011-12-02 | 2 | -61/+91 |
| | | |||||
* | | indentation fix warning | Arun Agrawal | 2011-12-02 | 1 | -1/+1 |
|/ | |||||
* | revises some details in the previous explain patch | Xavier Noria | 2011-12-02 | 2 | -3/+3 |
| | |||||
* | Revert "Roflscaling!" (for now) | Jon Leighton | 2011-12-02 | 2 | -8/+11 |
| | | | | | | | | This reverts commit f6b5046305d43c5f64bcb6fed0e44f7bca99a603. Fear not, the roflscale will return when I have a bit more time and figure out a better way to do it. (In particular, a way that doesn't break the build.) | ||||
* | implements automatic EXPLAIN logging for slow queries | Xavier Noria | 2011-12-02 | 8 | -95/+212 |
| | |||||
* | Fewer string allocations in attribute method | Jon Leighton | 2011-12-01 | 1 | -4/+4 |
| | |||||
* | Roflscaling! | Jon Leighton | 2011-12-01 | 2 | -11/+8 |
| | | | | | Don't prefix the name with attribute_. Avoids a string allocation on read_attribute, which is a bit faster. | ||||
* | Create method with known identifier then alias into place. | Jon Leighton | 2011-12-01 | 1 | -25/+21 |
| | | | | | | | | This means we never have to rely on define_method (which is slower and uses more memory), even when we have attributes containing characters that are not allowed in standard method names. (I am mainly changing this because the duplication annoys me, though.) | ||||
* | Remove some unnecessary code etc | Jon Leighton | 2011-12-01 | 2 | -26/+11 |
| | |||||
* | Add test for read_attribute(:id) with non-standard PK. | Jon Leighton | 2011-12-01 | 2 | -4/+18 |
| | | | | | | | | Also make it actually work. It slows down all read_attribute accesses to map 'id' to whatever the PK actually is, inside read_attribute. So instead make sure the necessary methods are defined and that they redirect wherever they need to go. | ||||
* | Remove the need for type_cast_attribute. | Jon Leighton | 2011-12-01 | 5 | -43/+52 |
| | | | | This is good because it reduces duplication. | ||||
* | Get rid of the underscore versions of attribute methods! | Jon Leighton | 2011-12-01 | 4 | -6/+34 |
| | | | | This makes me happy! | ||||
* | Don't rely on underscore-prefixed attribute methods. | Jon Leighton | 2011-12-01 | 3 | -48/+80 |
| | | | | | | Define singleton methods on the attributes module instead. This reduces method pollution on the actual model classes. It also seems to make something faster, I am unsure why! O_o | ||||
* | Remove unnecessary *args | Jon Leighton | 2011-12-01 | 1 | -2/+2 |
| | |||||
* | Allow rescue responses to be configured through a railtie. | José Valim | 2011-12-01 | 1 | -0/+7 |
| | |||||
* | Add hackery to make Syck use encode_with/init_with. Fixes 1.8 after recent ↵ | Jon Leighton | 2011-12-01 | 1 | -0/+20 |
| | | | | changes to attribute serialization. | ||||
* | If the table behind has no primary key, do not ask again and just return nil. | Julius de Bruijn | 2011-11-30 | 1 | -1/+2 |
| | |||||
* | consistency | Jon Leighton | 2011-11-30 | 3 | -16/+16 |
| | |||||
* | Don't check column type, you might implement a custom coder that serializes ↵ | Jon Leighton | 2011-11-30 | 1 | -1/+1 |
| | | | | to a different type | ||||
* | omg computer science! | Jon Leighton | 2011-11-30 | 3 | -24/+46 |
| | | | | | | | Implement a mini state machine for serialized attributes. This means we do not have to deserialize the values upon initialization, which means that if we never actually access the attribute, we never have to deserialize it. | ||||
* | Don't need second param | Jon Leighton | 2011-11-30 | 2 | -4/+4 |
| | |||||
* | No longer need to undef id as we are defining it ourselves | Jon Leighton | 2011-11-30 | 1 | -3/+0 |
| | |||||
* | Move some serialization stuff out of Base | Jon Leighton | 2011-11-30 | 2 | -40/+42 |
| | |||||
* | Extract attribute serialization code into a separate module | Jon Leighton | 2011-11-30 | 3 | -28/+48 |
| | |||||
* | Use inheritance to avoid special-case code for the 'id' method | Jon Leighton | 2011-11-30 | 3 | -8/+20 |
| | |||||
* | #id is an alias for whatever the primary key is | Jon Leighton | 2011-11-30 | 1 | -1/+1 |
| | |||||
* | fix indent | Jon Leighton | 2011-11-30 | 1 | -3/+3 |
| | |||||
* | s/is is/is | Vijay Dev | 2011-12-01 | 1 | -1/+1 |
| | |||||
* | Revert "Implement ArraySerializer and move old serialization API to a new ↵ | José Valim | 2011-11-30 | 2 | -4/+4 |
| | | | | | | | | | | | | | namespace." This reverts commit 8896b4fdc8a543157cdf4dfc378607ebf6c10ab0. Conflicts: activemodel/lib/active_model.rb activemodel/lib/active_model/serializable.rb activemodel/lib/active_model/serializer.rb activemodel/test/cases/serializer_test.rb | ||||
* | ActiveRecord::Relation#pluck method | Bogdan Gusiev | 2011-11-30 | 3 | -2/+19 |
| | |||||
* | push synchronization in to each method. Reduces method calls and makes | Aaron Patterson | 2011-11-29 | 1 | -25/+29 |
| | | | | it clear which methods are synchronized. | ||||
* | Automatic closure of connections in threads is deprecated. For example | Aaron Patterson | 2011-11-29 | 1 | -1/+7 |
| | | | | | | | | | | | | | | | | | the following code is deprecated: Thread.new { Post.find(1) }.join It should be changed to close the database connection at the end of the thread: Thread.new { Post.find(1) Post.connection.close }.join Only people who spawn threads in their application code need to worry about this change. | ||||
* | AbstractAdapter#close can be called to add the connection back to the | Aaron Patterson | 2011-11-29 | 2 | -11/+19 |
| | | | | pool. | ||||
* | Start implementing @reserved_connections in terms of connection leases. | Aaron Patterson | 2011-11-29 | 1 | -3/+3 |
| | |||||
* | Rename `checked_out` to more descriptive `active_connections` | Aaron Patterson | 2011-11-29 | 1 | -3/+3 |
| | |||||
* | Use connection lease to determine "checked_out" connections | Aaron Patterson | 2011-11-29 | 1 | -17/+21 |
| | |||||
* | expire will set in_use to false | Aaron Patterson | 2011-11-29 | 1 | -0/+5 |
| | |||||
* | Leased connections return false on second lease | Aaron Patterson | 2011-11-29 | 1 | -2/+4 |
| | |||||
* | Adapters keep in_use flag when leased | Aaron Patterson | 2011-11-29 | 1 | -1/+14 |
| | |||||
* | Fix ruby 1.8 compat. const_defined? only takes a second arg on 1.9. | Jon Leighton | 2011-11-29 | 1 | -3/+4 |
| | |||||
* | Deprecated `define_attr_method` in `ActiveModel::AttributeMethods` | Jon Leighton | 2011-11-29 | 1 | -2/+2 |
| | | | | | This only existed to support methods like `set_table_name` in Active Record, which are themselves being deprecated. | ||||
* | Deprecate set_locking_column in favour of self.locking_column= | Jon Leighton | 2011-11-29 | 1 | -8/+13 |
| | |||||
* | Deprecate set_primary_key in favour of self.primary_key= | Jon Leighton | 2011-11-29 | 2 | -21/+27 |
| | |||||
* | Make sure the original_foo accessor still works (but deprecated) if we are ↵ | Jon Leighton | 2011-11-29 | 1 | -6/+31 |
| | | | | using self.foo= | ||||
* | extract method | Jon Leighton | 2011-11-29 | 1 | -49/+25 |
| | |||||
* | Deprecate set_sequence_name in favour of self.sequence_name= | Jon Leighton | 2011-11-29 | 1 | -11/+28 |
| |