Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Add tests for set_sequence_name etc | Jon Leighton | 2011-11-29 | 1 | -1/+1 | |
| | ||||||
* | Deprecate set_inheritance_column in favour of self.inheritance_column= | Jon Leighton | 2011-11-29 | 1 | -17/+29 | |
| | ||||||
* | Deprecate set_table_name in favour of self.table_name= or defining your own ↵ | Jon Leighton | 2011-11-29 | 1 | -22/+59 | |
| | | | | method. | |||||
* | respond_to? information of AR is not the responsibility of the spec | Aaron Patterson | 2011-11-29 | 1 | -7/+9 | |
| | | | | resolver. | |||||
* | Merge pull request #3636 from joshsusser/master | Jon Leighton | 2011-11-29 | 8 | -21/+56 | |
|\ | | | | | association methods are now generated in modules | |||||
| * | avoid warnings | Josh Susser | 2011-11-27 | 6 | -15/+15 | |
| | | | | | | | | | | | | | | This change uses Module.redefine_method as defined in ActiveSupport. Making Module.define_method public would be as clean in the code, and would also emit warnings when redefining an association. That is pretty messy given current tests, so I'm leaving it for someone else to decide what approach is better. | |||||
| * | changelog & docs for GeneratedFeatureMethods | Josh Susser | 2011-11-27 | 1 | -0/+20 | |
| | | ||||||
| * | use GeneratedFeatureMethods module for associations | Josh Susser | 2011-11-27 | 4 | -13/+27 | |
| | | ||||||
| * | association methods are now generated in modules | Josh Susser | 2011-11-15 | 8 | -30/+31 | |
| | | | | | | | | | | | | | | | | | | | | Instead of generating association methods directly in the model class, they are generated in an anonymous module which is then included in the model class. There is one such module for each association. The only subtlety is that the generated_attributes_methods module (from ActiveModel) must be forced to be included before association methods are created so that attribute methods will not shadow association methods. | |||||
* | | remove unused instance variable | Aaron Patterson | 2011-11-28 | 1 | -1/+0 | |
| | | ||||||
* | | just check in all connections | Aaron Patterson | 2011-11-28 | 1 | -6/+2 | |
| | | ||||||
* | | remove useless class_eval | Aaron Patterson | 2011-11-28 | 1 | -2/+0 | |
| | | ||||||
* | | Move connection resoluion logic to it's own testable class. | Aaron Patterson | 2011-11-28 | 1 | -58/+74 | |
| | | ||||||
* | | clean up string => hash conversion for connection pool | Aaron Patterson | 2011-11-28 | 1 | -19/+17 | |
| | | ||||||
* | | pools are 1:1 with spec now rather than 1:1 with class | Aaron Patterson | 2011-11-28 | 2 | -4/+8 | |
| | | ||||||
* | | break establish_connection to smaller methods | Aaron Patterson | 2011-11-28 | 1 | -30/+40 | |
| | | ||||||
* | | added information about callbacks created by autosave association (#3639) | Jakub Kuźma | 2011-11-28 | 1 | -4/+16 | |
| | | ||||||
* | | Merge pull request #3768 from janv/master | Aaron Patterson | 2011-11-28 | 1 | -1/+1 | |
|\ \ | | | | | | | Test and fix for Issue 3450 | |||||
| * | | Test case and fix for rails/rails#3450 | Jan Varwig | 2011-11-27 | 1 | -1/+1 | |
| | | | | | | | | | | | | Asssigning a parent id to a belongs_to association actually updates the object that is validated when the association has :validates => true | |||||
* | | | Merge pull request #3657 from arunagw/mysql2_bump_master | José Valim | 2011-11-28 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | Bump Mysql2! | |||||
| * | | | Bump Mysql2! | Arun Agrawal | 2011-11-22 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Revert "Use any instead of length" | José Valim | 2011-11-28 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | This reverts commit 1756629835d39f60ef4c96aff81ac503c71b98b7. | |||||
* | | | | Merge pull request #3748 from samsonasu/has_many_custom_pk_new_record | Jon Leighton | 2011-11-27 | 2 | -1/+5 | |
|\ \ \ \ | | | | | | | | | | | New records should load has_many relationships with custom primary keys | |||||
| * | | | | load has_many associations keyed off a custom primary key if that key is ↵ | Brian Samson | 2011-11-25 | 2 | -1/+5 | |
| |/ / / | | | | | | | | | | | | | present but the record is unsaved | |||||
* | / / | Use any instead of length | Rahul P. Chaudhari | 2011-11-27 | 1 | -1/+1 | |
| |/ / |/| | | ||||||
* | | | add the query to AR::Relation#explain output | Xavier Noria | 2011-11-25 | 1 | -2/+3 | |
| | | | | | | | | | | | | | | | | | | | | | Rationale: this is more readable if serveral queries are involved in one call. Also, it will be possible to let AR log EXPLAINs automatically in production mode, where queries are not even around. | |||||
* | | | Implement ArraySerializer and move old serialization API to a new namespace. | José Valim | 2011-11-23 | 2 | -4/+4 | |
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | The following constants were renamed: ActiveModel::Serialization => ActiveModel::Serializable ActiveModel::Serializers::JSON => ActiveModel::Serializable::JSON ActiveModel::Serializers::Xml => ActiveModel::Serializable::XML The main motivation for such a change is that `ActiveModel::Serializers::JSON` was not actually a serializer, but a module that when included allows the target to be serializable to JSON. With such changes, we were able to clean up the namespace to add true serializers as the ArraySerializer. | |||||
* | | oops! I suck! :bomb: | Aaron Patterson | 2011-11-20 | 1 | -1/+0 | |
| | | ||||||
* | | removing deprecated methods | Aaron Patterson | 2011-11-19 | 3 | -26/+0 | |
| | | ||||||
* | | adding visitors to the respective adapters | Aaron Patterson | 2011-11-19 | 2 | -0/+2 | |
| | | ||||||
* | | pushing caching and visitors down to the connection | Aaron Patterson | 2011-11-19 | 7 | -93/+119 | |
| | | ||||||
* | | Perf fix | Jon Leighton | 2011-11-19 | 1 | -2/+6 | |
| | | | | | | | | | | | | | | If we're deleting all records in an association, don't add a IN(..) clause to the query. Fixes #3672. | |||||
* | | Use `show index from`. We could fix `pk_and_sequence_for` method's ↵ | kennyj | 2011-11-19 | 2 | -21/+3 | |
| | | | | | | | | performance problem (GH #3678) | |||||
* | | Only used detailed schema introspection when doing a schema dump. | Christos Zisopoulos | 2011-11-18 | 2 | -1/+10 | |
| | | | | | | Fixes #3678 | |||||
* | | Stop db:seed from performing a reload of the db | Sam Ruby | 2011-11-18 | 1 | -2/+2 | |
| | | | | | | | | Fix regression introduced by 38d26b0cb56d82093889efa95992a35ba3bb9f29 | |||||
* | | Merge pull request #3666 from oscardelben/databases_rake_cleanup | Vijay Dev | 2011-11-18 | 1 | -8/+9 | |
|\ \ | | | | | | | Cleanup of databases.rake psql env variables | |||||
| * | | Cleanup of databases.rake psql env variables | Oscar Del Ben | 2011-11-17 | 1 | -8/+9 | |
| | | | ||||||
* | | | Revert "Merge pull request #1163 from amatsuda/sexier_migration_31" | Aaron Patterson | 2011-11-17 | 3 | -22/+13 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0e407a90413d8a19002b85508d811ccdf2190783, reversing changes made to 533a9f84b035756eedf9fdccf0c494dc9701ba72. Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/migration_test.rb | |||||
* | | | Revert "Merge pull request #3603 from vijaydev/change_table_without_block_arg" | Aaron Patterson | 2011-11-17 | 1 | -12/+7 | |
|/ / | | | | | | | | | | | | | | | | | This reverts commit 81fad6a270ec3cbbb88553c9f2e8200c34fd4d13, reversing changes made to 23101de283de13517e30c4c3d1ecc65525264886. Conflicts: activerecord/test/cases/migration_test.rb | |||||
* | | No need to `readlines` then `join`, just use `read` :heart: | Arun Agrawal | 2011-11-17 | 1 | -1/+1 | |
| | | | | | | same as 4c1a1933cbc5ab96efe340a3b31ac5fee12c99c8 | |||||
* | | No need to `readlines` then `join`, just use `read` :heart: | Aaron Patterson | 2011-11-16 | 1 | -1/+1 | |
| | | ||||||
* | | Adding a deprecation warning for use of the schema_info table. | Aaron Patterson | 2011-11-16 | 1 | -0/+2 | |
| | | ||||||
* | | Join method uses empty string by default, so remove it | Aaron Patterson | 2011-11-16 | 1 | -2/+2 | |
| | | ||||||
* | | dbfile isn't supported anymore, so remove | Aaron Patterson | 2011-11-16 | 1 | -3/+3 | |
| | | ||||||
* | | Reduce schema format tests | Aaron Patterson | 2011-11-16 | 1 | -10/+14 | |
| | | ||||||
* | | Move conditionals to separate tasks so they can be reused. | Aaron Patterson | 2011-11-16 | 1 | -7/+11 | |
| | | ||||||
* | | `ActiveRecord::Base#becomes` should retain the errors of the original object. | James Adam | 2011-11-16 | 1 | -0/+1 | |
| | | | | | | | | This commit contains a simple failing test that demonstrates the behaviour we expect, and a fix. When using `becomes` to transform the type of an object, it should retain any error information that was present on the original instance. | |||||
* | | removing some useless conditionals | Aaron Patterson | 2011-11-16 | 1 | -10/+8 | |
| | | ||||||
* | | Merge pull request #2948 from atambo/master | Aaron Patterson | 2011-11-16 | 1 | -38/+66 | |
|\ \ | | | | | | | schema_format :sql should behave like schema_format :ruby | |||||
| * | | schema_format :sql should behave like schema_format :ruby | Alex Tambellini | 2011-11-04 | 1 | -38/+66 | |
| | | | | | | | | | | | | | | | | | | | | | This commit adds a db:structure:load task that is run instead of db:schema:load when schema_format is set to :sql. This patch also removes the prefixing of the structure.sql files to mimic the use of a single schema.rb file. The patch originates from github issue #715. |