Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Revert "unscoped takes care of named_scopes too" | Neeraj Singh | 2010-11-22 | 1 | -1/+2 |
| | | | | This reverts commit 126fbd7ed8a310bf940414c1b7ddab06b03d400e. | ||||
* | unscoped takes care of named_scopes too | Neeraj Singh | 2010-11-17 | 1 | -2/+1 |
| | |||||
* | if association is already loaded and if a find operation is performed on the ↵ | Neeraj Singh | 2010-11-15 | 1 | -1/+2 |
| | | | | | | already loaded association list with an empty hash then do not perform another sql [#5972 state:resolved] | ||||
* | Remove unused var | Santiago Pastorino | 2010-11-14 | 1 | -1/+1 |
| | |||||
* | Fix bug where size of through association is not correct after adding a ↵ | Jason Cheow | 2010-11-14 | 1 | -1/+0 |
| | | | | | | | | has_many association (occurs only before main object has been reloaded). [#5968 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Finder gives a little bit more info on the lookup column (primary key) | Franck Verrot | 2010-11-13 | 1 | -1/+1 |
| | |||||
* | present? is better here | Santiago Pastorino | 2010-11-11 | 1 | -1/+1 |
| | |||||
* | Merge remote branch 'drogus/plugin_new' | José Valim | 2010-11-11 | 1 | -1/+1 |
|\ | | | | | | | | | Conflicts: railties/test/generators/app_generator_test.rb | ||||
| * | Use application's generators defaults as engine defaults to not force users ↵ | Piotr Sarnacki | 2010-11-02 | 1 | -1/+1 |
| | | | | | | | | to manually set it | ||||
* | | STI type is now updated when calling AR::Base.becomes on subclasses [#5953 ↵ | Franck Verrot | 2010-11-12 | 1 | -0/+1 |
| | | | | | | | | state:resolved] | ||||
* | | Use ! instead of not | Santiago Pastorino | 2010-11-11 | 1 | -1/+1 |
| | | |||||
* | | Fixed bug in active_record/nested_attributes where an empty string id caused ↵ | Santiago Pastorino | 2010-11-11 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | an ActiveRecord::RecordNotFound error. Found by [Ben Tillman] [#5638 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | | Allow AR Session Store to be renewed | José Valim | 2010-11-11 | 1 | -0/+1 |
| | | |||||
* | | Double negation of an already boolean value produces the same result | Santiago Pastorino | 2010-11-09 | 1 | -1/+1 |
| | | |||||
* | | Don't check if persisted is defined just initialize it properly | Santiago Pastorino | 2010-11-09 | 3 | -4/+1 |
| | | |||||
* | | Execute less operations | Santiago Pastorino | 2010-11-09 | 1 | -2/+1 |
| | | |||||
* | | use persisted? instead of new_record? wherever possible | David Chelimsky | 2010-11-09 | 19 | -64/+71 |
| | | | | | | | | | | | | | | | | | | | | | | - persisted? is the API defined in ActiveModel - makes it easier for extension libraries to conform to ActiveModel APIs without concern for whether the extended object is specifically ActiveRecord [#5927 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | | Update the validates_uniqueness_of documentation to tell you to use a unique ↵ | Michael Koziarski | 2010-11-08 | 1 | -25/+17 |
| | | | | | | | | | | | | index. The other options mentioned were not good ideas and disclaimed as such in the documentation. | ||||
* | | use column names as order by complex function parameters, fix for postgresql ↵ | Raimonds Simanovskis | 2010-11-07 | 1 | -1/+1 |
| | | | | | | | | | | | | adapter to correctly remove ASC/DESC Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | | reduce duplication in assiciations #construct() | Aaron Patterson | 2010-11-06 | 1 | -9/+3 |
| | | |||||
* | | make sure we keep parent records in order | Aaron Patterson | 2010-11-06 | 1 | -6/+6 |
| | | |||||
* | | only call to_s on the association variable once | Aaron Patterson | 2010-11-05 | 1 | -2/+5 |
| | | |||||
* | | simplify instantiate in the join parts object | Aaron Patterson | 2010-11-05 | 1 | -8/+7 |
| | | |||||
* | | index is not used, so removing it | Aaron Patterson | 2010-11-05 | 1 | -1/+1 |
| | | |||||
* | | reduce method calls to the join base object | Aaron Patterson | 2010-11-05 | 1 | -4/+6 |
| | | |||||
* | | stop recursively calling exists? | Aaron Patterson | 2010-11-05 | 1 | -3/+5 |
| | | |||||
* | | Avoid warning: shadowing outer local variable | Santiago Pastorino | 2010-11-05 | 1 | -2/+2 |
| | | |||||
* | | Fixes queries using limits and punctuation in order, removes order("col1, ↵ | Santiago Pastorino | 2010-11-05 | 2 | -4/+4 |
| | | | | | | | | | | | | col2") usage in favor of order(["col1", "col2"}) [#4597 state:committed] | ||||
* | | renaming exec in the mysql adapter | Aaron Patterson | 2010-11-05 | 1 | -2/+2 |
| | | |||||
* | | renaming exec in the PG adapter | Aaron Patterson | 2010-11-05 | 1 | -3/+3 |
| | | |||||
* | | converted exec to exec_query for sqlite | Aaron Patterson | 2010-11-05 | 2 | -12/+12 |
| | | |||||
* | | Association Proxy should not undefine the default respond_to_missing | sblackstone | 2010-11-04 | 1 | -1/+1 |
|/ | |||||
* | Make should_record_timestamps? serialization aware rather than object#changed? | Pratik Naik | 2010-11-02 | 2 | -5/+1 |
| | |||||
* | Ensure save always updates timestamps when serialized attributes are present | Pratik Naik | 2010-11-02 | 1 | -0/+4 |
| | |||||
* | only returning where values for the corresponding relation, also filtering ↵ | Aaron Patterson | 2010-10-30 | 2 | -6/+12 |
| | | | | where value hash based on table name [#5234 state:resolved] [#5184 state:resolved] | ||||
* | no need to merge where values if no new where values have been added | Aaron Patterson | 2010-10-30 | 1 | -11/+13 |
| | |||||
* | Convert :primary_key in association to a string before comparing to column ↵ | Denis Odorcic | 2010-10-30 | 1 | -1/+1 |
| | | | | names, so that for example :primary_key => :another_pk works as well [#5605 state:resolved] | ||||
* | refactoring find_join_association | Aaron Patterson | 2010-10-30 | 1 | -5/+6 |
| | |||||
* | Fix issues when including the same association multiple times and mixing ↵ | Ernie Miller | 2010-10-30 | 1 | -11/+37 |
| | | | | joins/includes together. | ||||
* | Refactoring: replace the mix of variables like @finder_sql, @counter_sql, ↵ | Jon Leighton | 2010-10-30 | 11 | -159/+146 |
| | | | | etc with just a single scope hash (created on initialization of the proxy). This is now used consistently across all associations. Therefore, all you have to do to ensure finding/counting etc is done correctly is implement the scope correctly. | ||||
* | only do string substitution on column names once, remove intermediate data ↵ | Aaron Patterson | 2010-10-30 | 1 | -7/+6 |
| | | | | structures | ||||
* | columns are always strings | Aaron Patterson | 2010-10-30 | 1 | -1/+1 |
| | |||||
* | no need to to_i, sqlite does that for us | Aaron Patterson | 2010-10-30 | 1 | -2/+2 |
| | |||||
* | select_all() should always return an array, so no need to test | Aaron Patterson | 2010-10-27 | 1 | -9/+1 |
| | |||||
* | speeding up query cache | Aaron Patterson | 2010-10-27 | 2 | -5/+4 |
| | |||||
* | making query cache work with prepared statements | Aaron Patterson | 2010-10-27 | 1 | -6/+7 |
| | |||||
* | renaming bind_values to binds where it makes sense | Aaron Patterson | 2010-10-26 | 5 | -19/+19 |
| | |||||
* | adding backwards compatibility for non-prepare statement handling drivers | Aaron Patterson | 2010-10-26 | 4 | -2/+34 |
| | |||||
* | caching column values | Aaron Patterson | 2010-10-26 | 1 | -4/+11 |
| | |||||
* | setting the authorized session clears the statement cache | Aaron Patterson | 2010-10-26 | 1 | -0/+1 |
| |