aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
Commit message (Collapse)AuthorAgeFilesLines
* Deprecate eager-evaluated scopes.Jon Leighton2012-03-212-12/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't use this: scope :red, where(color: 'red') default_scope where(color: 'red') Use this: scope :red, -> { where(color: 'red') } default_scope { where(color: 'red') } The former has numerous issues. It is a common newbie gotcha to do the following: scope :recent, where(published_at: Time.now - 2.weeks) Or a more subtle variant: scope :recent, -> { where(published_at: Time.now - 2.weeks) } scope :recent_red, recent.where(color: 'red') Eager scopes are also very complex to implement within Active Record, and there are still bugs. For example, the following does not do what you expect: scope :remove_conditions, except(:where) where(...).remove_conditions # => still has conditions
* Avoid obscure &Proc.new thingJon Leighton2012-03-211-2/+2
|
* Remove valid_scope_name? check - use rubyJon Leighton2012-03-211-11/+1
| | | | | | | scope is syntactic sugar for defining a class method. Ruby allows redefining methods but emits a warning when run with -w. So let's not implement our own logic for this. Users should run with -w if they want to be warned about redefined methods.
* no need for castJon Leighton2012-03-211-1/+0
|
* no need for lvarJon Leighton2012-03-211-3/+1
|
* Merge pull request #3329 from armstrjare/autosave_collection_new_record_bugJosé Valim2012-03-181-1/+6
|\ | | | | Autosave association doesn't save all records on a new record for a collection association if there are records marked for destruction
| * Fix bug with autosave collection association on new record with a marked for ↵Jared Armstrong2012-03-181-1/+6
| | | | | | | | destroy record in autosave collection.
* | Merge pull request #5486 from kennyj/fix_5435Aaron Patterson2012-03-171-0/+1
|\ \ | | | | | | Fix GH #5435. db:structure:dump should be re-enable.
| * | Fix GH #5435. db:structure:dump should be reenable.kennyj2012-03-171-0/+1
| | |
* | | Updates 'modyfing' typo to 'modifying'Jonathan R. Wallace2012-03-171-1/+1
| | |
* | | Merge pull request #5321 from pfeiffer/uniqueness_validator_conditionsJosé Valim2012-03-171-2/+18
|\ \ \ | |/ / |/| | Add :conditions option to uniqueness validator
| * | Correct grammar in documentationMattias Pfeiffer2012-03-071-1/+1
| | |
| * | Change syntax to accept an AR::Relation instead of old conditions hash/array.Mattias Pfeiffer2012-03-071-3/+9
| | |
| * | Add :conditions option to uniqueness validatorMattias Pfeiffer2012-03-071-2/+12
| | |
* | | Merge pull request #5467 from bogdan/initialize_callbacksJosé Valim2012-03-161-1/+1
|\ \ \ | |_|/ |/| | ActiveRecord::Core#initialize: improve performance
| * | ActiveRecord::Core#initialize: improve performanceBogdan Gusiev2012-03-151-1/+1
| | |
* | | Merge pull request #5461 from yakko/masterJosé Valim2012-03-161-0/+4
|\ \ \ | | | | | | | | relation .present? and .blank? should not query SELECT COUNT(DISTINCT id)
| * | | relation .present? and .blank? should not query SELECT COUNT(DISTINCT id)Thiago Almeida2012-03-161-0/+4
| | | |
* | | | Merge pull request #5327 from kennyj/fix_explicitly_inheraitance_columnAaron Patterson2012-03-151-1/+2
|\ \ \ \ | |/ / / |/| | | Don't reset inheritance_column when setting explicitly.
| * | | Don't reset inheritance_column when setting explicitly.kennyj2012-03-081-1/+2
| | | |
* | | | errors should probably be logged as errorsAaron Patterson2012-03-151-20/+19
| | | |
* | | | Fix GH #5430. A Payload name for schema_search_path should be SCHEMA.kennyj2012-03-151-1/+1
| |/ / |/| |
* | | Remove IdentityMapCarlos Antonio da Silva2012-03-1314-242/+10
| | |
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-03-131-1/+3
|\ \ \
| * | | added clarification stating the counter_cache attribute needs to be created ↵Michael de Silva2012-03-111-1/+3
| | | | | | | | | | | | | | | | on the associate class via a migration
* | | | Fix GH #5399. connection_pools's keys are ↵kennyj2012-03-141-1/+1
| | | | | | | | | | | | | | | | ActiveRecord::Base::ConnectionSpecification objects.
* | | | Merge pull request #5294 from robinroestenburg/masterAaron Patterson2012-03-123-26/+53
|\ \ \ \ | | | | | | | | | | Refactoring of `arel_attributes_values` method
| * | | | Removed flag attributes.Robin Roestenburg2012-03-063-22/+35
| | | | |
| * | | | Refactored method arel_attributes_values.Robin Roestenburg2012-03-061-20/+34
| | | | |
* | | | | make sure connections returned after close are marked as in_useAaron Patterson2012-03-121-4/+17
| | | | |
* | | | | deprecated clear_stale_active_connections! can call #reap instead of ↵Jonathan Rochkind2012-03-121-1/+2
| | | | | | | | | | | | | | | | | | | | no-op'ing, #reap does the same thing
* | | | | Add documentation for find_or_create_by_{attribute}! method.Andrew White2012-03-121-0/+3
| | | | |
* | | | | Add dynamic find_or_create_by_{attribute}! method.Andrew White2012-03-122-2/+26
| | | | |
* | | | | fix activerecord query_method regression with offset into FixnumDenis Jean2012-03-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add test to show offset query_methods on mysql & mysql2 change test to cover public API
* | | | | In AR depths use &:to_i before :uniq to process mixed arrays likes ["1", 1] ↵Alexey Vakhov2012-03-091-1/+1
| | | | | | | | | | | | | | | | | | | | correct
* | | | | make active_connection? return true only if there is an open connection in ↵Aaron Patterson2012-03-081-7/+4
| |/ / / |/| | | | | | | | | | | use for the current thread. fixes #5330
* | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-03-091-2/+2
|\ \ \ \
| * | | | Fix doc examples for has_and_belongs_to_many associationBraden Schaeffer2012-03-051-2/+2
| | | | |
* | | | | Merge pull request #5289 from rafaelfranca/fix-through-associationsJon Leighton2012-03-082-4/+10
|\ \ \ \ \ | | | | | | | | | | | | Fix has_many through associations when mass_assignment_sanitizer is strict
| * | | | | Not need to pass join attributes to association buildRafael Mendonça França2012-03-072-4/+10
| | |/ / / | |/| | |
* | | | | Merge pull request #5162 from kennyj/schema_cache_dumpAaron Patterson2012-03-074-17/+88
|\ \ \ \ \ | | | | | | | | | | | | [Proposal] Schema cache dump
| * | | | | Support judgement expired schema cache dump.kennyj2012-03-012-4/+11
| | | | | |
| * | | | | Load db/schema_cache.dump duaring boot time.kennyj2012-03-013-2/+18
| | | | | |
| * | | | | Add db:schema:cache:dump and db:schema:cache:clear tasks.kennyj2012-03-012-0/+28
| | | | | |
| * | | | | Add support schema cache dump and load.kennyj2012-03-011-14/+34
| | | | | |
* | | | | | Merge pull request #5315 from ↵Aaron Patterson2012-03-071-0/+21
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | travisjeffery/enhance_postgresql_adapter_schema_support Enhance PostgreSQL Adapter schema support
| * | | | | | Adds #create/drop_schema on the PostgreSQL Adapter.Travis Jeffery2012-03-071-0/+10
| | | | | | |
| * | | | | | Add #schema_names to PostgreSQL Adapter.Travis Jeffery2012-03-071-0/+11
| | | | | | |
* | | | | | | Merge pull request #5316 from Jacobkg/masterJosé Valim2012-03-071-1/+1
|\ \ \ \ \ \ \ | |_|_|_|_|/ / |/| | | | | | Update ActiveRecord::AttributeMethods#attribute_present? to return false for empty strings
| * | | | | | attribute_present? should return false for empty stringsJacob Green2012-03-061-1/+1
| | |_|_|_|/ | |/| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-16 16:18:28 +0000