| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
| |
This patch registers custom domains in our OID-type_map.
They will behave exactly as the type specified by `pg_type.typbasetype`.
/cc @matthewd
|
|\
| |
| | |
PostgreSQL determine `Column#type` through corresponding OID. #7814
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I ran the whole test suite and compared the old to the new types.
Following is the list of types that did change with this patch:
```
DIFFERENT TYPE FOR mood: NEW: enum, BEFORE:
DIFFERENT TYPE FOR floatrange: NEW: floatrange, BEFORE: float
```
The `floatrange` is a custom type. The old type `float` was simply a coincidence
form the name `floatrange` and our type-guessing.
|
|\ \
| | |
| | |
| | |
| | | |
eileencodes/fix_delete_all_to_not_use_IN_statement
Fix delete all to not produce sql in statement
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When delete_all is run on a CollectionProxy and has a
dependency of delete_all the SQL that is produced has an IN
statement. (DELETE FROM `associated_model` where `associated_model`
.`parent_id` = 1 AND `associated_model`.`id` IN (1, 2, 3...)).
This only happens if the association is not loaded (both loaded
and non-loaded delete_all should behave the same. This is a huge
problem when it comes to deleting many records because the query
becomes very slow. Instead the SQL produced should be (DELETE FROM
`assoicated_model` where `associated_model`.`parent_model_id`=1).
I fixed this by making sure the check for loaded and destroy also
makes sure that the dependent is not delete_all, so the conditional
goes to the else and deletes the records directly without the IN
statement.
|
|\ \
| |/
|/| |
Fix polymorphic preloads on NOT NULL _type columns
|
| |
| |
| |
| |
| |
| | |
The new method relies on AR::Associations::Association knowing about both reflection and a model class.
AR::Base#association now raises a descriptive error when trying to access non-existent associations. Previously it would blow up with a confusing NoMethodError: undefined method `association_class' for nil:NilClass.
|
| |
| |
| |
| | |
Defer to Association#klass instead of having a custom/duplicate code.
|
| |
| |
| |
| |
| | |
We have `connection_adapters/column.rb` so it's easier to remember
that the column in in a separate file.
|
| | |
|
| |
| |
| |
| | |
fixes #10613
|
|/
|
|
| |
It is already called inside type_to_sql method.
|
|\
| |
| | |
Ensure we are returning either `true` or `false` for `#==`
|
| |
| |
| |
| |
| |
| | |
460eb83d cused `ActiveRecord::Base#==` to sometimes return `nil` in some cases,
this ensures we always return a boolean value. Also fixed a similar problem in
AR reflections.
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The group method also takes an array, however this isn't immediately
clear by reading the source since it delegates this method. If you
trace it back to the AREL building you can see that it does support
an array.
Shoutout to @betovelandia for pointing this out.
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Pass a base relation to build_default_scope when joining
|
| | |
| | |
| | |
| | |
| | | |
This allows the default scope to be built using the current table alias.
Resolves #12770
|
| | |
| | |
| | |
| | | |
Swap Timestamp/Callbacks order in ActiveRecord::Base
|
| | |
| | |
| | |
| | | |
custom primary_key that didn't save due to validation error
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It's unintuitive to call '#valid?' when you want to run validations but
don't care about the return value.
The alias in ActiveRecord isn't strictly necessary (the ActiveModel
alias is still in effect), but it clarifies.
|
| | |
| | |
| | |
| | |
| | | |
This method is not being called anywhere in our code and a GitHub search
show it is not being used in any project.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
* cache `o.name` value
* Avoid extra `concat` call
* Avoid extra `<<` call
|
| | |
| | |
| | |
| | |
| | | |
These comments will likely be outdated with time and doesn't include
any information that can't be found in the adapters
|
| | |
| | |
| | |
| | | |
Also improve some of the code conventions
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
existence
Also:
- updates tests by stubbing table_exists? method
- adds entry for creating indexes in CREATE TABLE to changelog
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is important, because adding an index on a temporary table after
it has been created would commit the transaction
Conflicts:
activerecord/CHANGELOG.md
|
|\ \ \
| | | |
| | | |
| | | | |
Still touch associations when theres no timestamp
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Prior to Rails 4.0.4 when touching a object which doesn't have timestamp
attributes (updated_at / updated_on) rails would still touch all
associations. After 73ba2c14cd7d7dfb2d132b18c47ade995401736f it updates
associations but rollsback because `touch` would return nil since
there's no timestamp attribute
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 6e3ab3e15faf782f6a937ccf5574a4fb63e3e353, reversing
changes made to 39e07b64ce3f4bb55e60ba0266e677f8e4f4893a.
Conflicts:
activerecord/CHANGELOG.md
activerecord/test/cases/autosave_association_test.rb
|
|\ \ \ \
| | | | |
| | | | | |
Postgres schema: Constrain sequence search classid
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The pk_an_sequence_for query previously joined against pg_class's oid
for rows in pg_depend, but pg_depend's objid may point to other system
tables, such as pg_attrdef. If a row in one of those other tables
coincidentally has the same oid as an (unrelated) sequence, that
sequence name may be returned instead of the real one.
This ensures that only the pg_depend entries pointing to pg_class are
considered.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
ActiveRecord#touch should accept multiple attributes
Conflicts:
activerecord/CHANGELOG.md
|
| |/ / / / |
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
.. not a general timeout.
Now, if a thread checks out a connection then dies, we can immediately
recover that connection and re-use it.
This should alleviate the pool exhaustion discussed in #12867. More
importantly, it entirely avoids the potential issues of the reaper
attempting to check whether connections are still active: as long as the
owning thread is alive, the connection is its business alone.
As a no-op reap is now trivial (only entails checking a thread status
per connection), we can also perform one in-line any time we decide to
sleep for a connection.
|
| | | |
| | | |
| | | |
| | | | |
It wasn't doing anything beyond clearing the statement cache.
|
| | | |
| | | |
| | | |
| | | | |
Closes #14406.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Allows fixtures to use their $LABEL as part of a string instead
of limiting use to the entire value.
mark:
first_name: $LABEL
username: $LABEL1973
email: $LABEL@$LABELmail.com
users(:mark).first_name # => mark
users(:mark).username # => mark1973
users(:mark).email # => mark@markmail.com
|
| | | |
| | | |
| | | |
| | | | |
Fixes #14383.
|
|\ \ \ \
| | | | |
| | | | | |
Update callbacks executed on AR::Base#touch [skip ci]
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
As of https://github.com/rails/rails/pull/12031 after_commit and
after_rollback are also executed
|
|/ / /
| | |
| | |
| | | |
mitigates #14323
|