Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Revert the behavior of booleans in string columns to that of 4.1 | Sean Griffin | 2014-11-09 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | | | | | | Why are people assigning booleans to string columns? >_> We unintentionally changed the behavior on Sqlite3 and PostgreSQL. Boolean values should cast to the database's representation of true and false. This is 't' and 'f' by default, and "1" and "0" on Mysql. The implementation to make the connection adapter specific behavior is hacky at best, and should be re-visted once we decide how we actually want to separate the concerns related to things that should change based on the database adapter. That said, this isn't something I'd expect to change based on my database adapter. We're storing a string, so the way the database represents a boolean should be irrelevant. It also seems strange for us to give booleans special behavior at all in string columns. Why is `to_s` not sufficient? It's inconsistent and confusing. Perhaps we should consider deprecating in the future. Fixes #17571 | ||||
* | Remove the `text?` predicate from the type objects | Sean Griffin | 2014-07-06 | 1 | -4/+0 |
| | | | | | | | This was only used for uniqueness validations. The first usage was in conjunction with `limit`. Types which cast to string, but are not considered text cannot have a limit. The second case was only with an explicit `:case_sensitive => true` option given by the user. | ||||
* | active_record: Type cast booleans and durations for string columns. | Dylan Thacker-Smith | 2014-07-06 | 1 | -1/+3 |
| | |||||
* | Remove unneccessary special case for money in quoting | Sean Griffin | 2014-07-03 | 1 | -4/+4 |
| | |||||
* | Detect in-place modifications on Strings | Sean Griffin | 2014-06-17 | 1 | -1/+16 |
| | |||||
* | Removed unused `klass` definitions from types | Sean Griffin | 2014-06-06 | 1 | -4/+0 |
| | | | | Only `Date` and `Time` are handled. | ||||
* | Move types to the top level `ActiveRecord` namespace | Sean Griffin | 2014-05-27 | 1 | -0/+27 |
`ActiveRecord::ConnectionAdapters::Type::Value` => `ActiveRecord::Type::Value` |