Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | initialize instance variables for transactions to remove conditionals | Aaron Patterson | 2012-08-20 | 1 | -8/+6 |
| | |||||
* | fix whitespace errors | Aaron Patterson | 2012-08-20 | 1 | -2/+2 |
| | |||||
* | Restore state on create when ActiveRecord::RecordInvalid is raised | Dave Yeu | 2012-08-11 | 1 | -1/+1 |
| | | | | This fixes issue #3217. | ||||
* | Restore the frozen state on rollback. Fixes #6417. | Godfrey Chan | 2012-05-21 | 1 | -1/+3 |
| | | | | | | | | | | | | | | | | | | | | Currently, when saving a frozen record, an exception would be thrown which causes a rollback. However, there is a bug in active record that "defrost" the record as a side effect: >> t = Topic.new => #<Topic id: nil, ...> >> t.freeze => #<Topic id: nil, ...> >> t.save RuntimeError: can't modify a frozen Hash >> t.frozen? => false >> t.save => true This patch fixes the bug by explictly restoring the frozen state on the attributes Hash after every rollback. | ||||
* | Merge pull request #5535 from markmcspadden/issue_5527_rollbacks | Aaron Patterson | 2012-05-16 | 1 | -1/+9 |
|\ | | | | | Allow manual rollbacks in after_save to reset object correctly | ||||
| * | Allow manual rollbacks in after_save to reset object correctly | Mark McSpadden | 2012-03-21 | 1 | -1/+9 |
| | | |||||
* | | Fix transaction state not changing when after record gets commited | Hemant Kumar | 2012-05-09 | 1 | -6/+2 |
|/ | |||||
* | Remove IdentityMap | Carlos Antonio da Silva | 2012-03-13 | 1 | -2/+0 |
| | |||||
* | Remove Array.wrap calls in ActiveRecord | Rafael Mendonça França | 2012-01-06 | 1 | -2/+2 |
| | |||||
* | fix nodocs | Vijay Dev | 2011-12-09 | 1 | -5/+5 |
| | |||||
* | Revert "Raise error on unknown primary key." | Jon Leighton | 2011-10-05 | 1 | -1/+1 |
| | | | | This reverts commit ee2be435b1e5c0e94a4ee93a1a310e0471a77d07. | ||||
* | Raise error on unknown primary key. | Jon Leighton | 2011-10-05 | 1 | -1/+1 |
| | | | | | If we don't have a primary key when we ask for it, it's better to fail fast. Fixes GH #2307. | ||||
* | Edited activerecord/lib/active_record/transactions.rb via GitHub | Ayose | 2011-06-01 | 1 | -1/+1 |
| | |||||
* | The URL http://dev.mysql.com/doc/refman/5.0/en/savepoints.html is no longer ↵ | Ayose | 2011-06-01 | 1 | -1/+1 |
| | | | | available | ||||
* | Use IM when trying to load records using ID. | Emilio Tagua | 2011-04-04 | 1 | -0/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'rails/master' into identity_map | Emilio Tagua | 2011-02-15 | 1 | -13/+11 |
|\ | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/examples/performance.rb activerecord/lib/active_record/association_preload.rb activerecord/lib/active_record/associations.rb activerecord/lib/active_record/associations/association_proxy.rb activerecord/lib/active_record/autosave_association.rb activerecord/lib/active_record/base.rb activerecord/lib/active_record/nested_attributes.rb activerecord/test/cases/relations_test.rb | ||||
| * | Use run_callbacks; the generated _run_<name>_callbacks method is not a ↵ | John Firebaugh | 2011-01-31 | 1 | -2/+2 |
| | | | | | | | | | | | | public interface. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
| * | remove useless conditional | Aaron Patterson | 2011-01-17 | 1 | -10/+8 |
| | | |||||
| * | Allow primary_key to be an attribute when the model is a new record | Santiago Pastorino | 2010-12-28 | 1 | -2/+2 |
| | | |||||
* | | Merge remote branch 'rails/master' into identity_map | Emilio Tagua | 2010-12-20 | 1 | -15/+19 |
|\| | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/associations/association_proxy.rb activerecord/lib/active_record/autosave_association.rb activerecord/lib/active_record/base.rb activerecord/lib/active_record/persistence.rb | ||||
| * | reviews commit 53bbbcc | Xavier Noria | 2010-12-11 | 1 | -9/+11 |
| | | |||||
| * | Fix doc about nested transaction rollback | Ivan Evtukhovich | 2010-12-09 | 1 | -1/+2 |
| | | | | | | | | | | Because AR::Rollback do not reraise and inner transaction is not "real" nothing rollback at all | ||||
| * | Partialy revert f1c13b0dd7b22b5f6289ca1a09f1d7a8c7c8584b | José Valim | 2010-11-28 | 1 | -7/+8 |
| | | |||||
* | | Remove object from identity map if transaction failed. | Emilio Tagua | 2010-11-19 | 1 | -0/+1 |
|/ | |||||
* | Don't check if persisted is defined just initialize it properly | Santiago Pastorino | 2010-11-09 | 1 | -1/+0 |
| | |||||
* | use persisted? instead of new_record? wherever possible | David Chelimsky | 2010-11-09 | 1 | -6/+7 |
| | | | | | | | | | | | - persisted? is the API defined in ActiveModel - makes it easier for extension libraries to conform to ActiveModel APIs without concern for whether the extended object is specifically ActiveRecord [#5927 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | #transaction on the instance level should take options as well | Carl Lerche | 2010-10-14 | 1 | -2/+2 |
| | |||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-20 | 1 | -0/+1 |
|\ | | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb | ||||
| * | Fix bug with rolling back frozen attributes. | Brian Durand | 2010-06-18 | 1 | -0/+1 |
| | | | | | | | | | | | | [#2991] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | Adds title to the rest of the files in activerecord/lib | Rizwan Reza | 2010-06-16 | 1 | -2/+4 |
|/ | |||||
* | Make logic for after_commit and after_rollback :on option work like it does ↵ | Brian Durand | 2010-06-08 | 1 | -18/+33 |
| | | | | | | | | for validation callbacks. [#2991 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Revert "Temporarily revert "Update after_commit and after_rollback docs and ↵ | Jeremy Kemper | 2010-06-08 | 1 | -9/+109 |
| | | | | | | | | tests to use new style API with an :on options instead of on_* suffix." and "Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction."" This reverts commit 1b2941cba1165b0721f57524645fe378bee2a950. [#2991] | ||||
* | Temporarily revert "Update after_commit and after_rollback docs and tests to ↵ | Jeremy Kemper | 2010-06-08 | 1 | -109/+9 |
| | | | | | | | | | | | | | | use new style API with an :on options instead of on_* suffix." and "Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction." This reverts commits d2a49e4b1f30c5997e169110eed94a55aee53f56 and da840d13da865331297d5287391231b1ed39721b. [#2991] Conflicts: activerecord/CHANGELOG activerecord/lib/active_record/transactions.rb activerecord/test/cases/transaction_callbacks_test.rb | ||||
* | eliminate alias_method_chain from ActiveRecord | wycats | 2010-05-09 | 1 | -12/+10 |
| | |||||
* | edit pass in the transactions preamble rdoc | Xavier Noria | 2010-05-02 | 1 | -24/+31 |
| | |||||
* | after_(commit|rollback) rdoc, edit pass | Xavier Noria | 2010-04-30 | 1 | -5/+5 |
| | |||||
* | Update after_commit and after_rollback docs and tests to use new style API ↵ | Brian Durand | 2010-04-29 | 1 | -5/+0 |
| | | | | | | | | with an :on options instead of on_* suffix. [#2991] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Add after_commit and after_rollback callbacks to ActiveRecord that are ↵ | Brian Durand | 2010-04-29 | 1 | -14/+117 |
| | | | | | | | | called after transactions either commit or rollback on all records saved or destroyed in the transaction. [#2991 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | save(false) is gone, use save(:validate => false) instead. | José Valim | 2010-01-17 | 1 | -2/+2 |
| | |||||
* | Break up DependencyModule's dual function of providing a "depend_on" DSL and ↵ | Joshua Peek | 2009-05-28 | 1 | -1/+1 |
| | | | | "included" block DSL into separate modules. But, unify both approaches under AS::Concern. | ||||
* | Use DependencyModule for included hooks in ActiveRecord | Bryan Helmkamp | 2009-05-11 | 1 | -7/+5 |
| | |||||
* | Merge docrails | Pratik Naik | 2009-04-05 | 1 | -0/+2 |
| | |||||
* | Revert "Wrap calls to update_attributes in a transaction." | Michael Koziarski | 2009-02-22 | 1 | -15/+1 |
| | | | | | | | This caused failures on sqlite, sqlite3 and postgresql This reverts commit fc09ebc669bd58f415f7d3ef932ef02dab821ab5. [#922 state:reopened] | ||||
* | Wrap calls to update_attributes in a transaction. | Xavier Noria | 2009-02-22 | 1 | -1/+15 |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#922 state:committed] | ||||
* | Introduce transaction_joinable flag to mark that the fixtures transaction ↵ | Jeremy Kemper | 2009-01-10 | 1 | -15/+12 |
| | | | | | | can't joined, a new savepoint is required even if :requires_new is not set. Use :requires_new option instead of :nest. Update changelog. [#383 state:committed] | ||||
* | Merge branch 'master' into savepoints | Jeremy Kemper | 2009-01-10 | 1 | -2/+2 |
|\ | |||||
| * | Don't use the transaction instance method so that people with ↵ | Frederick Cheung | 2008-12-10 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | has_one/belongs_to :transaction aren't fubared [#1551 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | Rename ActiveRecord::Base#transaction's :force option to :nest. Improve ↵ | Hongli Lai (Phusion) | 2008-11-03 | 1 | -2/+57 |
| | | | | | | | | documentation for nested transactions. | ||||
* | | Improve documentation for DatabaseStatements#transactions and ↵ | Hongli Lai (Phusion) | 2008-11-03 | 1 | -0/+2 |
| | | | | | | | | AbstractAdapter#transactional_fixtures, especially with regard to support for nested transactions. | ||||
* | | Implement savepoints. | Jonathan Viney | 2008-11-03 | 1 | -8/+4 |
|/ |