Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add custom prefix to ActiveRecord::Store accessors | Tan Huynh | 2018-03-23 | 1 | -5/+20 |
| | | | | | | Add a prefix option to ActiveRecord::Store.store_accessor and ActiveRecord::Store.store. This option allows stores to have identical keys with different accessors. | ||||
* | Add MySQL JSON reference to ActiveRecord::Store documentation | Saverio Miroddi | 2018-03-17 | 1 | -2/+2 |
| | | | | | | The current documentation explicitly mentions only PostgreSQL (hstore/json) for use with `.store_accessor`, making it somewhat confusing what to choose on a MySQL 5.7+ setup (which introduced a json data type). | ||||
* | Avoid extra calls to to_s | Daniel Colson | 2018-01-29 | 1 | -1/+1 |
| | | | | | | | With #31615 `type_for_attribute` accepts either a symbol as well as a string. `has_attribute?` and `attribute_alias` also accept either. Since these methods call `to_s` on the argument, we no longer need to do that at the call site. | ||||
* | Use frozen-string-literal in ActiveRecord | Kir Shatrov | 2017-07-19 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | Report the attribute on ActiveRecord::SerializationTypeMismatch | Kir Shatrov | 2017-01-29 | 1 | -3/+3 |
| | |||||
* | Privatize unneededly protected methods in Active Record | Akira Matsuda | 2016-12-24 | 1 | -4/+3 |
| | |||||
* | code gardening: removes redundant selfs | Xavier Noria | 2016-08-08 | 1 | -2/+2 |
| | | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required. | ||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -24/+24 |
| | |||||
* | applies new string literal convention in activerecord/lib | Xavier Noria | 2016-08-06 | 1 | -2/+2 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new doc guidelines to Active Record. | Yves Senn | 2015-10-14 | 1 | -2/+3 |
| | | | | | | | | | | | | | | | | | | | The focus of this change is to make the API more accessible. References to method and classes should be linked to make it easy to navigate around. This patch makes exzessiv use of `rdoc-ref:` to provide more readable docs. This makes it possible to document `ActiveRecord::Base#save` even though the method is within a separate module `ActiveRecord::Persistence`. The goal here is to bring the API closer to the actual code that you would write. This commit only deals with Active Record. The other gems will be updated accordingly but in different commits. The pass through Active Record is not completely finished yet. A follow up commit will change the spots I haven't yet had the time to update. /cc @fxn | ||||
* | Fix type case of "validations" and word-wrap from #17954 [ci skip] | Zachary Scott | 2014-12-08 | 1 | -2/+3 |
| | |||||
* | Add note to Store about uniqueness validation (#17954) [skip ci] | Mike Chau | 2014-12-08 | 1 | -1/+4 |
| | |||||
* | add missing `:nodoc:` to `store.rb`. [ci skip] | Yves Senn | 2014-06-24 | 1 | -4/+4 |
| | |||||
* | Remove unneeded `@column_types` instance variable | Sean Griffin | 2014-06-22 | 1 | -1/+1 |
| | | | | This was used more previously, but other uses have been removed. | ||||
* | Fix inheritance of stored_attributes (fixes #14672) | Jessica Yao | 2014-05-14 | 1 | -5/+14 |
| | | | | [Brad Bennett, Jessica Yao, & Lakshmi Parthasarathy] | ||||
* | Fix: ActiveRecord::Store TypeError conversion when using YAML coder | Thales Oliveira | 2014-01-06 | 1 | -1/+1 |
| | | | | | | | | | | Renaming the test accordingly to its behaviour Adding 'Fixes' statement to changelog Improving tests legibility & changelog Undoing mistakenly removed empty line & further improving changelog | ||||
* | improve Active Record Store docs when using PG types. [ci skip]. | Yves Senn | 2013-11-09 | 1 | -3/+4 |
| | |||||
* | Fix typo in AR store docs [ci skip] | Carlos Antonio da Silva | 2013-11-09 | 1 | -1/+1 |
| | |||||
* | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2013-11-07 | 1 | -0/+4 |
|\ | |||||
| * | refine usage docs of `store` in combination with `hstore` and `json`. | Yves Senn | 2013-11-06 | 1 | -3/+3 |
| | | | | | | | | refs #11561 #12700 | ||||
| * | Hstore and JSON fields are not supported with store | Robin Dupret | 2013-10-30 | 1 | -0/+4 |
| | | | | | | | | | | The use of `store` on Hstore fields (for instance) is not needed because serialization aimed to interact with Ruby objects and not with provided field types | ||||
* | | `ActiveRecord::Store` works together with PG `hstore` columns. | Yves Senn | 2013-10-25 | 1 | -14/+46 |
| | | | | | | | | | | | | This is necessary because as of 5ac2341 `hstore` columns are always stored as `Hash` with `String` keys. `ActiveRecord::Store` expected the attribute to be an instance of `HashWithIndifferentAccess`, which led to the bug. | ||||
* | | `stored_attributes` need to be specific to a subclass. | Yves Senn | 2013-10-25 | 1 | -0/+3 |
|/ | | | | | | | | | | | | | | | | | Currently they are all stored globally in the same `Hash`. This commit forces the creation of a per-class variable if necessary. The behavior was exposed through the following test-case: ``` 1) Failure: StoreTest#test_all_stored_attributes_are_returned [/Users/senny/Projects/rails/activerecord/test/cases/store_test.rb:151]: --- expected +++ actual @@ -1 +1 @@ -[:color, :homepage, :favorite_food] +[:resolution, :color, :homepage, :favorite_food] ``` | ||||
* | define Active Record Store accessors in a module | Sergey Nartimov | 2013-02-11 | 1 | -12/+21 |
| | | | | | | | | | | | | | Allow store accessors to be overrided like other attribute methods, e.g.: class User < ActiveRecord::Base store :settings, accessors: [ :color, :homepage ], coder: JSON def color super || 'red' end end | ||||
* | Namespace HashWithIndifferentAccess | Akira Matsuda | 2013-01-07 | 1 | -3/+3 |
| | |||||
* | refactor store_accessor | Matt Jones | 2012-09-13 | 1 | -6/+38 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-09-09 | 1 | -1/+1 |
|\ | | | | | | | | | Conflicts: activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb | ||||
| * | add :nodoc: to AR::Store::IndifferentCoder [ci skip] | Francesco Rodriguez | 2012-09-08 | 1 | -1/+1 |
| | | |||||
* | | correctly flag changed attributes in AR::Store, combine multiple calls to ↵ | Matt Jones | 2012-09-05 | 1 | -2/+3 |
|/ | | | | store_accessor | ||||
* | Use instance_accessor: false instead of instance_writer. | kennyj | 2012-08-21 | 1 | -1/+1 |
| | |||||
* | load active_support/core_ext/class/attribute in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 |
| | |||||
* | load active_support/concern in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 |
| | |||||
* | Avoid to call send(store_attribute) twice. | kennyj | 2012-07-15 | 1 | -6/+8 |
| | |||||
* | Remove duplicated code in the AR::Store. | kennyj | 2012-07-14 | 1 | -11/+3 |
| | |||||
* | Added *instance_writer: false* for stored/serialized attributes. | kennyj | 2012-07-07 | 1 | -1/+1 |
| | |||||
* | Don't mark the store as changed if an attribute isn't changed. | kennyj | 2012-07-03 | 1 | -2/+5 |
| | |||||
* | Refactor and use class_attribute | Carlos Antonio da Silva | 2012-06-18 | 1 | -3/+5 |
| | |||||
* | Remember the stored attributes in a config attribute. | Joost Baaij | 2012-06-18 | 1 | -0/+12 |
| | | | | | | This allows you to retrieve the list of attributes you've defined. Usable for e.g. selects in the view, or interators based on the attributes you wish to store in the serialized column. | ||||
* | Fixed typo. | chrismcc | 2012-06-11 | 1 | -1/+1 |
| | |||||
* | Fix backward compatibility with stored Hash values. Wrap coders to convert ↵ | Jeremy Kemper | 2012-05-30 | 1 | -2/+32 |
| | | | | serialized values to indifferent access. | ||||
* | Convert Hash to HashWithIndifferentAccess in ActiveRecord::Store. | Andrey Voronkov | 2012-05-22 | 1 | -10/+27 |
| | | | | | | | In order to make migration from 3.x apps easier, we should try to convert Hash instances to HashWithIndifferentAccess, to allow accessing values with both symbol and a string. This is follow up to changes in 3c0bf043. | ||||
* | Copy edit [ci skip] | Rafael Mendonça França | 2012-05-13 | 1 | -3/+4 |
| | |||||
* | Custom coders support for ActiveRecord::Store. JSON, YAML, Marshal can be ↵ | Andrey Voronkov | 2012-05-09 | 1 | -5/+10 |
| | | | | used out of the box. | ||||
* | Merge pull request #4856 from ihid/store_null_bug | Aaron Patterson | 2012-02-02 | 1 | -0/+2 |
|\ | | | | | Allow store to be a not null column. | ||||
| * | Allow store to be a not null column. | Jeremy Walker | 2012-02-02 | 1 | -0/+2 |
| | | |||||
* | | *args is already an array. :'( | Aaron Patterson | 2012-02-02 | 1 | -1/+1 |
| | | |||||
* | | removed whitespace errors ↵ | Aaron Patterson | 2012-02-02 | 1 | -4/+4 |
|/ | | | | :yellow_heart::blue_heart::purple_heart::heart::green_heart: | ||||
* | Fix that changing a store should mark the store attribute as changed | David Heinemeier Hansson | 2011-10-25 | 1 | -0/+1 |
| |