Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -3/+3 |
| | |||||
* | [ci skip] Fix wrong rdoc-ref links, the format is {}[] not []{} | Prathamesh Sonpatki | 2016-09-14 | 1 | -2/+2 |
| | |||||
* | Ensure that inverse associations are set before running callbacks | Sean Griffin | 2016-08-31 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | If a parent association was accessed in an `after_find` or `after_initialize` callback, it would always end up loading the association, and then immediately overwriting the association we just loaded. If this occurred in a way that the parent's `current_scope` was set to eager load the child, this would result in an infinite loop and eventually overflow the stack. For records that are created with `.new`, we have a mechanism to perform an action before the callbacks are run. I've introduced the same code path for records created with `instantiate`, and updated all code which sets inverse instances on newly loaded associations to use this block instead. Fixes #26320. | ||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 1 | -1/+0 |
| | |||||
* | Remove `prepare_binds_for_database` internal method | Ryuta Kamizono | 2016-07-28 | 1 | -2/+2 |
| | | | | To avoid relying on the connection adapter for type casting binds. | ||||
* | Decouple statement cache from connection adapter | Ryuta Kamizono | 2016-07-24 | 1 | -7/+6 |
| | | | | | | `StatementCache` is hard-coded in `cacheable_query` and be passed `visitor` and `collector` from connection adapter. Simply it is enough to pass a collected value. | ||||
* | Ensure prepared statement caching still occurs with Adequate Record | Sean Griffin | 2016-02-11 | 1 | -1/+1 |
| | | | | | | | | | | | | | In Rails 5, we're much more restrictive about when we do or don't cache a prepared statement. In particular, we never cache when we are sending an IN statement or a SQL string literal However, in the case of Adequate Record, we are *always* sending a raw SQL string, and we *always* want to cache the result. Fixes #23507 /cc @tgxworld | ||||
* | applies new doc guidelines to Active Record. | Yves Senn | 2015-10-14 | 1 | -3/+5 |
| | | | | | | | | | | | | | | | | | | | The focus of this change is to make the API more accessible. References to method and classes should be linked to make it easy to navigate around. This patch makes exzessiv use of `rdoc-ref:` to provide more readable docs. This makes it possible to document `ActiveRecord::Base#save` even though the method is within a separate module `ActiveRecord::Persistence`. The goal here is to bring the API closer to the actual code that you would write. This commit only deals with Active Record. The other gems will be updated accordingly but in different commits. The pass through Active Record is not completely finished yet. A follow up commit will change the spots I haven't yet had the time to update. /cc @fxn | ||||
* | Remove Relation#bind_params | Sean Griffin | 2015-01-27 | 1 | -9/+9 |
| | | | | | | | | `bound_attributes` is now used universally across the board, removing the need for the conversion layer. These changes are mostly mechanical, with the exception of the log subscriber. Additional, we had to implement `hash` on the attribute objects, so they could be used as a key for query caching. | ||||
* | Stop passing a column to `quote` when executing from a statement cache | Sean Griffin | 2015-01-10 | 1 | -2/+2 |
| | | | | | | | I'm planning on deprecating the column argument to mirror the deprecation in [arel]. [arel]: https://github.com/rails/arel/commit/6160bfbda1d1781c3b08a33ec4955f170e95be11 | ||||
* | Pass symbol as an argument instead of a block | Erik Michaels-Ober | 2014-11-29 | 1 | -1/+1 |
| | |||||
* | Update the StatementCache documentation | Rafael Mendonça França | 2014-11-27 | 1 | -4/+15 |
| | |||||
* | StatementCache is private API | Rafael Mendonça França | 2014-11-27 | 1 | -6/+6 |
| | | | | It should not be used in applications | ||||
* | use an array for bind params to simplify substitution | Aaron Patterson | 2014-04-12 | 1 | -5/+5 |
| | |||||
* | decouple the factory method from the constructing model | Aaron Patterson | 2014-04-10 | 1 | -3/+1 |
| | | | | | | The factory method only requires the constructing model to get the connection object. Since the model is available when calling the factory method, we can just pass the appropriate connection in. | ||||
* | remove intelligence from StatementCache#initialize | Aaron Patterson | 2014-04-10 | 1 | -9/+11 |
| | |||||
* | stop caching the class on the statement cache object | Aaron Patterson | 2014-04-10 | 1 | -5/+5 |
| | |||||
* | fix ivar names and add reader methods | Aaron Patterson | 2014-04-10 | 1 | -7/+6 |
| | |||||
* | eagerly build the cacheable query builder | Aaron Patterson | 2014-04-10 | 1 | -13/+7 |
| | |||||
* | eagerly build the bind map | Aaron Patterson | 2014-04-10 | 1 | -8/+5 |
| | |||||
* | eagerly build the relation object | Aaron Patterson | 2014-04-10 | 1 | -8/+2 |
| | |||||
* | remove dead code | Aaron Patterson | 2014-04-10 | 1 | -7/+0 |
| | |||||
* | speed up parameter substitution | Aaron Patterson | 2014-04-09 | 1 | -2/+12 |
| | | | | | store the offsets of the bind values, then only index to bind value locations before joining the array | ||||
* | working against arel/collector branch | Aaron Patterson | 2014-04-09 | 1 | -4/+4 |
| | |||||
* | working against arel/collector branch | Aaron Patterson | 2014-04-09 | 1 | -1/+1 |
| | |||||
* | fix the method signature | Aaron Patterson | 2014-01-17 | 1 | -1/+1 |
| | |||||
* | oops! | Aaron Patterson | 2014-01-17 | 1 | -1/+1 |
| | |||||
* | don't cache the connection (because we don't need to) | Aaron Patterson | 2014-01-17 | 1 | -8/+7 |
| | |||||
* | remove dead code | Aaron Patterson | 2014-01-17 | 1 | -1/+1 |
| | |||||
* | change query strategy based on adapter | Aaron Patterson | 2014-01-16 | 1 | -4/+41 |
| | |||||
* | use a params hash so we know what bind parameters are used | Aaron Patterson | 2014-01-15 | 1 | -9/+48 |
| | |||||
* | fix cache class interface | Aaron Patterson | 2014-01-14 | 1 | -5/+17 |
| | |||||
* | just a test | Aaron Patterson | 2013-05-17 | 1 | -6/+2 |
| | |||||
* | Initial commit for select statements bindparam implementation | Noemj | 2013-05-15 | 1 | -2/+6 |
| | |||||
* | minor edit on StatementCache documentation [ci skip] | Francesco Rodriguez | 2013-04-12 | 1 | -1/+1 |
| | |||||
* | Fix StatementCache docs format [ci skip] | Francesco Rodriguez | 2013-04-11 | 1 | -5/+5 |
| | |||||
* | Switched to new naming conventions | Noemj | 2013-04-11 | 1 | -1/+1 |
| | | | | [ci skip] | ||||
* | Merge pull request #10152 from Noemj/statement_cache | Rafael Mendonça França | 2013-04-10 | 1 | -5/+5 |
| | | | | | | | Statement cache Conflicts: activerecord/CHANGELOG.md | ||||
* | Added statement cache | Noemj | 2013-04-10 | 1 | -0/+26 |