aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/session_store.rb
Commit message (Collapse)AuthorAgeFilesLines
* missing require: the AR session store depends on the AP abstract storeXavier Noria2012-07-281-0/+2
| | | | | | | | This require makes the dependency even more clear. In particular we are eager loading the session store but that does not work if AR is used outside Rails, this patch is preliminary work in fixing #7160.
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-07-151-1/+1
|\
| * session_id column is string in defaultkennyj2012-07-151-1/+1
| |
* | Fix SqlBypass.data_column= problem. SqlBypass.find_by_session_id method ↵kennyj2012-07-151-1/+1
|/ | | | didn't use this assignment.
* Rename test file so that the test suite matches it, implement `persisted?` ↵Marcelo Silveira2012-05-161-5/+10
| | | | for SqlBypass as expected by tests and convert session_id to string before using on queries to get correct quotes on postgresql (avoid casting error).
* %s/find(:\(first\|last\|all\), \([^()]*\))/scoped(\2).\1/gcI amongst other ↵Jon Leighton2012-04-271-1/+1
| | | | things
* test a subclass so that the removed method does not imact other testsAaron Patterson2012-01-051-1/+1
|
* remove ActiveSupport::Base64 in favor of ::Base64Sergey Nartimov2012-01-021-4/+4
|
* pushing caching and visitors down to the connectionAaron Patterson2011-11-191-2/+2
|
* Revert "Merge pull request #1163 from amatsuda/sexier_migration_31"Aaron Patterson2011-11-171-4/+3
| | | | | | | | | | This reverts commit 0e407a90413d8a19002b85508d811ccdf2190783, reversing changes made to 533a9f84b035756eedf9fdccf0c494dc9701ba72. Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/migration_test.rb
* Merge pull request #1163 from amatsuda/sexier_migration_31Aaron Patterson2011-11-041-3/+4
|\ | | | | Sexier migrations
| * No "t." for the migration DSL!Akira Matsuda2011-05-201-3/+4
| | | | | | | | | | Now you can omit |t| block parameter and all the t. from your migration code, that means, the syntax looks more Rails-3-ish, like the routes DSL and ActionMailer DSL. Also, this change won't break any of your existing migration files, since the traditional syntax is still available.
* | Merge pull request #2042 from SAP-Oxygen/master-sqlbypass-patchSantiago Pastorino2011-07-121-7/+13
|\ \ | | | | | | Fix for SqlBypass session store (for master)
| * | Fix for SqlBypass session storeJoseph Wong2011-07-121-7/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Two issues fixed: 1) connection_pool is not defined - needed by SessionStore#drop_table! and create_table! since c94651f 2) initialization of connection to the default of AR::Base.connection only occurred at the singleton level - the instance level method defined by cattr_accessor did not have this logic
* | | Fixed session ID fixation for ActiveRecord::SessionStoreJoseph Wong2011-07-121-2/+6
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I have found that Rails will take an invalid session ID specified by the client and materialize a session based on that session ID. This means that it is possible, among other things, for a client to use an arbitrarily weak session ID or for a client to resurrect a previous used session ID. In other words, we cannot guarantee that all session IDs are generated by the server and that they are (statistically) unique through time. The fix is to always generate a new session ID in #get_session if an existing session cannot be found under the incoming session ID. Also added new tests that make sure that an invalid session ID is never materialized into a new session, regardless of whether it comes in via a cookie or a URL parameter (when :cookie_only => false).
* / Remove extra white spaces on ActiveRecord docs.Sebastian Martinez2011-05-231-9/+9
|/
* updated AR#create! to accept an options hash so the mass-assignment security ↵Josh Kalderimis2011-05-121-2/+2
| | | | role can be passed in, also updated the Changelog to mention the change to some of the AR method signatures.
* Puts ActiveRecord::SessionStore attributes in white list, fixes #483slainer682011-05-101-0/+2
|
* almost fistedAaron Patterson2011-02-041-2/+2
|
* share column cache among subclasses, only look up columns per AR::Base ↵Aaron Patterson2011-02-011-2/+2
| | | | subclass once
* avoid column lookup on subclasses, keep column info cached as table_name => ↵Aaron Patterson2011-02-011-0/+2
| | | | column_list
* Partialy revert f1c13b0dd7b22b5f6289ca1a09f1d7a8c7c8584bJosé Valim2010-11-281-4/+4
|
* Allow AR Session Store to be renewedJosé Valim2010-11-111-0/+1
|
* use persisted? instead of new_record? wherever possibleDavid Chelimsky2010-11-091-4/+4
| | | | | | | | | | | - persisted? is the API defined in ActiveModel - makes it easier for extension libraries to conform to ActiveModel APIs without concern for whether the extended object is specifically ActiveRecord [#5927 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Rely on Rack::Session stores API for more compatibility across the Ruby world.José Valim2010-10-031-2/+5
|
* Revert "Setup explicit requires for files with exceptions. Removed them from ↵José Valim2010-09-021-2/+0
| | | | | | | | autoloading." Booting a new Rails application does not work after this commit [#5359 state:open] This reverts commit 38a421b34d0b414564e919f67d339fac067a56e6.
* Setup explicit requires for files with exceptions. Removed them from ↵Łukasz Strzałkowski2010-09-021-0/+2
| | | | | | autoloading. Signed-off-by: José Valim <jose.valim@gmail.com>
* Replaced hardcoded SessionStore table creation SQL with calls to ↵Raimonds Simanovskis2010-08-161-8/+6
| | | | | | ActiveRecord adapter migration methods Otherwise hardcoded table creation SQL was failing on Oracle database
* remove already defined method to avoid warningsSantiago Pastorino2010-08-151-0/+1
|
* Revert "connection reader is defined later"Santiago Pastorino2010-08-151-1/+1
| | | | This reverts commit f4cce71d96c4aab898ae074174d93802fcb0b1cc.
* connection reader is defined laterSantiago Pastorino2010-08-151-1/+1
|
* Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵Santiago Pastorino2010-08-141-1/+1
| | | | 's/[ \t]*$//' -i {} \;)
* Revert "Avoid uneeded queries in session stores if sid is not given."José Valim2010-07-291-0/+1
| | | | | | First step to merge Rails and Rack session stores. Rack always expects to receive the SID since it may have different behavior if the SID is nil. This reverts commit e210895ba95e498b9debbf43a3e5ae588bca81f0.
* testing sqlbypass destroy. caching connection during destroyAaron Patterson2010-07-231-6/+7
|
* brrrrr! freeze is not neededAaron Patterson2010-07-231-1/+1
|
* fixing space errorAaron Patterson2010-07-221-1/+1
|
* refactoring more methods to a class methods moduleAaron Patterson2010-07-221-20/+12
|
* refactoring class methods to a moduleAaron Patterson2010-07-221-24/+18
|
* Session data will exceed 255 bytes. Use TEXT.Jeremy Kemper2010-07-221-1/+1
|
* Makes current adapter decide the syntax of PRIMARY KEY column definitionSantiago Pastorino2010-07-221-2/+2
|
* This is a VARCHAR not a TEXTSantiago Pastorino2010-07-221-1/+1
|
* MySQL can't index a TEXT columnSantiago Pastorino2010-07-221-2/+2
|
* refactor to use instance methods and be kind to subclassesAaron Patterson2010-07-221-10/+11
|
* testing loaded? method and reducing funcallsAaron Patterson2010-07-211-1/+1
|
* testing new_record? and converting to an attributeAaron Patterson2010-07-211-5/+3
|
* reducing function calls in the session storeAaron Patterson2010-07-211-5/+5
|
* readability is hipAaron Patterson2010-07-211-2/+4
|
* starting sql bypass test, fixing create_table and drop_table!Aaron Patterson2010-07-211-4/+4
|
* initializing instance variablesAaron Patterson2010-07-211-1/+6
|
* adding tests for sessions and clearing up warningsAaron Patterson2010-07-211-3/+9
|