rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
...
*	Deprecate eager-evaluated scopes.	Jon Leighton	2012-03-21	1	-2/+16
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Don't use this: scope :red, where(color: 'red') default_scope where(color: 'red') Use this: scope :red, -> { where(color: 'red') } default_scope { where(color: 'red') } The former has numerous issues. It is a common newbie gotcha to do the following: scope :recent, where(published_at: Time.now - 2.weeks) Or a more subtle variant: scope :recent, -> { where(published_at: Time.now - 2.weeks) } scope :recent_red, recent.where(color: 'red') Eager scopes are also very complex to implement within Active Record, and there are still bugs. For example, the following does not do what you expect: scope :remove_conditions, except(:where) where(...).remove_conditions # => still has conditions
*	Avoid obscure &Proc.new thing	Jon Leighton	2012-03-21	1	-2/+2
\|
*	Remove valid_scope_name? check - use ruby	Jon Leighton	2012-03-21	1	-11/+1
\| \| \| \| \| \| \|	scope is syntactic sugar for defining a class method. Ruby allows redefining methods but emits a warning when run with -w. So let's not implement our own logic for this. Users should run with -w if they want to be warned about redefined methods.
*	no need for cast	Jon Leighton	2012-03-21	1	-1/+0
\|
*	no need for lvar	Jon Leighton	2012-03-21	1	-3/+1
\|
*	app code in general wants Time.current, not Time.now	Xavier Noria	2011-12-28	1	-3/+3
\|
*	call scope within unscoped to prevent duplication of where values	Sergey Nartimov	2011-12-17	1	-1/+1
\|
*	Move DefaultScope and NamedScope under Scoping	Jon Leighton	2011-12-15	1	-0/+202