Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix "last equality wins" logic in relation merge | Ernie Miller | 2012-08-19 | 1 | -10/+5 |
| | | | | | | This is a real fix (as compared to the band-aid in b127d86c), which uses the recently-added equality methods for ARel nodes. It has the side benefit of simplifying the merge code a bit. | ||||
* | Fix merge error when Equality LHS is non-attribute | Ernie Miller | 2012-08-17 | 1 | -2/+5 |
| | | | | | | | | | This is at best a band-aid for a more proper fix, since it won't truly handle the removal of the previous equality condition of these other nodes. I'm planning to put in some work on ARel toward supporting that goal. Related: rails/arel#130, ernie/squeel#153, ernie/squeel#156 | ||||
* | Allow Relation#merge to take a proc. | Jon Leighton | 2012-08-03 | 1 | -2/+13 |
| | | | | | | | | | | | | | | | | | | This was requested by DHH to allow creating of one's own custom association macros. For example: module Commentable def has_many_comments(extra) has_many :comments, -> { where(:foo).merge(extra) } end end class Post < ActiveRecord::Base extend Commentable has_many_comments -> { where(:bar) } end | ||||
* | load active_support/core_ext/module/delegation in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 |
| | |||||
* | load active_support/core_ext/object/blank in active_support/rails | Xavier Noria | 2012-08-02 | 6 | -6/+0 |
| | |||||
* | AR::Relation#order: make new order prepend old one | Bogdan Gusiev | 2012-07-31 | 2 | -3/+3 |
| | | | | | | | User.order("name asc").order("created_at desc") # SELECT * FROM users ORDER BY created_at desc, name asc This also affects order defined in `default_scope` or any kind of associations. | ||||
* | Revert "Removing composed_of from ActiveRecord." | Rafael Mendonça França | 2012-07-27 | 1 | -1/+2 |
| | | | | | | | | | | | This reverts commit 14fc8b34521f8354a17e50cd11fa3f809e423592. Reason: we need to discuss a better path from this removal. Conflicts: activerecord/lib/active_record/reflection.rb activerecord/test/cases/base_test.rb activerecord/test/models/developer.rb | ||||
* | Changelog and doc updates for the previous changes. | Jon Leighton | 2012-07-27 | 1 | -6/+6 |
| | |||||
* | Deprecate Relation#all. | Jon Leighton | 2012-07-27 | 2 | -15/+2 |
| | | | | | | It has been moved to active_record_deprecated_finders. Use #to_a instead. | ||||
* | Deprecate ActiveRecord::Base.scoped. | Jon Leighton | 2012-07-27 | 1 | -1/+1 |
| | | | | | | | It doesn't serve much purpose now that ActiveRecord::Base.all returns a Relation. The code is moved to active_record_deprecated_finders. | ||||
* | improve NullRelation docs [ci skip] | Vijay Dev | 2012-07-21 | 1 | -4/+4 |
| | |||||
* | minor copy edits [ci skip] | Vijay Dev | 2012-07-21 | 1 | -1/+1 |
| | |||||
* | Add nodocs to delegation module and docs for merge! | Oscar Del Ben | 2012-07-17 | 2 | -1/+2 |
| | |||||
* | Update batches docs | Oscar Del Ben | 2012-07-17 | 1 | -6/+6 |
| | |||||
* | Add nodoc to HashMerger and Merger | Oscar Del Ben | 2012-07-17 | 1 | -2/+2 |
| | |||||
* | Typo | Oscar Del Ben | 2012-07-16 | 1 | -1/+0 |
| | |||||
* | Add documentation for query_methods bang methods | Oscar Del Ben | 2012-07-16 | 1 | -1/+20 |
| | |||||
* | Add nodoc to create_with_value | Oscar Del Ben | 2012-07-16 | 1 | -1/+1 |
| | | | | | Reason: all *_value methods are defined dynamically and so don't appear in the documentation. | ||||
* | Add documentation for arel and build_arel | Oscar Del Ben | 2012-07-16 | 1 | -0/+2 |
| | |||||
* | Add documentation for create_with | Oscar Del Ben | 2012-07-16 | 1 | -1/+19 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-07-15 | 1 | -2/+39 |
|\ | |||||
| * | Add docs for having, lock and readonly | Oscar Del Ben | 2012-07-07 | 1 | -0/+12 |
| | | |||||
| * | Add doc for joins and improve includes doc | Oscar Del Ben | 2012-07-07 | 1 | -2/+17 |
| | | |||||
| * | Add docs for eager_laod and preload | Oscar Del Ben | 2012-07-07 | 1 | -0/+10 |
| | | |||||
* | | fix association :extend option | Jon Leighton | 2012-07-13 | 1 | -1/+1 |
| | | |||||
* | | support relations created with a table alias | Jon Leighton | 2012-07-13 | 1 | -1/+1 |
|/ | |||||
* | minor text change [ci skip] | Vijay Dev | 2012-07-07 | 1 | -1/+1 |
| | |||||
* | Revert "Add nodoc to relation methods" | Vijay Dev | 2012-07-07 | 1 | -22/+24 |
| | | | | | | This reverts commit c47a698d5d497340d4e349257522212173865838. Reason: Let's revert pending further discussions | ||||
* | Add nodoc to relation methods | Oscar Del Ben | 2012-07-06 | 1 | -24/+22 |
| | |||||
* | Add order docs | Oscar Del Ben | 2012-07-05 | 1 | -0/+10 |
| | |||||
* | Add group documentation | Oscar Del Ben | 2012-07-05 | 1 | -0/+12 |
| | |||||
* | Add documentation for includes | Oscar Del Ben | 2012-07-05 | 1 | -0/+11 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-06-30 | 1 | -5/+7 |
|\ | | | | | | | | | Conflicts: activemodel/lib/active_model/errors.rb | ||||
| * | update AR::FinderMethods#exists?(false) example [ci skip] | Francesco Rodriguez | 2012-06-28 | 1 | -5/+7 |
| | | |||||
* | | fixing typo in from documentation | Subba Rao Pasupuleti | 2012-06-28 | 1 | -2/+2 |
| | | |||||
* | | Use args.flatten! in query methods when applicable | Carlos Antonio da Silva | 2012-06-25 | 1 | -7/+12 |
| | | | | | | | | | | Try to use more destructive methods on *args when applicable, to avoid creating new objects. | ||||
* | | Merge pull request #6544 from flexoid/issue-6431 | Piotr Sarnacki | 2012-06-25 | 1 | -6/+6 |
|\ \ | | | | | | | exists?(false) returns false | ||||
| * | | exists?(false) returns false | Egor Lynko | 2012-06-25 | 1 | -6/+6 |
| | | | | | | | | | | | | `FinderMethods#exists?` finder method now returns *false* with the *false* argument | ||||
* | | | Ensure Arel columns are typecasted properly when grouping with calculation | Carlos Antonio da Silva | 2012-06-25 | 1 | -6/+6 |
|/ / | | | | | | | Fix build issue with postgresql. | ||||
* / | Stop assuming strings for grouped calculations | Ernie Miller | 2012-06-24 | 1 | -6/+17 |
|/ | | | | | | | | | | | | | | | Execute_grouped_calculation is one of those places where ActiveRecord forgets that it has ARel underpinnings, and assumes that the values provided to group_values are strings. This artificially hobbles otherwise functional code. This patch stops assuming that incoming values respond to to_sym, stops using string interpolation for table aliases on objects that support aliasing, and stops unnecessarily joining group_values on the relation. Additionally, it calls to_sql, if available, on objects sent to column_alias_for, in order to get a more reasonable alias string than a non-string's default to_str method. | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-06-22 | 1 | -3/+15 |
|\ | |||||
| * | fixes a few mistakes in api docs [ci skip] | Vijay Dev | 2012-06-22 | 1 | -4/+2 |
| | | |||||
| * | Add documentation for ActiveRecord::QueryMethods#reverse_order [ci skip] | Florent Guilleux | 2012-06-16 | 1 | -0/+3 |
| | | |||||
| * | Add documentation for ActiveRecord::QueryMethods#offset [ci skip] | Ulises Cabanillas | 2012-06-16 | 1 | -0/+7 |
| | | |||||
| * | Add documentation for ActiveRecord::QueryMethods#limit [ci skip] | Florent Guilleux | 2012-06-16 | 1 | -3/+7 |
| | | |||||
* | | Add changelog entry and guide updates for pluck with multiple columns | Carlos Antonio da Silva | 2012-06-22 | 1 | -0/+1 |
| | | |||||
* | | Refactor pluck with multiple columns | Carlos Antonio da Silva | 2012-06-22 | 1 | -26/+13 |
| | | | | | | | | | | | | | | | | | | | | | | | | Ensure it works with mix of symbols and strings, and with a select clause possibly containing more than one column. Also remove support for pluck with an array of columns, in favor of passing the list of attributes: Model.pluck(:a, :b) See comments: https://github.com/rails/rails/pull/6500#issuecomment-6030292 | ||||
* | | ActiveRecord#pluck now accepts multiple columns | jeroeningen | 2012-06-22 | 1 | -15/+35 |
| | | |||||
* | | disallow mutating a relation once loaded | Jon Leighton | 2012-06-22 | 1 | -18/+20 |
| | | |||||
* | | Extract conditional to a method to avoid duplication | Rafael Mendonça França | 2012-06-19 | 1 | -15/+19 |
| | | | | | | | | Also use if/else block to not use short circuit return |