Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Deprecate implicit eager loading. Closes #950. | Jon Leighton | 2011-12-29 | 1 | -2/+2 |
| | |||||
* | Merge pull request #4216 from edgecase/master_fix_reorder_with_limited_ids | Aaron Patterson | 2011-12-28 | 1 | -1/+1 |
|\ | | | | | allow reorder to affect eager loading correctly | ||||
| * | allow reorder to affect eager loading correctly | Matt Jones + Scott Walker | 2011-12-28 | 1 | -1/+1 |
| | | |||||
* | | refactor AR::PredicateBuilder.build_from_hash | Akira Matsuda | 2011-12-29 | 1 | -35/+37 |
| | | |||||
* | | where(foo: [1, nil]) becomes "WHERE foo = 1 OR foo IS NULL" | Akira Matsuda | 2011-12-28 | 1 | -1/+4 |
| | | | | | | | | was "WHERE foo IN (1) OR foo IS NULL" before | ||||
* | | no need to compact an already compacted Array | Akira Matsuda | 2011-12-28 | 1 | -1/+1 |
|/ | |||||
* | Make PredicateBuilder recognise AR::Model | Jon Leighton | 2011-12-24 | 1 | -2/+2 |
| | |||||
* | Fix #exists? for AR::Model | Jon Leighton | 2011-12-24 | 1 | -1/+1 |
| | |||||
* | Delete unnecessary line that was necessary before I changed the code and it ↵ | Jon Leighton | 2011-12-22 | 1 | -1/+0 |
| | | | | became no longer necessary. | ||||
* | Make ActiveRecord::Relation#pluck work with serialized attributes | Jon Leighton | 2011-12-22 | 1 | -4/+4 |
| | |||||
* | Do not raise an exception if an invalid route was generated automatically. | José Valim | 2011-12-16 | 1 | -1/+1 |
| | |||||
* | Set up delegations also for to_a and arel branches. | José Valim | 2011-12-15 | 1 | -2/+9 |
| | |||||
* | Move delegation reponsibilities of Relation to a module. Also precompile ↵ | José Valim | 2011-12-15 | 1 | -0/+42 |
| | | | | method missing calls for rofscale. | ||||
* | ActiveRecord::Relation#pluck method | Bogdan Gusiev | 2011-11-30 | 1 | -0/+17 |
| | |||||
* | pushing caching and visitors down to the connection | Aaron Patterson | 2011-11-19 | 1 | -1/+1 |
| | |||||
* | Fixes issue #3483, regarding using a mixture of ranges and discrete values ↵ | Ryan Naughton | 2011-11-14 | 1 | -6/+8 |
| | | | | in find conditions. Paired with Joey Schoblaska. | ||||
* | exclude ORDER BY clause when querying Relation#exists? | Akira Matsuda | 2011-11-09 | 1 | -1/+1 |
| | |||||
* | Add ActiveRecord::Relation#uniq for toggling DISTINCT in the SQL query | Jon Leighton | 2011-11-05 | 1 | -6/+24 |
| | |||||
* | copy edits 908f2616 | Vijay Dev | 2011-09-20 | 1 | -4/+4 |
| | |||||
* | Document ActiveRecord::QueryMethods#select | Ryan Bigg | 2011-09-17 | 1 | -0/+29 |
| | |||||
* | minor edit | Vijay Dev | 2011-09-14 | 1 | -1/+1 |
| | |||||
* | Add documentation for the extending method in ActiveRecord:QueryMethods | Ryan Bigg | 2011-09-14 | 1 | -0/+36 |
| | |||||
* | Merge pull request #2485 from akaspick/exists_fix | Jon Leighton | 2011-09-07 | 1 | -1/+3 |
|\ | | | | | fix exists? to return false if passed nil (which may come from a missing | ||||
| * | fix exists? to return false if passed nil (which may come from a missing URL ↵ | Andrew Kaspick | 2011-08-10 | 1 | -1/+3 |
| | | | | | | | | param) | ||||
* | | Use LIMIT sql word in last when it's possible | Damien Mathieu | 2011-09-05 | 1 | -1/+5 |
| | | |||||
* | | use LIMIT SQL word in first - Closes #2783 | Damien Mathieu | 2011-09-05 | 1 | -1/+1 |
| | | |||||
* | | We need to recorder here. Need to drop the order from default scope. | Arun Agrawal | 2011-09-05 | 1 | -1/+1 |
| | | | | | | Fixes #2832 | ||||
* | | Revert "Fixes bug in ActiveRecord::QueryMethods, #1697" | Jon Leighton | 2011-09-04 | 1 | -2/+4 |
| | | | | | | | | | | | | This reverts commit 0df27c98d982ec87d2fb48cfda82694eb267993e. Reverted due to failing test, see #2845. | ||||
* | | Fixes bug in ActiveRecord::QueryMethods, #1697 | Joshua Wehner | 2011-08-31 | 1 | -4/+2 |
| | | | | | | Replace split on comma with a regexp that will reverse all ASC/DESC specifically | ||||
* | | The join_nodes must be passed to the JoinDependency initializer and ↵ | Jon Leighton | 2011-08-29 | 1 | -7/+2 |
| | | | | | | | | therefore counted by the alias tracker. This is because the association_joins are aliased on initialization and then the tables are cached, so it is no use to alias the join_nodes later. Fixes #2556. | ||||
* | | Fix PredicateBuilder clobbering select_values in subquery. | Ernie Miller | 2011-08-20 | 1 | -1/+1 |
| | | |||||
* | | Fix assumption of primary key name in PredicateBuilder subquery. | Ernie Miller | 2011-08-20 | 1 | -1/+1 |
|/ | |||||
* | Make it the responsibility of the connection to hold onto an ARel visitor ↵ | Jon Leighton | 2011-08-08 | 2 | -5/+5 |
| | | | | for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now. | ||||
* | Revert "Merge pull request #2309 from smasry/master" | Jon Leighton | 2011-07-28 | 1 | -1/+1 |
| | | | | | | | This reverts commit 9d396ee8195e31f646e0b89158ed96f4db4ab38f, reversing changes made to fa2bfd832c1d1e997d93c2269a485cc74782c86d. Reason: the change broke the build. | ||||
* | Reverse order fix when using function for ActiveRecord::QueryMethods Fixes #1697 | Samer Masry | 2011-07-27 | 1 | -1/+1 |
| | |||||
* | Fixed failing query when performing calculation with having based on select. | Dmitriy Kiriyenko | 2011-07-27 | 1 | -0/+1 |
| | |||||
* | Revert "allow select to have multiple arguments" | Piotr Sarnacki | 2011-07-26 | 1 | -6/+3 |
| | | | | | | | This reverts commit 04cc446d178653d362510e79a22db5300d463161. I reverted it because apparently we want to use: select([:a, :b]) instead of select(:a, :b), but there was no tests for that form. | ||||
* | allow select to have multiple arguments | Sławosz Sławiński | 2011-07-26 | 1 | -3/+6 |
| | |||||
* | Ordering with extra spaces was raising a SQL exception | Franck Verrot | 2011-07-24 | 1 | -0/+1 |
| | |||||
* | avoid Symbol#to_proc | Vijay Dev | 2011-07-20 | 1 | -1/+1 |
| | |||||
* | ActiveRecord: Fix eager loading so that giving a blank order clause ↵ | Elliot Winkler | 2011-07-18 | 1 | -1/+1 |
| | | | | generates valid SQL | ||||
* | Merge pull request #1807 from caius/find_in_batches_id_bug | Santiago Pastorino | 2011-07-14 | 1 | -2/+5 |
|\ | | | | | Bugfix by stopping find_in_batches using the records after yielding. | ||||
| * | Stop find_in_batches using the records after yielding. | Caius Durling | 2011-06-21 | 1 | -2/+5 |
| | | | | | | | | | | | | Currently if the code that calls .find_in_batches modifies the yielded array in place then .find_in_batches can enter an infinite loop searching with ruby object ids in the database instead of the primary key of records in the database. This happens because it naively assumes the yielded array hasn't been modified before calling #id on the last object in the array. And ruby (1.8 at least) alias' #id to #object_id so an integer is still returned no matter what the last object is. By moving finding the #id of the last object before yielding the array it means the calling code can do whatever it wants to the array in terms of modifying it in place, and .find_in_batches doesn't care. | ||||
* | | Merge pull request #1823 from gnarg/master | Santiago Pastorino | 2011-07-10 | 1 | -2/+2 |
|\ \ | | | | | | | Log instrumentation name for exists? queries | ||||
| * | | Log instrumentation name for exists? queries | Jon Guymon | 2011-06-22 | 1 | -2/+2 |
| | | | |||||
* | | | fix AR having() not to raise NoMethodError when the given argument does not ↵ | Akira Matsuda | 2011-07-09 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | | | respond to empty? having raises NoMethodError: undefined method `empty?' when a Fixnum or Date/Time were passed via varargs | ||||
* | | | Make `ActiveRecord::Batches#find_each` to not return `self`. | knapo | 2011-07-07 | 1 | -2/+0 |
| | | | | | | | | | | | | This caused that `find_each` was producing extra db call taking all the records from db, and was less efficient than `ActiveRecord::Base#all`. | ||||
* | | | Remove case statement changes from 2e0840d and 56ac32a. Inheritance FTW. | Ernie Miller | 2011-07-06 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #1273 from jeremyf/feature-association-proxy-send | Santiago Pastorino | 2011-07-06 | 1 | -0/+1 |
|\ \ \ | | | | | | | | | Addresses an inconsistency in the ActiveRecord::Base.method_missing handl | ||||
| * | | | Addresses an inconsistency in the ActiveRecord::Base.method_missing handling ↵ | Jeremy Friesen | 2011-05-24 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | of dynamic finder methods and the passing of the &block parameter for :find_by_attributes. |