Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | ActiveRecord::Relation#primary_key should return a string, just like ↵ | Jon Leighton | 2011-01-03 | 4 | -14/+14 | |
| | | | | | | | | | | | | ActiveRecord::Base.primary_key does. | |||||
* | | | Make Relation#create_with always merge rather than overwrite, not just when ↵ | Jon Leighton | 2011-01-03 | 2 | -4/+2 | |
| | | | | | | | | | | | | merging two relations. If you wish to overwrite, you can do relation.create_with(nil), or for a specific attribute, relation.create_with(:attr => nil). | |||||
* | | | Let AssociationCollection#find use #scoped to do its finding. Note that I am ↵ | Jon Leighton | 2011-01-03 | 1 | -1/+1 | |
| | | | | | | | | | | | | removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences. | |||||
* | | | User id instead of quoted_id to prevent double quoting. Fixes failing test ↵ | Robert Pankowecki (Gavdi) | 2011-01-04 | 1 | -1/+1 | |
| | | | | | | | | | | | | for bug #6036. | |||||
* | | | Rename AssociationReflection#primary_key_name to foreign_key, since the ↵ | Jon Leighton | 2010-12-31 | 1 | -1/+1 | |
| | | | | | | | | | | | | options key which it relates to is :foreign_key | |||||
* | | | Specify the STI type condition using SQL IN rather than a whole load of ORs. ↵ | Jon Leighton | 2010-12-31 | 1 | -1/+5 | |
|/ / | | | | | | | Required a fix to ActiveRecord::Relation#merge for properly merging create_with_value. This also fixes a situation where the type condition was appearing twice in the resultant SQL query. | |||||
* | | arel can escape the id, so avoid using the database connection | Aaron Patterson | 2010-12-22 | 1 | -1/+1 | |
| | | ||||||
* | | Arel::Table#[] always returns an attribute, so no need for || | Aaron Patterson | 2010-12-22 | 1 | -1/+1 | |
| | | ||||||
* | | to_sym stuff before passing it to arel | Aaron Patterson | 2010-12-22 | 1 | -1/+1 | |
| | | ||||||
* | | ActiveRecord::Base.joins should allow single nil argument [#6181 state:resolved] | Piotr Sarnacki | 2010-12-16 | 1 | -1/+1 | |
| | | ||||||
* | | make sure that join nodes are uniq | Aaron Patterson | 2010-12-16 | 1 | -1/+1 | |
| | | ||||||
* | | supporting arel AST nodes when building join statements | Aaron Patterson | 2010-12-16 | 1 | -3/+15 | |
| | | ||||||
* | | bucketing based on join type | Aaron Patterson | 2010-12-16 | 1 | -8/+17 | |
| | | ||||||
* | | taking advantage of the JoinSource node in the SQL AST | Aaron Patterson | 2010-12-16 | 2 | -17/+8 | |
| | | ||||||
* | | remove lasgn since AST is mutated | Aaron Patterson | 2010-12-16 | 1 | -1/+1 | |
| | | ||||||
* | | just mutate the ast, fewer lasgns | Aaron Patterson | 2010-12-16 | 1 | -3/+2 | |
|/ | ||||||
* | no more manager manipulation if there is no custom join ast | Aaron Patterson | 2010-12-10 | 1 | -6/+5 | |
| | ||||||
* | froms should never equal 0 | Aaron Patterson | 2010-12-10 | 1 | -2/+0 | |
| | ||||||
* | manager will always be a manager | Aaron Patterson | 2010-12-10 | 1 | -10/+6 | |
| | ||||||
* | eliminate lasgns | Aaron Patterson | 2010-12-10 | 1 | -10/+10 | |
| | ||||||
* | dealing with an AST manager, not a relation, so fix the variable names | Aaron Patterson | 2010-12-10 | 1 | -12/+12 | |
| | ||||||
* | adding a fixme comment | Aaron Patterson | 2010-12-08 | 1 | -0/+1 | |
| | ||||||
* | renaming variables, making the join_ast method private | Aaron Patterson | 2010-12-08 | 1 | -51/+27 | |
| | ||||||
* | further reducing dependence on custom_joins | Aaron Patterson | 2010-12-08 | 1 | -0/+2 | |
| | ||||||
* | reducing use of custom joins | Aaron Patterson | 2010-12-08 | 1 | -1/+6 | |
| | ||||||
* | passing the ast to a table when the relation is a table | Aaron Patterson | 2010-12-07 | 1 | -3/+20 | |
| | ||||||
* | JoinDependency is always created with an AST now | Aaron Patterson | 2010-12-07 | 1 | -1/+15 | |
| | ||||||
* | passing the ast to JoinDependency | Aaron Patterson | 2010-12-07 | 1 | -1/+1 | |
| | ||||||
* | cleaning up custom_join_sql method | Aaron Patterson | 2010-12-07 | 1 | -4/+6 | |
| | ||||||
* | use the columns hash for primary key lookup | Aaron Patterson | 2010-12-03 | 1 | -1/+1 | |
| | ||||||
* | fix warnings, stop using global variables | Aaron Patterson | 2010-11-30 | 1 | -4/+2 | |
| | ||||||
* | stop using splat args when we do not need them | Aaron Patterson | 2010-11-30 | 1 | -2/+2 | |
| | ||||||
* | just grep the AST for OuterJoin nodes rather than converting the tree to SQL | Aaron Patterson | 2010-11-30 | 1 | -1/+1 | |
| | ||||||
* | reduce method calls on arel | Aaron Patterson | 2010-11-30 | 3 | -3/+3 | |
| | ||||||
* | making relationship merge cheaper | Aaron Patterson | 2010-11-30 | 1 | -3/+4 | |
| | ||||||
* | use ARel rather than generate SQL strings | Aaron Patterson | 2010-11-24 | 1 | -1/+1 | |
| | ||||||
* | moving column_aliases to JoinDependency | Aaron Patterson | 2010-11-24 | 1 | -10/+1 | |
| | ||||||
* | just wrap as a sql literal | Aaron Patterson | 2010-11-23 | 1 | -2/+1 | |
| | ||||||
* | Do not send id for quoting twice if the primary key is string. | Neeraj Singh | 2010-11-23 | 1 | -1/+2 | |
| | | | | [#6022 state:resolved] | |||||
* | skip cloning if arguments are blank | Aaron Patterson | 2010-11-22 | 1 | -8/+22 | |
| | ||||||
* | group can be done by left side only | Aaron Patterson | 2010-11-17 | 1 | -6/+3 | |
| | ||||||
* | collapsing same table / column WHERE clauses to be OR [#4598 state:resolved] | Aaron Patterson | 2010-11-17 | 1 | -4/+25 | |
| | ||||||
* | use shorter form for sql literals | Aaron Patterson | 2010-11-17 | 1 | -1/+1 | |
| | ||||||
* | refactor to reduce method calls | Aaron Patterson | 2010-11-16 | 1 | -10/+19 | |
| | ||||||
* | Fix ActiveRecord calculations when grouped by multiple fields | Alexandru Catighera | 2010-11-16 | 1 | -14/+18 | |
| | ||||||
* | support finding by a ruby class [#5979 state:resolved] | Aaron Patterson | 2010-11-15 | 1 | -0/+3 | |
| | ||||||
* | use quoted id of single AR::Base objects in predicates | Aaron Patterson | 2010-11-15 | 1 | -0/+2 | |
| | ||||||
* | Finder gives a little bit more info on the lookup column (primary key) | Franck Verrot | 2010-11-13 | 1 | -1/+1 | |
| | ||||||
* | stop recursively calling exists? | Aaron Patterson | 2010-11-05 | 1 | -3/+5 | |
| | ||||||
* | Fixes queries using limits and punctuation in order, removes order("col1, ↵ | Santiago Pastorino | 2010-11-05 | 1 | -1/+1 | |
| | | | | | | col2") usage in favor of order(["col1", "col2"}) [#4597 state:committed] |