Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | return is not needed here | Neeraj Singh | 2010-09-09 | 1 | -2/+2 |
| | |||||
* | remove unnecessary call | Neeraj Singh | 2010-09-09 | 1 | -1/+0 |
| | | | | if operation is count then column_name will never be blank | ||||
* | creating a new array is required. who knew? :-( | Aaron Patterson | 2010-09-09 | 1 | -1/+1 |
| | |||||
* | no need for Array.wrap, also avoid array creation | Aaron Patterson | 2010-09-09 | 1 | -5/+4 |
| | |||||
* | make apply_modules run faster | Neeraj Singh | 2010-09-09 | 1 | -3/+5 |
| | |||||
* | eliminate present? for fewer method calls | Aaron Patterson | 2010-09-08 | 1 | -10/+2 |
| | |||||
* | returning arrays lets us avoid Array.wrap | Aaron Patterson | 2010-09-08 | 1 | -4/+4 |
| | |||||
* | removing unnecessary conditional test | Aaron Patterson | 2010-09-08 | 1 | -4/+4 |
| | |||||
* | switch to blank? to avoid method calls | Aaron Patterson | 2010-09-08 | 1 | -6/+6 |
| | |||||
* | refactor to use faster empty? | Aaron Patterson | 2010-09-08 | 1 | -1/+3 |
| | |||||
* | drying up joins() | Aaron Patterson | 2010-09-08 | 1 | -4/+2 |
| | |||||
* | reduce method calls, use reject + blank? instead of select + present? | Aaron Patterson | 2010-09-08 | 1 | -3/+3 |
| | |||||
* | attributes should be constructed with table objects | Aaron Patterson | 2010-09-07 | 1 | -1/+1 |
| | |||||
* | attributes should be associated with tables | Aaron Patterson | 2010-09-07 | 1 | -1/+1 |
| | |||||
* | removing useless code, cleaning variable names | Aaron Patterson | 2010-09-07 | 1 | -6/+2 |
| | |||||
* | select should raise error when no block or no parameter is passed | Aaron Patterson | 2010-09-07 | 1 | -3/+3 |
| | |||||
* | select does not need a *args | Aaron Patterson | 2010-09-07 | 1 | -2/+2 |
| | |||||
* | cleaning up confusing logic | Aaron Patterson | 2010-09-06 | 1 | -3/+6 |
| | |||||
* | Make scoped reorder override previous applied orders | Santiago Pastorino | 2010-09-05 | 2 | -3/+15 |
| | | | | [5528 state:committed] | ||||
* | order should always be concatenated. | Neeraj Singh | 2010-09-05 | 1 | -2/+1 |
| | | | | | | | | | | | | | | | | | | | | | | order that is declared first has highest priority in all cases. Here are some examples. Car.order('name desc').find(:first, :order => 'id').name Car.named_scope_with_order.named_scope_with_another_order Car.order('id DESC').scoping do Car.find(:first, :order => 'id asc') end No special treatment to with_scope or scoping. Also note that if default_scope declares an order then the order declared in default_scope has the highest priority unless with_exclusive_scope is used. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Use new finders syntax in docs. | Emilio Tagua | 2010-09-01 | 2 | -18/+18 |
| | |||||
* | Make all the Relation finder methods consistent | Pratik Naik | 2010-08-31 | 1 | -32/+67 |
| | |||||
* | Merge remote branch 'miloops/rails_master_fixes' | Pratik Naik | 2010-08-31 | 1 | -15/+26 |
|\ | |||||
| * | Avoid calling build_where is no argument is given. | Emilio Tagua | 2010-08-31 | 1 | -1/+1 |
| | | |||||
| * | Improved conditionals usage to prevent calling methods. | Emilio Tagua | 2010-08-31 | 1 | -8/+19 |
| | | |||||
| * | Don't test conditional in iteration if it is not present just clone it. | Emilio Tagua | 2010-08-31 | 1 | -9/+9 |
| | | |||||
* | | Remove default values for Relation#limit/offset/from/create_with | Pratik Naik | 2010-08-31 | 1 | -4/+4 |
| | | |||||
* | | Change relation merging to always append select, group and order values | Pratik Naik | 2010-08-31 | 1 | -7/+10 |
|/ | |||||
* | PERF: Avoid two method calls | Santiago Pastorino | 2010-08-28 | 1 | -1/+1 |
| | |||||
* | Merge remote branch 'docrails/master' | Xavier Noria | 2010-08-26 | 1 | -8/+6 |
|\ | |||||
| * | minor formatting fixes | Neeraj Singh | 2010-08-25 | 1 | -8/+6 |
| | | |||||
* | | use blank? instead of present?, mark SQL literals as SQL literals | Aaron Patterson | 2010-08-25 | 1 | -5/+5 |
| | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/relation/query_methods.rb | ||||
* | | no need to send on a public method | Aaron Patterson | 2010-08-25 | 1 | -1/+1 |
| | | |||||
* | | refactor select { is_a? } to grep() | Aaron Patterson | 2010-08-25 | 1 | -1/+1 |
|/ | |||||
* | sql literal strings should be marked as sql literal strings | Aaron Patterson | 2010-08-23 | 1 | -1/+3 |
| | |||||
* | we should wrap strings as sql literals | Aaron Patterson | 2010-08-19 | 1 | -1/+1 |
| | |||||
* | refactoring to remove duplicate logic | Aaron Patterson | 2010-08-18 | 1 | -4/+3 |
| | |||||
* | call to present? is not necessary | Aaron Patterson | 2010-08-18 | 1 | -2/+1 |
| | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 3 | -34/+34 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Removing most of the symbol to proc usage in Active Record | Prem Sichanugrist | 2010-08-13 | 1 | -1/+1 |
| | | | | This will hopefully make Active Record run a bit more faster. | ||||
* | avoid direct use of arel constants | Aaron Patterson | 2010-08-13 | 1 | -2/+4 |
| | |||||
* | Ensure we can nest include calls [#5285 state:resolved] | Neeraj Singh | 2010-08-12 | 2 | -2/+8 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | subtracting blank strings is slightly faster than blank? | Aaron Patterson | 2010-08-11 | 1 | -3/+1 |
| | |||||
* | avoid multiple hash lookups | Aaron Patterson | 2010-08-11 | 1 | -2/+6 |
| | |||||
* | avoiding tap saves us time | Aaron Patterson | 2010-08-11 | 1 | -2/+6 |
| | |||||
* | unless Array#empty? is faster than if Array#present? | Aaron Patterson | 2010-08-11 | 1 | -1/+1 |
| | |||||
* | stop using private methods | Aaron Patterson | 2010-08-11 | 1 | -2/+2 |
| | |||||
* | adds missing requires for Object#try | Xavier Noria | 2010-08-09 | 1 | -0/+1 |
| | |||||
* | avoid passing lists of lists to the group clause | Aaron Patterson | 2010-08-04 | 1 | -1/+1 |
| | |||||
* | call to_a since we are not passing anything to all() | Aaron Patterson | 2010-08-04 | 1 | -1/+1 |
| |