| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Fix `find_nth` with `limit_value`
|
| |
| |
| |
| |
| | |
If the `index` exceeds a `limit`, simply return an empty result without
querying the database.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a grouped calculation contains a having clause that references a
selected value, we need to include that selected value in the query.
Postgres doesn't support referencing a selected value in a having
clause, but other databases do; we can skip the test on the pg adapter
but run it for the others.
This was fixed before in 9a298a162c16e019fe6971e563e7f4916e86ced6, but
the test coverage was lost in 5a05207d99b7e2678f9b42db2d9ffc21ec2c8c3b.
The fix regressed in 6311975fb3c02f50730fd1e11b8dba8dd9c05306 and was
removed in 97d46c17ea9113b0ce970167f5208c8d9170915c.
|
|\
| |
| | |
Remove duplicated private method in ActiveRecord::FinderMethods
|
| | |
|
|/
|
|
|
| |
`select_values` is a local variable defined at previous line.
`select_values += select_values` is totally useless.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
`DISTINCT` clause is applied inside aggregate function by
`operation_over_aggregate_column` if needed. Unneeded outside aggregate
function.
```ruby
# Before
author.unique_categorized_posts.count
# => SELECT DISTINCT COUNT(DISTINCT "posts"."id") FROM "posts" INNER JOIN "categorizations" ON "posts"."id" = "categorizations"."post_id" WHERE "categorizations"."author_id" = ? [["author_id", 2]]
# After
author.unique_categorized_posts.count
# => SELECT COUNT(DISTINCT "posts"."id") FROM "posts" INNER JOIN "categorizations" ON "posts"."id" = "categorizations"."post_id" WHERE "categorizations"."author_id" = ? [["author_id", 2]]
```
Closes #27615
|
|\
| |
| | |
Fix unscope with subquery
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Currently cannot unscope subquery properly.
This commit fixes the issue.
Fixes #26323.
|
|\ \
| | |
| | |
| | |
| | | |
kenta-s/add-methods-back-to-array-delegation-from-ar-relation
Delegate `to_sentence` and `to_fomatted_s` to `records`
|
| | | |
|
| | |
| | |
| | |
| | | |
This reverts commit 28977f1fa3d7b15c1608174a165e60b71ddf3995.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
kamipo/decouple_building_arel_ast_for_uniqueness_validator
Decouple the building Arel ASTs for uniqueness validator
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently uniqueness validator is coupled with building Arel ASTs.
This commit extracts `WhereClauseFactory#build_for_case_sensitive` for
decouple the building Arel ASTs.
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If select clause is specified and last column has a column alias,
additional column alias causes a statement invalid.
Add test coverage for counting a single column with NULL values.
Fixes #27676, #27682, and #27705.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby
|
| | | |
|
| | |
| | |
| | |
| | | |
find and exists?
|
| | |
| | |
| | |
| | | |
Closes #14640
|
| | | |
|
| | |
| | |
| | |
| | | |
provided.
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Remove extracting `polymorphic_base_class` for `Array` in `AssociationQueryValue`
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`AssociationQueryValue`
It is handled by `PolymorphicArrayValue`.
|
| |/ /
|/| |
| | |
| | |
| | |
| | | |
Some methods were added to public API in
5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of
the public API.
|
| | | |
|
| | | |
|
| | | |
|
| |/
|/|
| |
| | |
Raise `ActiveRecord::RangeError` when values that executed are out of range.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
9c9fb19 changed the behaviour of the _ids= setters for associations to
raise an AssociationTypeMismatch when unknown IDs are given:
Class: <ActiveRecord::AssociationTypeMismatch>
Message: <"Developer(#43811860) expected, got NilClass(#16732720)">
This restores the original ActiveRecord::RecordNotFound exception with a
much clearer error message:
Class: <ActiveRecord::RecordNotFound>
Message: <"Couldn't find all Developers with 'id': (1, -9999) [WHERE \"contracts\".\"company_id\" = ?] (found 1 results, but was looking for 2)">
Fixes #25719
|
|\ \
| | |
| | | |
Should except `:distinct` rather than `:order` for `exists?`
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Records fetching order is very important for performance if `limit` is
presented. Should not except the order in the case.
And `exists?` replaces select list to `1 AS one` therefore `:distinct`
is useless (`DISTINCT 1 AS one`). And PostgreSQL raises the following
error if `:distinct` and `:order` are used in the same time.
```
ERROR: for SELECT DISTINCT, ORDER BY expressions must appear in select list
```
|
|/ /
| |
| |
| | |
All query methods calls `spawn` and bang method, but only `none` is not.
|
| |
| |
| |
| |
| | |
If `limit_value` is presented, records fetching order is very important
for performance. Should not unscope the order in the case.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Regexp#match? should be considered to be part of the Ruby core library. We are
emulating it for < 2.4, but not having to require the extension is part of the
illusion of the emulation.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- CollectionAssociation#select was removed in
https://github.com/rails/rails/pull/25989 in favor of
QueryMethods#select but it caused a regression when passing arguments
to select and a block.
- This used to work earlier in Rails 4.2 and Rails 5. See gist
https://gist.github.com/prathamesh-sonpatki/a7df922273473a77dfbc742a4be4b618.
- This commit restores the behavior of Rails 4.2 and Rails 5.0.0 to
allow passing arguments and block at the same time but also deprecates
it.
- Because, these arguments do not have any effect on the output of
select when select is used with a block.
- Updated documentation to remove the example passing arguments and
block at the same time to `CollectionProxy#select`.
|
|\ \
| | |
| | |
| | |
| | | |
rutaka-n/raise_record_not_found_with_correct_params
initialize errors with name of class and other params
|
| |/ |
|
| | |
|
|/ |
|
|\
| |
| | |
Reduce array allocation when `where` with passed hash
|
| |
| |
| |
| |
| | |
In most case `where` is called with passed hash. In the case
initializing `binds` is unnecessary.
|
|\ \
| | |
| | | |
Rename variable name that returning `type_for` to `type` from `column`
|