Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | avoid creating objects when we can | Aaron Patterson | 2010-10-03 | 2 | -12/+6 | |
| | ||||||
* | build_where should be private | Aaron Patterson | 2010-09-30 | 1 | -2/+2 | |
| | ||||||
* | [#5441 state:resolved] refactoring code to determine aggregate column | Aaron Patterson | 2010-09-30 | 1 | -11/+14 | |
| | ||||||
* | removing more useless code! yay! | Aaron Patterson | 2010-09-28 | 1 | -6/+2 | |
| | ||||||
* | SqlLiteral is a string, so we can dry up these conditionals | Aaron Patterson | 2010-09-28 | 1 | -4/+3 | |
| | ||||||
* | shorten up or sql literal creation statements | Aaron Patterson | 2010-09-28 | 1 | -4/+2 | |
| | ||||||
* | we only care about arrays and strings | Aaron Patterson | 2010-09-28 | 1 | -1/+1 | |
| | ||||||
* | dry up calls to arel.join() | Aaron Patterson | 2010-09-28 | 1 | -5/+4 | |
| | ||||||
* | removing unused lasgns | Aaron Patterson | 2010-09-28 | 1 | -4/+4 | |
| | ||||||
* | refactoring to remove crazy logic | Aaron Patterson | 2010-09-28 | 2 | -9/+6 | |
| | ||||||
* | performance improvement based on discussion at ↵ | Neeraj Singh | 2010-09-28 | 1 | -9/+3 | |
| | | | | | | http://github.com/rails/rails/commit/fbd1d306b95cc2efb6422e12d26d5818a3a42343 Credit goes to all the participants in the discussion | |||||
* | removing a conditional that is not used | Aaron Patterson | 2010-09-28 | 1 | -2/+0 | |
| | ||||||
* | fisting the postgresql tests | Aaron Patterson | 2010-09-28 | 1 | -1/+2 | |
| | ||||||
* | avoid calling to_sql when we can | Aaron Patterson | 2010-09-28 | 2 | -4/+4 | |
| | ||||||
* | removing an inject + merge in favor of Hash#[] | Aaron Patterson | 2010-09-28 | 1 | -1/+1 | |
| | ||||||
* | make sure we use the engine assigned to the table when quoting | Aaron Patterson | 2010-09-27 | 1 | -1/+1 | |
| | ||||||
* | Three performance improvements: | Neeraj Singh | 2010-09-27 | 1 | -10/+9 | |
| | | | | | | | | * for simple cases like User.last and User.order('name desc').last no need to perform Array#join operation. * Instead of performing String#blank? do Array#empty? * no need to create variable relation | |||||
* | Goodbye inject, hello map. | Emilio Tagua | 2010-09-22 | 1 | -7/+5 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | un-nodocs AR::Batches | Xavier Noria | 2010-09-21 | 1 | -1/+1 | |
| | ||||||
* | adds to the API guidelines the proper spelling of Arel | Xavier Noria | 2010-09-19 | 1 | -2/+2 | |
| | ||||||
* | @join_values is passed in, so we should use the parameter | Aaron Patterson | 2010-09-15 | 1 | -1/+1 | |
| | ||||||
* | passing the quoted id to arel if the object has a quoted id | Aaron Patterson | 2010-09-10 | 1 | -1/+3 | |
| | ||||||
* | converting an inject to a map + Hash[] | Aaron Patterson | 2010-09-10 | 1 | -1/+1 | |
| | ||||||
* | avoid method_missing and reduce method calls | Aaron Patterson | 2010-09-10 | 1 | -1/+1 | |
| | ||||||
* | intersection between a relation and an array works in both directions | Marcelo Giorgi | 2010-09-10 | 1 | -0/+1 | |
| | | | | Signed-off-by: Mikel Lindsaar <raasdnil@gmail.com> | |||||
* | Refactor finder conditions look up and assigment for apply_finder_conditions. | Emilio Tagua | 2010-09-09 | 1 | -13/+7 | |
| | ||||||
* | Refactor Relation#only. No need to go through every option and test it. | Emilio Tagua | 2010-09-09 | 1 | -8/+6 | |
| | ||||||
* | No need to go through every option and test it, just don't add skipped ones. | Emilio Tagua | 2010-09-09 | 1 | -4/+4 | |
| | ||||||
* | return is not needed here | Neeraj Singh | 2010-09-09 | 1 | -2/+2 | |
| | ||||||
* | remove unnecessary call | Neeraj Singh | 2010-09-09 | 1 | -1/+0 | |
| | | | | if operation is count then column_name will never be blank | |||||
* | creating a new array is required. who knew? :-( | Aaron Patterson | 2010-09-09 | 1 | -1/+1 | |
| | ||||||
* | no need for Array.wrap, also avoid array creation | Aaron Patterson | 2010-09-09 | 1 | -5/+4 | |
| | ||||||
* | make apply_modules run faster | Neeraj Singh | 2010-09-09 | 1 | -3/+5 | |
| | ||||||
* | eliminate present? for fewer method calls | Aaron Patterson | 2010-09-08 | 1 | -10/+2 | |
| | ||||||
* | returning arrays lets us avoid Array.wrap | Aaron Patterson | 2010-09-08 | 1 | -4/+4 | |
| | ||||||
* | removing unnecessary conditional test | Aaron Patterson | 2010-09-08 | 1 | -4/+4 | |
| | ||||||
* | switch to blank? to avoid method calls | Aaron Patterson | 2010-09-08 | 1 | -6/+6 | |
| | ||||||
* | refactor to use faster empty? | Aaron Patterson | 2010-09-08 | 1 | -1/+3 | |
| | ||||||
* | drying up joins() | Aaron Patterson | 2010-09-08 | 1 | -4/+2 | |
| | ||||||
* | reduce method calls, use reject + blank? instead of select + present? | Aaron Patterson | 2010-09-08 | 1 | -3/+3 | |
| | ||||||
* | attributes should be constructed with table objects | Aaron Patterson | 2010-09-07 | 1 | -1/+1 | |
| | ||||||
* | attributes should be associated with tables | Aaron Patterson | 2010-09-07 | 1 | -1/+1 | |
| | ||||||
* | removing useless code, cleaning variable names | Aaron Patterson | 2010-09-07 | 1 | -6/+2 | |
| | ||||||
* | select should raise error when no block or no parameter is passed | Aaron Patterson | 2010-09-07 | 1 | -3/+3 | |
| | ||||||
* | select does not need a *args | Aaron Patterson | 2010-09-07 | 1 | -2/+2 | |
| | ||||||
* | cleaning up confusing logic | Aaron Patterson | 2010-09-06 | 1 | -3/+6 | |
| | ||||||
* | Make scoped reorder override previous applied orders | Santiago Pastorino | 2010-09-05 | 2 | -3/+15 | |
| | | | | [5528 state:committed] | |||||
* | order should always be concatenated. | Neeraj Singh | 2010-09-05 | 1 | -2/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | order that is declared first has highest priority in all cases. Here are some examples. Car.order('name desc').find(:first, :order => 'id').name Car.named_scope_with_order.named_scope_with_another_order Car.order('id DESC').scoping do Car.find(:first, :order => 'id asc') end No special treatment to with_scope or scoping. Also note that if default_scope declares an order then the order declared in default_scope has the highest priority unless with_exclusive_scope is used. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Use new finders syntax in docs. | Emilio Tagua | 2010-09-01 | 2 | -18/+18 | |
| | ||||||
* | Make all the Relation finder methods consistent | Pratik Naik | 2010-08-31 | 1 | -32/+67 | |
| |