| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Active Record doesn't rely delegating to `arel` in the internal since
425f2ca. The delegation is a lower priority than delegating to `klass`,
so it is pretty unclear which method is delegated to `arel`.
For example, `bind_values` method was removed at b06f64c (a series of
changes https://github.com/rails/rails/compare/79f71d3...b06f64c). But a
relation still could respond to the method because `arel` also have the
same named method (#28976).
Removing the delegation will achieve predictable behavior.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
kamipo/remove_method_missing_in_relation_delegation
Remove `method_missing` in `Relation::Delegation`
|
| | | |
| | | |
| | | |
| | | | |
The `method_missing` is never reached since 64c53d7c.
|
|\ \ \ \
| | | | |
| | | | | |
`Relation#locked?` should not build arel
|
| | |/ /
| |/| |
| | | |
| | | |
| | | | |
The delegation was needed since passing `relation` with
`relation.bound_attributes`. It should use `relation.arel` in that case.
|
|\ \ \ \
| | | | |
| | | | | |
Extract `ordered_relation` in `FinderMethods`
|
| |/ / / |
|
|/ / / |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If casted value is nil, generated SQL should be `IS NULL`. But currently
it is generated as `= NULL`. To prevent this behavior, avoid making bind
param if casted value is nil.
Fixes #28945.
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
Fix association with extension issues
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This fixes the following issues.
* `association_scope` doesn't include `default_scope`. Should use `scope` instead.
* We can't use `method_missing` for customizing existing method.
* We can't use `relation_delegate_class` for sharing extensions. Should extend per association.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
in `ActiveRecord::Calculations`
`select`, `count`, and `sum` in `Relation` are also `Enumerable` method
that can be passed block. `select` with block already doesn't take
arguments since 4fc3366. This is follow up of that.
|
|\ \ \ \
| |/ / /
|/| | | |
Delegate `ast` and `locked` to `arel` explicitly
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently `ast` and `locked` are used in the internal but delegating to
`arel` is depend on `method_missing`. If a model class is defined these
methods, `select_all` will be broken.
It should be delegated to `arel` explicitly.
|
| | | |
| | | |
| | | | |
[ci skip]
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
```ruby
require "benchmark/ips"
require "set"
array = [:asc, :desc, :ASC, :DESC, "asc", "desc", "ASC", "DESC"]
set = array.to_set
item = "DESC"
Benchmark.ips do |x|
x.report "array" do
array.include?(item)
end
x.report "set" do
set.include?(item)
end
end
```
```
% ruby array_vs_set.rb
Warming up --------------------------------------
array 188.441k i/100ms
set 229.531k i/100ms
Calculating -------------------------------------
array 3.508M (± 9.0%) i/s - 17.525M in 5.043058s
set 5.134M (± 7.6%) i/s - 25.707M in 5.038921s
```
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
meinac/fix_ambigious_exception_message_of_select_query_method
Fix ambigious error message of select query method [ci skip]
|
| | |/ /
| |/| | |
|
| |/ /
|/| |
| | |
| | | |
Fixes #29025.
|
|/ /
| |
| |
| |
| |
| | |
The argument of `Arel::SelectManager.new` is `table`, not `engine`.
https://github.com/rails/arel/blob/v8.0.0/lib/arel/select_manager.rb#L10
|
|\ \
| | |
| | | |
Mixin `CollectionProxy::DelegateExtending` after `ClassSpecificRelation`
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`ClassSpecificRelation` has `method_missing` and the `method_missing` is
called first. if an associated class has the missing method in a
relation, never reach to the `method_missing` in the `CollectionProxy`.
I extracted `DelegateExtending` and included it to the delegate class
that including `ClassSpecificRelation` to fix the issue.
Fixes https://github.com/rails/rails/pull/28246#issuecomment-296033784.
|
|/ /
| |
| |
| |
| |
| |
| | |
Follow up of 03d3f036.
Some of `respond_to?` were replaced to `respond_to_missing?` in 03d3f036.
But the visibility is still public. It should be private.
|
|\ \
| | |
| | | |
Rename `association_query_handler.rb` to `association_query_value.rb`
|
| | |
| | |
| | |
| | |
| | |
| | | |
Since `AssociationQueryHandler` and `PolymorphicArrayHandler` has
removed in #28715, only exists `AssociationQueryValue` and
`PolymorphicArrayValue` in these files.
|
|/ /
| |
| |
| | |
Partitioning to `values` and `nils` is unneeded before early return.
|
|\ \
| | |
| | |
| | |
| | | |
kamipo/convert_association_queries_to_poro_queries
Convert association queries to PORO queries
|
| | |
| | |
| | |
| | | |
association handling
|
| | | |
|
| | | |
|
| | | |
|
|\| |
| | |
| | | |
Expose `queries` for `AssociationQueryValue` and `PolymorphicArrayValue`
|
| | | |
|
| | |
| | |
| | |
| | | |
It should be handled by `PolymorphicArrayHandler` if polymorphic association.
|
| | |
| | |
| | |
| | | |
To ease to customize a relation for `exists?`.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit a680a5814184e2f37c4686aa53d0ad3c7fb6b1ee, reversing
changes made to 842f67dd242e738419f27e752ea7dcd0bbe87b6d.
Reason: I can't resist to the joke, so better to keep it there
https://github.com/rails/rails/pull/28598#issuecomment-290945339.
|
|/ /
| |
| |
| |
| |
| |
| | |
silly method gets a silly doc fix,
or I'm missing an even sillier joke and I'm about to get schooled.
BUT I'm pretty sure this is some serious Beaudrillard simulacrum, though.
I'm just doing my part to spread the gospel of Douglas Adams.
|
|\ \
| | |
| | | |
Preprocess association query handling in predicate builder
|
| | |
| | |
| | |
| | | |
Because `RelationHandler` uses `value.arel`.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Currently association query is handled as a postprocess. This has two
problems.
1. When `value` is a `Hash`, we need to skip the postprocess using
`next`.
2. `can_be_bound?` should return false if
`table.associated_with?(column_name)` is true (pass to the postprocess).
These are unneeded if preprocessing association query handling.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes a regression introduced in
22ca710f20c3c656811df006cbf1f4dbc359f7a6 where Relation#unscope with a
specific where value (vs unscoping the entire where clause) could result
in the wrong binds being left on the query.
This was caused by an index variable not being incremented properly.
|
|/ /
| |
| |
| |
| |
| |
| | |
Since b644964b `ActiveRecord::Relation` includes `Enumerable` so
delegating `collect`, `all?`, and `include?` are also unneeded.
`collect` without block returns `Enumerable` without preloading by that.
We should use `load` rather than `collect` for force loading.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes CI failure due to 48f3be8c.
`Enumerable#uniq` was introduced since Ruby 2.4. We should delegate
`uniq` to `records` explicitly.
And since b644964b `ActiveRecord::Relation` includes `Enumerable` so
delegating `map` is unneeded.
|
|\ \
| | |
| | | |
Allow order to be given expressions as hash keys
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When `order` is given a hash, the keys are currently assumed to be
attribute names and are quoted as such in the query, which makes it
impossible to pass an expression instead:
Post.order("LENGTH(title)" => :asc).last
# SELECT `posts`.* FROM `posts` ORDER BY `posts`.`LENGTH(title)` DESC LIMIT 1
If the key is an `Arel::Nodes::SqlLiteral`, we now use it directly in
the query. This provides a way to build a relation with a complex order
clause that can still be reversed with `reverse_order` or `last`.
|
|\ \ \
| | | |
| | | | |
Simply forward `Calculations#count` to `Enumerable#count`
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | | |
Follow up of #24203.
Since b644964b `ActiveRecord::Relation` includes `Enumerable` so it is
enough to call `super` simply.
|