Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Extract conditional to a method to avoid duplication | Rafael Mendonça França | 2012-06-19 | 1 | -15/+19 |
| | | | | Also use if/else block to not use short circuit return | ||||
* | handle joins/includes correctly for pluck and calculation. | Andrey Deryabin | 2012-06-19 | 1 | -1/+6 |
| | | | | Fix #5990 | ||||
* | Removing composed_of from ActiveRecord. | Steve Klabnik | 2012-06-18 | 1 | -2/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This feature adds a lot of complication to ActiveRecord for dubious value. Let's talk about what it does currently: class Customer < ActiveRecord::Base composed_of :balance, :class_name => "Money", :mapping => %w(balance amount) end Instead, you can do something like this: def balance @balance ||= Money.new(value, currency) end def balance=(balance) self[:value] = balance.value self[:currency] = balance.currency @balance = balance end Since that's fairly easy code to write, and doesn't need anything extra from the framework, if you use composed_of today, you'll have to add accessors/mutators like that. Closes #1436 Closes #2084 Closes #3807 | ||||
* | Documentation for where and where! methods on relations. | David Paschich | 2012-06-18 | 1 | -0/+92 |
| | | | | Based on examples seen in the Rails test suite. [ci skip] | ||||
* | Address ORA-00911 errors because of the heading underscore. | Yasuo Honda | 2012-06-11 | 1 | -1/+1 |
| | |||||
* | Fix that #exists? raises ThrowResult when called with an empty limited | Ben Woosley | 2012-06-10 | 1 | -0/+2 |
| | | | | | | | | | reflection. ActiveRecord::FinderMethods#construct_limited_ids_condition will raise ThrowResult if the limited reflection comes back empty. The other callers of #construct_limited_ids_condition handle this exception (more specifically, the callers of construct_relation_for*), but #exists? didn't until now. | ||||
* | Add test to column alias in `exists?` SQL. | Rafael Mendonça França | 2012-06-10 | 1 | -1/+1 |
| | | | | | | | | This behavior was added in be4ecdcc87984e9421ff5d5c90d33f475e0fbc01. Closes #1139. Fixes #2553, #1141, #1623 and #2062. | ||||
* | Minimal change to query generation of exists? that makes SQLServer and ↵ | iaddict | 2012-06-10 | 1 | -1/+1 |
| | | | | | | | others happy that do not work without a column alias. Conflicts: activerecord/lib/active_record/relation/finder_methods.rb | ||||
* | Fix #6635. We should call Scoping methods, before calling Array methods. | kennyj | 2012-06-10 | 1 | -5/+5 |
| | |||||
* | Remove conditional committed by accident | Santiago Pastorino | 2012-06-09 | 1 | -1/+1 |
| | |||||
* | Use each_with_object instead of each here | Santiago Pastorino | 2012-06-09 | 1 | -1/+1 |
| | |||||
* | modulize AR::NullRelation | Akira Matsuda | 2012-06-01 | 1 | -1/+1 |
| | | | | now we can invoke previously added scope extension methods | ||||
* | Merge branch 'master-sec' | Aaron Patterson | 2012-05-31 | 1 | -1/+1 |
|\ | | | | | | | | | | | * master-sec: Strip [nil] from parameters hash. Thanks to Ben Murphy for reporting this! predicate builder should not recurse for determining where columns. Thanks to Ben Murphy for reporting this | ||||
| * | predicate builder should not recurse for determining where columns. | Aaron Patterson | 2012-05-30 | 1 | -1/+1 |
| | | | | | | | | | | | | Thanks to Ben Murphy for reporting this CVE-2012-2661 | ||||
* | | Fix wrong example for count method with block [ci skip] | Carlos Antonio da Silva | 2012-05-31 | 1 | -1/+1 |
| | | | | | | | | Thanks @splattael. | ||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-30 | 3 | -22/+32 |
|\ \ | |||||
| * | | copy edit the batches docs [ci skip] | Vijay Dev | 2012-05-30 | 1 | -9/+7 |
| | | | |||||
| * | | Adds to Batch processing documentation [ci skip] | Alvaro Pereyra | 2012-05-28 | 1 | -9/+20 |
| | | | |||||
| * | | fix typo and remove 'examples' noise [ci skip] | Francesco Rodriguez | 2012-05-28 | 1 | -18/+6 |
| | | | |||||
| * | | Updates examples for FinderMethods [ci skip] | Alvaro Pereyra | 2012-05-28 | 1 | -2/+14 |
| | | | |||||
| * | | Merge branch 'master' of github.com:lifo/docrails | Alvaro Pereyra | 2012-05-28 | 4 | -1/+9 |
| |\ \ | |||||
| | * | | "a sql" -> "an SQL" per API documentation guidelines | Mark Rushakoff | 2012-05-27 | 1 | -1/+1 |
| | |/ | |||||
| * | | Adds examples to FinderMethods#first [ci skip] | Alvaro Pereyra | 2012-05-28 | 1 | -0/+1 |
| | | | |||||
| * | | Remove blank trailing comments | Henrik Hodne | 2012-05-20 | 4 | -8/+0 |
| |/ | | | | | | | | | | | | | For future reference, this is the regex I used: ^\s*#\s*\n(?!\s*#). Replace with the first match, and voilà! Note that the regex matches a little bit too much, so you probably want to `git add -i .` and go through every single diff to check if it actually should be changed. | ||||
* | | Yield only one argument instead of splatting. | Carlos Antonio da Silva | 2012-05-28 | 1 | -2/+2 |
| | | | | | | | | Add Changelog entry. Closes #4003 | ||||
* | | Allow blocks for count with ActiveRecord::Relation. Document and test that ↵ | chrisfinne | 2012-05-28 | 1 | -3/+14 |
|/ | | | | sum allows blocks | ||||
* | Relation#from to accept other Relation objects | Radoslav Stankov | 2012-05-17 | 2 | -6/+31 |
| | | | | Record.from("(#{sub_query.to_sql})") -> Record.from(sub_query) Record.from("(#{sub_query.to_sql}) a") -> Record.from(sub_query, :a) | ||||
* | assuming there is only one column, we can simplify the type cast loop | Aaron Patterson | 2012-05-16 | 1 | -7/+6 |
| | |||||
* | MySQL returns "SUM(DISTINCT(credit_limit))" as the column name unless | Aaron Patterson | 2012-05-16 | 1 | -4/+11 |
| | | | | | an alias is provided. Without the alias, the column cannot be found and properly typecast. | ||||
* | Fixes issue where SQL fragments prevented type casting based on column type. | Erich Menge | 2012-05-16 | 1 | -8/+3 |
| | |||||
* | Expand and improve #pluck docs | Jeremy Kemper | 2012-05-15 | 1 | -6/+27 |
| | |||||
* | Restore support for Model.pluck('sql fragment') | Jeremy Kemper | 2012-05-15 | 1 | -1/+2 |
| | |||||
* | CollectionProxy < Relation | Jon Leighton | 2012-05-11 | 3 | -28/+33 |
| | | | | | | | | | | | | | | | | | | | | | This helps bring the interfaces of CollectionProxy and Relation closer together, and reduces the delegation backflips we need to perform. For example, first_or_create is defined thus: class ActiveRecord::Relation def first_or_create(...) first || create(...) end end If CollectionProxy < Relation, then post.comments.first_or_create will hit the association's #create method which will actually add the new record to the association, just as post.comments.create would. With the previous delegation, post.comments.first_or_create expands to post.comments.scoped.first_or_create, where post.comments.scoped has no knowledge of the association. | ||||
* | Return false for exists? with new records - fixes #6199. | Andrew White | 2012-05-10 | 1 | -2/+1 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-08 | 1 | -2/+2 |
|\ | |||||
| * | SpawnMethods#merge returns the intersection when passed an array, and not ↵ | Mitch Crowe | 2012-05-05 | 1 | -2/+2 |
| | | | | | | | | the union. Update the documentation to reflect this. | ||||
* | | Use `take` instead of `first` to avoid unwanted implicit ordering (fixes #6147) | Marcelo Silveira | 2012-05-05 | 1 | -4/+4 |
|/ | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-04 | 1 | -1/+1 |
|\ | |||||
| * | Lowercase. | Ben Pickles | 2012-05-01 | 1 | -1/+1 |
| | | |||||
* | | clean up implementation of dynamic methods. use method compilation etc. | Jon Leighton | 2012-05-04 | 1 | -41/+0 |
| | | |||||
* | | Use arel nodes instead of raw sql | Marcelo Silveira | 2012-05-02 | 1 | -3/+3 |
| | | |||||
* | | Use Array#first instead of Array#[0] | Marcelo Silveira | 2012-05-02 | 1 | -5/+5 |
| | | |||||
* | | Introducing `take` as a replacement to the old behavior of `first` | Marcelo Silveira | 2012-05-02 | 1 | -0/+27 |
| | | |||||
* | | Document `last`, check for primary key on default order and use quoted table ↵ | Marcelo Silveira | 2012-05-02 | 1 | -2/+5 |
| | | | | | | | | and column names | ||||
* | | Made `first` finder consistent among database engines by adding a | Marcelo Silveira | 2012-05-02 | 1 | -2/+18 |
|/ | | | | default order clause (fixes #5103) | ||||
* | return value of block is returned | Aaron Patterson | 2012-04-30 | 1 | -2/+5 |
| | |||||
* | only yield to finder block if something is found | Aaron Patterson | 2012-04-30 | 1 | -1/+1 |
| | |||||
* | Add ActiveRecord::Base#ids | twinturbo | 2012-04-30 | 1 | -0/+10 |
| | |||||
* | fix interpolation for hash merging | Jon Leighton | 2012-04-25 | 2 | -20/+26 |
| | |||||
* | allow merging a single where value | Jon Leighton | 2012-04-25 | 1 | -1/+1 |
| |