aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/relation
Commit message (Collapse)AuthorAgeFilesLines
* Refactor finder conditions look up and assigment for apply_finder_conditions.Emilio Tagua2010-09-091-13/+7
|
* Refactor Relation#only. No need to go through every option and test it.Emilio Tagua2010-09-091-8/+6
|
* No need to go through every option and test it, just don't add skipped ones.Emilio Tagua2010-09-091-4/+4
|
* return is not needed hereNeeraj Singh2010-09-091-2/+2
|
* remove unnecessary callNeeraj Singh2010-09-091-1/+0
| | | | if operation is count then column_name will never be blank
* creating a new array is required. who knew? :-(Aaron Patterson2010-09-091-1/+1
|
* no need for Array.wrap, also avoid array creationAaron Patterson2010-09-091-5/+4
|
* make apply_modules run fasterNeeraj Singh2010-09-091-3/+5
|
* eliminate present? for fewer method callsAaron Patterson2010-09-081-10/+2
|
* returning arrays lets us avoid Array.wrapAaron Patterson2010-09-081-4/+4
|
* removing unnecessary conditional testAaron Patterson2010-09-081-4/+4
|
* switch to blank? to avoid method callsAaron Patterson2010-09-081-6/+6
|
* refactor to use faster empty?Aaron Patterson2010-09-081-1/+3
|
* drying up joins()Aaron Patterson2010-09-081-4/+2
|
* reduce method calls, use reject + blank? instead of select + present?Aaron Patterson2010-09-081-3/+3
|
* attributes should be constructed with table objectsAaron Patterson2010-09-071-1/+1
|
* attributes should be associated with tablesAaron Patterson2010-09-071-1/+1
|
* removing useless code, cleaning variable namesAaron Patterson2010-09-071-6/+2
|
* select should raise error when no block or no parameter is passedAaron Patterson2010-09-071-3/+3
|
* select does not need a *argsAaron Patterson2010-09-071-2/+2
|
* cleaning up confusing logicAaron Patterson2010-09-061-3/+6
|
* Make scoped reorder override previous applied ordersSantiago Pastorino2010-09-052-3/+15
| | | | [5528 state:committed]
* order should always be concatenated.Neeraj Singh2010-09-051-2/+1
| | | | | | | | | | | | | | | | | | | | | | order that is declared first has highest priority in all cases. Here are some examples. Car.order('name desc').find(:first, :order => 'id').name Car.named_scope_with_order.named_scope_with_another_order Car.order('id DESC').scoping do Car.find(:first, :order => 'id asc') end No special treatment to with_scope or scoping. Also note that if default_scope declares an order then the order declared in default_scope has the highest priority unless with_exclusive_scope is used. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Use new finders syntax in docs.Emilio Tagua2010-09-012-18/+18
|
* Make all the Relation finder methods consistentPratik Naik2010-08-311-32/+67
|
* Merge remote branch 'miloops/rails_master_fixes'Pratik Naik2010-08-311-15/+26
|\
| * Avoid calling build_where is no argument is given.Emilio Tagua2010-08-311-1/+1
| |
| * Improved conditionals usage to prevent calling methods.Emilio Tagua2010-08-311-8/+19
| |
| * Don't test conditional in iteration if it is not present just clone it.Emilio Tagua2010-08-311-9/+9
| |
* | Remove default values for Relation#limit/offset/from/create_withPratik Naik2010-08-311-4/+4
| |
* | Change relation merging to always append select, group and order valuesPratik Naik2010-08-311-7/+10
|/
* PERF: Avoid two method callsSantiago Pastorino2010-08-281-1/+1
|
* Merge remote branch 'docrails/master'Xavier Noria2010-08-261-8/+6
|\
| * minor formatting fixesNeeraj Singh2010-08-251-8/+6
| |
* | use blank? instead of present?, mark SQL literals as SQL literalsAaron Patterson2010-08-251-5/+5
| | | | | | | | | | | | Conflicts: activerecord/lib/active_record/relation/query_methods.rb
* | no need to send on a public methodAaron Patterson2010-08-251-1/+1
| |
* | refactor select { is_a? } to grep()Aaron Patterson2010-08-251-1/+1
|/
* sql literal strings should be marked as sql literal stringsAaron Patterson2010-08-231-1/+3
|
* we should wrap strings as sql literalsAaron Patterson2010-08-191-1/+1
|
* refactoring to remove duplicate logicAaron Patterson2010-08-181-4/+3
|
* call to present? is not necessaryAaron Patterson2010-08-181-2/+1
|
* Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵Santiago Pastorino2010-08-143-34/+34
| | | | 's/[ \t]*$//' -i {} \;)
* Removing most of the symbol to proc usage in Active RecordPrem Sichanugrist2010-08-131-1/+1
| | | | This will hopefully make Active Record run a bit more faster.
* avoid direct use of arel constantsAaron Patterson2010-08-131-2/+4
|
* Ensure we can nest include calls [#5285 state:resolved]Neeraj Singh2010-08-122-2/+8
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* subtracting blank strings is slightly faster than blank?Aaron Patterson2010-08-111-3/+1
|
* avoid multiple hash lookupsAaron Patterson2010-08-111-2/+6
|
* avoiding tap saves us timeAaron Patterson2010-08-111-2/+6
|
* unless Array#empty? is faster than if Array#present?Aaron Patterson2010-08-111-1/+1
|
* stop using private methodsAaron Patterson2010-08-111-2/+2
|