Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fixes bug in ActiveRecord::QueryMethods, #1697 | Joshua Wehner | 2011-08-31 | 1 | -4/+2 |
| | | | Replace split on comma with a regexp that will reverse all ASC/DESC specifically | ||||
* | The join_nodes must be passed to the JoinDependency initializer and ↵ | Jon Leighton | 2011-08-29 | 1 | -7/+2 |
| | | | | therefore counted by the alias tracker. This is because the association_joins are aliased on initialization and then the tables are cached, so it is no use to alias the join_nodes later. Fixes #2556. | ||||
* | Revert "Merge pull request #2309 from smasry/master" | Jon Leighton | 2011-07-28 | 1 | -1/+1 |
| | | | | | | | This reverts commit 9d396ee8195e31f646e0b89158ed96f4db4ab38f, reversing changes made to fa2bfd832c1d1e997d93c2269a485cc74782c86d. Reason: the change broke the build. | ||||
* | Reverse order fix when using function for ActiveRecord::QueryMethods Fixes #1697 | Samer Masry | 2011-07-27 | 1 | -1/+1 |
| | |||||
* | Revert "allow select to have multiple arguments" | Piotr Sarnacki | 2011-07-26 | 1 | -6/+3 |
| | | | | | | | This reverts commit 04cc446d178653d362510e79a22db5300d463161. I reverted it because apparently we want to use: select([:a, :b]) instead of select(:a, :b), but there was no tests for that form. | ||||
* | allow select to have multiple arguments | Sławosz Sławiński | 2011-07-26 | 1 | -3/+6 |
| | |||||
* | Ordering with extra spaces was raising a SQL exception | Franck Verrot | 2011-07-24 | 1 | -0/+1 |
| | |||||
* | fix AR having() not to raise NoMethodError when the given argument does not ↵ | Akira Matsuda | 2011-07-09 | 1 | -3/+3 |
| | | | | | | respond to empty? having raises NoMethodError: undefined method `empty?' when a Fixnum or Date/Time were passed via varargs | ||||
* | Remove case statement changes from 2e0840d and 56ac32a. Inheritance FTW. | Ernie Miller | 2011-07-06 | 1 | -1/+1 |
| | |||||
* | Fix case | Oriol Gual | 2011-06-28 | 1 | -2/+1 |
| | |||||
* | Update reverse order with new Arel Nodes | Oriol Gual | 2011-06-28 | 1 | -1/+2 |
| | |||||
* | default create_with_value to a hash so we can eliminate conditionals, add ↵ | Aaron Patterson | 2011-06-27 | 1 | -1/+1 |
| | | | | test surrounding create_with(nil) behavior | ||||
* | Support reversal of ARel orderings in reverse_sql_order | Ernie Miller | 2011-06-20 | 1 | -3/+12 |
| | |||||
* | Fix issue #1272 | Brian Mathiyakom | 2011-06-01 | 1 | -8/+7 |
| | | | | | Set reverse_order_value when asked to reverse_order(). Do the actual reversal in build_arel. | ||||
* | Evaluate default scopes at the last possible moment in order to avoid ↵ | Jon Leighton | 2011-04-12 | 1 | -4/+10 |
| | | | | problems with default scopes getting included into other scopes and then being unable to remove the default part via unscoped. | ||||
* | Bring #reorder back | Sebastian Martinez | 2011-03-28 | 1 | -0/+4 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Resolve some TODO comments which I decided did not need anything done | Jon Leighton | 2011-03-12 | 1 | -1/+0 |
| | |||||
* | Merge branch 'master' into nested_has_many_through | Jon Leighton | 2011-03-04 | 1 | -37/+41 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/CHANGELOG activerecord/lib/active_record/association_preload.rb activerecord/lib/active_record/associations.rb activerecord/lib/active_record/associations/class_methods/join_dependency.rb activerecord/lib/active_record/associations/class_methods/join_dependency/join_association.rb activerecord/lib/active_record/associations/has_many_association.rb activerecord/lib/active_record/associations/has_many_through_association.rb activerecord/lib/active_record/associations/has_one_association.rb activerecord/lib/active_record/associations/has_one_through_association.rb activerecord/lib/active_record/associations/through_association_scope.rb activerecord/lib/active_record/reflection.rb activerecord/test/cases/associations/has_many_through_associations_test.rb activerecord/test/cases/associations/has_one_through_associations_test.rb activerecord/test/cases/reflection_test.rb activerecord/test/cases/relations_test.rb activerecord/test/fixtures/memberships.yml activerecord/test/models/categorization.rb activerecord/test/models/category.rb activerecord/test/models/member.rb activerecord/test/models/reference.rb activerecord/test/models/tagging.rb | ||||
| * | Move JoinDependency and friends from ↵ | Jon Leighton | 2011-02-28 | 1 | -2/+2 |
| | | | | | | | | ActiveRecord::Associations::ClassMethods to just ActiveRecord::Associations | ||||
| * | use an attribute rather than a SQL literal | Aaron Patterson | 2011-02-26 | 1 | -1/+1 |
| | | |||||
| * | explicitly allowing lolqueries | Aaron Patterson | 2011-02-16 | 1 | -10/+1 |
| | | |||||
| * | limit() should sanitize limit values | Aaron Patterson | 2011-02-08 | 1 | -1/+1 |
| | | | | | | | | This fixes CVE-2011-0448 | ||||
| * | ActiveRecord::Relation#primary_key should return a string, just like ↵ | Jon Leighton | 2011-01-03 | 1 | -1/+1 |
| | | | | | | | | ActiveRecord::Base.primary_key does. | ||||
| * | Make Relation#create_with always merge rather than overwrite, not just when ↵ | Jon Leighton | 2011-01-03 | 1 | -1/+1 |
| | | | | | | | | merging two relations. If you wish to overwrite, you can do relation.create_with(nil), or for a specific attribute, relation.create_with(:attr => nil). | ||||
| * | ActiveRecord::Base.joins should allow single nil argument [#6181 state:resolved] | Piotr Sarnacki | 2010-12-16 | 1 | -1/+1 |
| | | |||||
| * | make sure that join nodes are uniq | Aaron Patterson | 2010-12-16 | 1 | -1/+1 |
| | | |||||
| * | supporting arel AST nodes when building join statements | Aaron Patterson | 2010-12-16 | 1 | -3/+15 |
| | | |||||
| * | bucketing based on join type | Aaron Patterson | 2010-12-16 | 1 | -8/+17 |
| | | |||||
| * | taking advantage of the JoinSource node in the SQL AST | Aaron Patterson | 2010-12-16 | 1 | -16/+7 |
| | | |||||
| * | remove lasgn since AST is mutated | Aaron Patterson | 2010-12-16 | 1 | -1/+1 |
| | | |||||
| * | just mutate the ast, fewer lasgns | Aaron Patterson | 2010-12-16 | 1 | -3/+2 |
| | | |||||
* | | remove lasgn since AST is mutated | Aaron Patterson | 2010-12-10 | 1 | -1/+1 |
| | | |||||
* | | just mutate the ast, fewer lasgns | Aaron Patterson | 2010-12-10 | 1 | -3/+2 |
|/ | |||||
* | no more manager manipulation if there is no custom join ast | Aaron Patterson | 2010-12-10 | 1 | -6/+5 |
| | |||||
* | froms should never equal 0 | Aaron Patterson | 2010-12-10 | 1 | -2/+0 |
| | |||||
* | manager will always be a manager | Aaron Patterson | 2010-12-10 | 1 | -10/+6 |
| | |||||
* | eliminate lasgns | Aaron Patterson | 2010-12-10 | 1 | -10/+10 |
| | |||||
* | dealing with an AST manager, not a relation, so fix the variable names | Aaron Patterson | 2010-12-10 | 1 | -12/+12 |
| | |||||
* | adding a fixme comment | Aaron Patterson | 2010-12-08 | 1 | -0/+1 |
| | |||||
* | renaming variables, making the join_ast method private | Aaron Patterson | 2010-12-08 | 1 | -51/+27 |
| | |||||
* | further reducing dependence on custom_joins | Aaron Patterson | 2010-12-08 | 1 | -0/+2 |
| | |||||
* | reducing use of custom joins | Aaron Patterson | 2010-12-08 | 1 | -1/+6 |
| | |||||
* | passing the ast to a table when the relation is a table | Aaron Patterson | 2010-12-07 | 1 | -3/+20 |
| | |||||
* | JoinDependency is always created with an AST now | Aaron Patterson | 2010-12-07 | 1 | -1/+15 |
| | |||||
* | cleaning up custom_join_sql method | Aaron Patterson | 2010-12-07 | 1 | -4/+6 |
| | |||||
* | fix warnings, stop using global variables | Aaron Patterson | 2010-11-30 | 1 | -4/+2 |
| | |||||
* | stop using splat args when we do not need them | Aaron Patterson | 2010-11-30 | 1 | -2/+2 |
| | |||||
* | reduce method calls on arel | Aaron Patterson | 2010-11-30 | 1 | -1/+1 |
| | |||||
* | skip cloning if arguments are blank | Aaron Patterson | 2010-11-22 | 1 | -8/+22 |
| | |||||
* | group can be done by left side only | Aaron Patterson | 2010-11-17 | 1 | -6/+3 |
| |