Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Refactor JoinDependency and friends so that a JoinAssociation can produce an ↵ | Jon Leighton | 2010-10-13 | 1 | -12/+1 |
| | | | | arbitrary number of joins, which will be needed in order to support nested through associations. | ||||
* | reorder removed in favor of except(:order).order | Santiago Pastorino | 2010-10-11 | 1 | -10/+1 |
| | |||||
* | avoid creating objects when we can | Aaron Patterson | 2010-10-03 | 1 | -1/+1 |
| | |||||
* | build_where should be private | Aaron Patterson | 2010-09-30 | 1 | -2/+2 |
| | |||||
* | removing more useless code! yay! | Aaron Patterson | 2010-09-28 | 1 | -6/+2 |
| | |||||
* | SqlLiteral is a string, so we can dry up these conditionals | Aaron Patterson | 2010-09-28 | 1 | -4/+3 |
| | |||||
* | shorten up or sql literal creation statements | Aaron Patterson | 2010-09-28 | 1 | -4/+2 |
| | |||||
* | we only care about arrays and strings | Aaron Patterson | 2010-09-28 | 1 | -1/+1 |
| | |||||
* | dry up calls to arel.join() | Aaron Patterson | 2010-09-28 | 1 | -5/+4 |
| | |||||
* | removing unused lasgns | Aaron Patterson | 2010-09-28 | 1 | -4/+4 |
| | |||||
* | refactoring to remove crazy logic | Aaron Patterson | 2010-09-28 | 1 | -8/+1 |
| | |||||
* | performance improvement based on discussion at ↵ | Neeraj Singh | 2010-09-28 | 1 | -9/+3 |
| | | | | | | http://github.com/rails/rails/commit/fbd1d306b95cc2efb6422e12d26d5818a3a42343 Credit goes to all the participants in the discussion | ||||
* | removing a conditional that is not used | Aaron Patterson | 2010-09-28 | 1 | -2/+0 |
| | |||||
* | avoid calling to_sql when we can | Aaron Patterson | 2010-09-28 | 1 | -1/+1 |
| | |||||
* | make sure we use the engine assigned to the table when quoting | Aaron Patterson | 2010-09-27 | 1 | -1/+1 |
| | |||||
* | Three performance improvements: | Neeraj Singh | 2010-09-27 | 1 | -10/+9 |
| | | | | | | | | * for simple cases like User.last and User.order('name desc').last no need to perform Array#join operation. * Instead of performing String#blank? do Array#empty? * no need to create variable relation | ||||
* | adds to the API guidelines the proper spelling of Arel | Xavier Noria | 2010-09-19 | 1 | -2/+2 |
| | |||||
* | @join_values is passed in, so we should use the parameter | Aaron Patterson | 2010-09-15 | 1 | -1/+1 |
| | |||||
* | creating a new array is required. who knew? :-( | Aaron Patterson | 2010-09-09 | 1 | -1/+1 |
| | |||||
* | no need for Array.wrap, also avoid array creation | Aaron Patterson | 2010-09-09 | 1 | -5/+4 |
| | |||||
* | make apply_modules run faster | Neeraj Singh | 2010-09-09 | 1 | -3/+5 |
| | |||||
* | eliminate present? for fewer method calls | Aaron Patterson | 2010-09-08 | 1 | -10/+2 |
| | |||||
* | returning arrays lets us avoid Array.wrap | Aaron Patterson | 2010-09-08 | 1 | -4/+4 |
| | |||||
* | removing unnecessary conditional test | Aaron Patterson | 2010-09-08 | 1 | -4/+4 |
| | |||||
* | switch to blank? to avoid method calls | Aaron Patterson | 2010-09-08 | 1 | -6/+6 |
| | |||||
* | refactor to use faster empty? | Aaron Patterson | 2010-09-08 | 1 | -1/+3 |
| | |||||
* | drying up joins() | Aaron Patterson | 2010-09-08 | 1 | -4/+2 |
| | |||||
* | reduce method calls, use reject + blank? instead of select + present? | Aaron Patterson | 2010-09-08 | 1 | -3/+3 |
| | |||||
* | removing useless code, cleaning variable names | Aaron Patterson | 2010-09-07 | 1 | -6/+2 |
| | |||||
* | select should raise error when no block or no parameter is passed | Aaron Patterson | 2010-09-07 | 1 | -3/+3 |
| | |||||
* | select does not need a *args | Aaron Patterson | 2010-09-07 | 1 | -2/+2 |
| | |||||
* | cleaning up confusing logic | Aaron Patterson | 2010-09-06 | 1 | -3/+6 |
| | |||||
* | Make scoped reorder override previous applied orders | Santiago Pastorino | 2010-09-05 | 1 | -2/+5 |
| | | | | [5528 state:committed] | ||||
* | Make all the Relation finder methods consistent | Pratik Naik | 2010-08-31 | 1 | -32/+67 |
| | |||||
* | Merge remote branch 'miloops/rails_master_fixes' | Pratik Naik | 2010-08-31 | 1 | -15/+26 |
|\ | |||||
| * | Avoid calling build_where is no argument is given. | Emilio Tagua | 2010-08-31 | 1 | -1/+1 |
| | | |||||
| * | Improved conditionals usage to prevent calling methods. | Emilio Tagua | 2010-08-31 | 1 | -8/+19 |
| | | |||||
| * | Don't test conditional in iteration if it is not present just clone it. | Emilio Tagua | 2010-08-31 | 1 | -9/+9 |
| | | |||||
* | | Remove default values for Relation#limit/offset/from/create_with | Pratik Naik | 2010-08-31 | 1 | -4/+4 |
|/ | |||||
* | use blank? instead of present?, mark SQL literals as SQL literals | Aaron Patterson | 2010-08-25 | 1 | -5/+5 |
| | | | | | | Conflicts: activerecord/lib/active_record/relation/query_methods.rb | ||||
* | no need to send on a public method | Aaron Patterson | 2010-08-25 | 1 | -1/+1 |
| | |||||
* | refactor select { is_a? } to grep() | Aaron Patterson | 2010-08-25 | 1 | -1/+1 |
| | |||||
* | sql literal strings should be marked as sql literal strings | Aaron Patterson | 2010-08-23 | 1 | -1/+3 |
| | |||||
* | we should wrap strings as sql literals | Aaron Patterson | 2010-08-19 | 1 | -1/+1 |
| | |||||
* | Ensure we can nest include calls [#5285 state:resolved] | Neeraj Singh | 2010-08-12 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | subtracting blank strings is slightly faster than blank? | Aaron Patterson | 2010-08-11 | 1 | -3/+1 |
| | |||||
* | avoiding tap saves us time | Aaron Patterson | 2010-08-11 | 1 | -2/+6 |
| | |||||
* | unless Array#empty? is faster than if Array#present? | Aaron Patterson | 2010-08-11 | 1 | -1/+1 |
| | |||||
* | avoid passing lists of lists to the group clause | Aaron Patterson | 2010-08-04 | 1 | -1/+1 |
| | |||||
* | order query is already a string, no need to to_s | Aaron Patterson | 2010-08-03 | 1 | -2/+2 |
| |