Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | creating a new array is required. who knew? :-( | Aaron Patterson | 2010-09-09 | 1 | -1/+1 |
| | |||||
* | no need for Array.wrap, also avoid array creation | Aaron Patterson | 2010-09-09 | 1 | -5/+4 |
| | |||||
* | make apply_modules run faster | Neeraj Singh | 2010-09-09 | 1 | -3/+5 |
| | |||||
* | eliminate present? for fewer method calls | Aaron Patterson | 2010-09-08 | 1 | -10/+2 |
| | |||||
* | returning arrays lets us avoid Array.wrap | Aaron Patterson | 2010-09-08 | 1 | -4/+4 |
| | |||||
* | removing unnecessary conditional test | Aaron Patterson | 2010-09-08 | 1 | -4/+4 |
| | |||||
* | switch to blank? to avoid method calls | Aaron Patterson | 2010-09-08 | 1 | -6/+6 |
| | |||||
* | refactor to use faster empty? | Aaron Patterson | 2010-09-08 | 1 | -1/+3 |
| | |||||
* | drying up joins() | Aaron Patterson | 2010-09-08 | 1 | -4/+2 |
| | |||||
* | reduce method calls, use reject + blank? instead of select + present? | Aaron Patterson | 2010-09-08 | 1 | -3/+3 |
| | |||||
* | removing useless code, cleaning variable names | Aaron Patterson | 2010-09-07 | 1 | -6/+2 |
| | |||||
* | select should raise error when no block or no parameter is passed | Aaron Patterson | 2010-09-07 | 1 | -3/+3 |
| | |||||
* | select does not need a *args | Aaron Patterson | 2010-09-07 | 1 | -2/+2 |
| | |||||
* | cleaning up confusing logic | Aaron Patterson | 2010-09-06 | 1 | -3/+6 |
| | |||||
* | Make scoped reorder override previous applied orders | Santiago Pastorino | 2010-09-05 | 1 | -2/+5 |
| | | | | [5528 state:committed] | ||||
* | Make all the Relation finder methods consistent | Pratik Naik | 2010-08-31 | 1 | -32/+67 |
| | |||||
* | Merge remote branch 'miloops/rails_master_fixes' | Pratik Naik | 2010-08-31 | 1 | -15/+26 |
|\ | |||||
| * | Avoid calling build_where is no argument is given. | Emilio Tagua | 2010-08-31 | 1 | -1/+1 |
| | | |||||
| * | Improved conditionals usage to prevent calling methods. | Emilio Tagua | 2010-08-31 | 1 | -8/+19 |
| | | |||||
| * | Don't test conditional in iteration if it is not present just clone it. | Emilio Tagua | 2010-08-31 | 1 | -9/+9 |
| | | |||||
* | | Remove default values for Relation#limit/offset/from/create_with | Pratik Naik | 2010-08-31 | 1 | -4/+4 |
|/ | |||||
* | use blank? instead of present?, mark SQL literals as SQL literals | Aaron Patterson | 2010-08-25 | 1 | -5/+5 |
| | | | | | | Conflicts: activerecord/lib/active_record/relation/query_methods.rb | ||||
* | no need to send on a public method | Aaron Patterson | 2010-08-25 | 1 | -1/+1 |
| | |||||
* | refactor select { is_a? } to grep() | Aaron Patterson | 2010-08-25 | 1 | -1/+1 |
| | |||||
* | sql literal strings should be marked as sql literal strings | Aaron Patterson | 2010-08-23 | 1 | -1/+3 |
| | |||||
* | we should wrap strings as sql literals | Aaron Patterson | 2010-08-19 | 1 | -1/+1 |
| | |||||
* | Ensure we can nest include calls [#5285 state:resolved] | Neeraj Singh | 2010-08-12 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | subtracting blank strings is slightly faster than blank? | Aaron Patterson | 2010-08-11 | 1 | -3/+1 |
| | |||||
* | avoiding tap saves us time | Aaron Patterson | 2010-08-11 | 1 | -2/+6 |
| | |||||
* | unless Array#empty? is faster than if Array#present? | Aaron Patterson | 2010-08-11 | 1 | -1/+1 |
| | |||||
* | avoid passing lists of lists to the group clause | Aaron Patterson | 2010-08-04 | 1 | -1/+1 |
| | |||||
* | order query is already a string, no need to to_s | Aaron Patterson | 2010-08-03 | 1 | -2/+2 |
| | |||||
* | reverting where() functionality, adding a test | Aaron Patterson | 2010-07-30 | 1 | -4/+4 |
| | |||||
* | fewer method calls, using faster methods when possible | Aaron Patterson | 2010-07-30 | 1 | -5/+5 |
| | |||||
* | reducing function calls and using faster methods for testing | Aaron Patterson | 2010-07-30 | 1 | -9/+3 |
| | |||||
* | got the ternary backwards. somehow the sqlite tests passed! | Aaron Patterson | 2010-07-29 | 1 | -1/+1 |
| | |||||
* | PERF: avoiding splat args and reducing function calls | Aaron Patterson | 2010-07-29 | 1 | -8/+5 |
| | |||||
* | Shouldn't have committed this! Revert "avoid calling to_sql twice" | Aaron Patterson | 2010-07-28 | 1 | -7/+4 |
| | | | | This reverts commit 1c030a3c3c61d6d6262785bf67e1d8f44da87ea5. | ||||
* | avoid calling to_sql twice | Aaron Patterson | 2010-07-28 | 1 | -4/+7 |
| | |||||
* | Revert "Style fixes" | Pratik Naik | 2010-07-15 | 1 | -20/+20 |
| | | | | This reverts commit 3c300b31219f2af3ecd46ef22b04e5c5548db899. | ||||
* | Style fixes | wycats | 2010-07-14 | 1 | -20/+20 |
| | |||||
* | Style fixes | Pratik Naik | 2010-07-14 | 1 | -20/+20 |
| | |||||
* | Add scoping and unscoped as the syntax to replace the old with_scope and ↵ | José Valim | 2010-06-29 | 1 | -2/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with_exclusive_scope. A few examples: * with_scope now should be scoping: Before: Comment.with_scope(:find => { :conditions => { :post_id => 1 } }) do Comment.first #=> SELECT * FROM comments WHERE post_id = 1 end After: Comment.where(:post_id => 1).scoping do Comment.first #=> SELECT * FROM comments WHERE post_id = 1 end * with_exclusive_scope now should be unscoped: class Post < ActiveRecord::Base default_scope :published => true end Post.all #=> SELECT * FROM posts WHERE published = true Before: Post.with_exclusive_scope do Post.all #=> SELECT * FROM posts end After: Post.unscoped do Post.all #=> SELECT * FROM posts end Notice you can also use unscoped without a block and it will return an anonymous scope with default_scope values: Post.unscoped.all #=> SELECT * FROM posts | ||||
* | Remove unneeded reject | Santiago Pastorino | 2010-06-28 | 1 | -8/+1 |
| | |||||
* | Refactor: metaprogramming here it's confusing and make use of tap | Santiago Pastorino | 2010-06-26 | 1 | -64/+73 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Removes useless flatten | Santiago Pastorino | 2010-06-26 | 1 | -4/+9 |
| | |||||
* | Create a little bit less objects in ARel. | José Valim | 2010-06-26 | 1 | -6/+9 |
| | |||||
* | blocks removed from all the ActiveRelation query_methods, extend method ↵ | Santiago Pastorino | 2010-06-26 | 1 | -8/+4 |
| | | | | | | added instead Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | reorder method added to ActiveRelation | Santiago Pastorino | 2010-06-26 | 1 | -0/+8 |
| | | | | | | [#4972 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Support for multiple selects added | Neeraj Singh and Santiago Pastorino | 2010-06-25 | 1 | -4/+7 |
| | | | | [#4841 state:committed] |