Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Make scoped reorder override previous applied orders | Santiago Pastorino | 2010-09-05 | 1 | -2/+5 | |
| | | | | [5528 state:committed] | |||||
* | Make all the Relation finder methods consistent | Pratik Naik | 2010-08-31 | 1 | -32/+67 | |
| | ||||||
* | Merge remote branch 'miloops/rails_master_fixes' | Pratik Naik | 2010-08-31 | 1 | -15/+26 | |
|\ | ||||||
| * | Avoid calling build_where is no argument is given. | Emilio Tagua | 2010-08-31 | 1 | -1/+1 | |
| | | ||||||
| * | Improved conditionals usage to prevent calling methods. | Emilio Tagua | 2010-08-31 | 1 | -8/+19 | |
| | | ||||||
| * | Don't test conditional in iteration if it is not present just clone it. | Emilio Tagua | 2010-08-31 | 1 | -9/+9 | |
| | | ||||||
* | | Remove default values for Relation#limit/offset/from/create_with | Pratik Naik | 2010-08-31 | 1 | -4/+4 | |
|/ | ||||||
* | use blank? instead of present?, mark SQL literals as SQL literals | Aaron Patterson | 2010-08-25 | 1 | -5/+5 | |
| | | | | | | Conflicts: activerecord/lib/active_record/relation/query_methods.rb | |||||
* | no need to send on a public method | Aaron Patterson | 2010-08-25 | 1 | -1/+1 | |
| | ||||||
* | refactor select { is_a? } to grep() | Aaron Patterson | 2010-08-25 | 1 | -1/+1 | |
| | ||||||
* | sql literal strings should be marked as sql literal strings | Aaron Patterson | 2010-08-23 | 1 | -1/+3 | |
| | ||||||
* | we should wrap strings as sql literals | Aaron Patterson | 2010-08-19 | 1 | -1/+1 | |
| | ||||||
* | Ensure we can nest include calls [#5285 state:resolved] | Neeraj Singh | 2010-08-12 | 1 | -1/+1 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | subtracting blank strings is slightly faster than blank? | Aaron Patterson | 2010-08-11 | 1 | -3/+1 | |
| | ||||||
* | avoiding tap saves us time | Aaron Patterson | 2010-08-11 | 1 | -2/+6 | |
| | ||||||
* | unless Array#empty? is faster than if Array#present? | Aaron Patterson | 2010-08-11 | 1 | -1/+1 | |
| | ||||||
* | avoid passing lists of lists to the group clause | Aaron Patterson | 2010-08-04 | 1 | -1/+1 | |
| | ||||||
* | order query is already a string, no need to to_s | Aaron Patterson | 2010-08-03 | 1 | -2/+2 | |
| | ||||||
* | reverting where() functionality, adding a test | Aaron Patterson | 2010-07-30 | 1 | -4/+4 | |
| | ||||||
* | fewer method calls, using faster methods when possible | Aaron Patterson | 2010-07-30 | 1 | -5/+5 | |
| | ||||||
* | reducing function calls and using faster methods for testing | Aaron Patterson | 2010-07-30 | 1 | -9/+3 | |
| | ||||||
* | got the ternary backwards. somehow the sqlite tests passed! | Aaron Patterson | 2010-07-29 | 1 | -1/+1 | |
| | ||||||
* | PERF: avoiding splat args and reducing function calls | Aaron Patterson | 2010-07-29 | 1 | -8/+5 | |
| | ||||||
* | Shouldn't have committed this! Revert "avoid calling to_sql twice" | Aaron Patterson | 2010-07-28 | 1 | -7/+4 | |
| | | | | This reverts commit 1c030a3c3c61d6d6262785bf67e1d8f44da87ea5. | |||||
* | avoid calling to_sql twice | Aaron Patterson | 2010-07-28 | 1 | -4/+7 | |
| | ||||||
* | Revert "Style fixes" | Pratik Naik | 2010-07-15 | 1 | -20/+20 | |
| | | | | This reverts commit 3c300b31219f2af3ecd46ef22b04e5c5548db899. | |||||
* | Style fixes | wycats | 2010-07-14 | 1 | -20/+20 | |
| | ||||||
* | Style fixes | Pratik Naik | 2010-07-14 | 1 | -20/+20 | |
| | ||||||
* | Add scoping and unscoped as the syntax to replace the old with_scope and ↵ | José Valim | 2010-06-29 | 1 | -2/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with_exclusive_scope. A few examples: * with_scope now should be scoping: Before: Comment.with_scope(:find => { :conditions => { :post_id => 1 } }) do Comment.first #=> SELECT * FROM comments WHERE post_id = 1 end After: Comment.where(:post_id => 1).scoping do Comment.first #=> SELECT * FROM comments WHERE post_id = 1 end * with_exclusive_scope now should be unscoped: class Post < ActiveRecord::Base default_scope :published => true end Post.all #=> SELECT * FROM posts WHERE published = true Before: Post.with_exclusive_scope do Post.all #=> SELECT * FROM posts end After: Post.unscoped do Post.all #=> SELECT * FROM posts end Notice you can also use unscoped without a block and it will return an anonymous scope with default_scope values: Post.unscoped.all #=> SELECT * FROM posts | |||||
* | Remove unneeded reject | Santiago Pastorino | 2010-06-28 | 1 | -8/+1 | |
| | ||||||
* | Refactor: metaprogramming here it's confusing and make use of tap | Santiago Pastorino | 2010-06-26 | 1 | -64/+73 | |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Removes useless flatten | Santiago Pastorino | 2010-06-26 | 1 | -4/+9 | |
| | ||||||
* | Create a little bit less objects in ARel. | José Valim | 2010-06-26 | 1 | -6/+9 | |
| | ||||||
* | blocks removed from all the ActiveRelation query_methods, extend method ↵ | Santiago Pastorino | 2010-06-26 | 1 | -8/+4 | |
| | | | | | | added instead Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | reorder method added to ActiveRelation | Santiago Pastorino | 2010-06-26 | 1 | -0/+8 | |
| | | | | | | [#4972 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Support for multiple selects added | Neeraj Singh and Santiago Pastorino | 2010-06-25 | 1 | -4/+7 | |
| | | | | [#4841 state:committed] | |||||
* | Makes a build_select for the select part of build_arel | Santiago Pastorino | 2010-06-25 | 1 | -10/+13 | |
| | ||||||
* | Metaprogramming not needed here | Santiago Pastorino | 2010-06-25 | 1 | -11/+9 | |
| | ||||||
* | Only yield block if given. | Emilio Tagua | 2010-06-24 | 1 | -2/+2 | |
| | ||||||
* | Fix order method to accept relation attributes. | Emilio Tagua | 2010-06-22 | 1 | -1/+1 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Don't waste time building relations if there are no values presents. [#4860 ↵ | Emilio Tagua | 2010-06-21 | 1 | -4/+4 | |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Refactor build_arel: move joins out and simplify havings. [#4860 state:resolved] | Emilio Tagua | 2010-06-20 | 1 | -46/+46 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Special treatement for Relation#select { with block } | Pratik Naik | 2010-06-02 | 1 | -1/+14 | |
| | ||||||
* | To allow proper fisting of stack trace | Santiago Pastorino | 2010-05-14 | 1 | -3/+3 | |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Fix unintuitive behavior with multiple order and group clauses | Ernie Miller | 2010-05-06 | 1 | -6/+2 | |
| | | | | | | [#4545 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Fix eager loading of associations causing table name collisions | Ernie Miller | 2010-04-28 | 1 | -31/+42 | |
| | | | | | | [#4463 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Build PredicateBuilder object only when needed | Pratik Naik | 2010-04-21 | 1 | -3/+1 | |
| | ||||||
* | Fix evals missing context | Jeremy Kemper | 2010-04-10 | 1 | -3/+3 | |
| | ||||||
* | Avoid deprecated String#to_a by using Array.wrap(...) instead of Array(...) | Jeremy Kemper | 2010-04-10 | 1 | -1/+2 | |
| | ||||||
* | Add Relation extensions | Pratik Naik | 2010-04-02 | 1 | -4/+21 | |
| |